Received: by 2002:a05:6358:489b:b0:bb:da1:e618 with SMTP id x27csp7713336rwn; Wed, 14 Sep 2022 03:22:22 -0700 (PDT) X-Google-Smtp-Source: AA6agR640cZeBm0rRnghweBjC4jJKdiJTv5n42FK9LZu26/YepQ+js+RhclMtkTkiqkrIykki41z X-Received: by 2002:a63:2ace:0:b0:434:ebd5:e18e with SMTP id q197-20020a632ace000000b00434ebd5e18emr29656940pgq.79.1663150942221; Wed, 14 Sep 2022 03:22:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1663150942; cv=none; d=google.com; s=arc-20160816; b=FkG4dMzT2KbSiESwa5nc0Z0gMazPU4X5PmOUJ6AQkkHIpWo8jo2BJf67LUyc4jna1t kPNwPYGX1jtbiMTdLA0RL5V1TPjHmNXt8GrgV0sHcdu+kn7D45J+crOpybKslKUb5wHJ 97gjPIm7f7uJ67rBUEqcqlVXvr/LG520k245K4w4ONu1j227j0zHo5oRhv7SkeC51rWU v+L54bjvJZhDYpMMEaXiADkkkeHc7JZ1K+IRRr6bzOob5d0HPc87QiVDwJMaE9XaO1XO /USHCbEHFgL1JX5XppCBOKYEDKnzAaaWgmy6zA8Kt8KqVSIrj48q4svAlzPkEU5SGecl ZHqA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:organization:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=ttGz2CgnWLP85qawH5c4JAEnfcq7f0kRQc/J0FmY5FQ=; b=J6XMYkbWqF/AvCW96FYQ5Qt60Oy/YfeD0fuLiJhpysi+hTfpcl/dg4UXY1n+ZbLCTJ 8d/rn5JakNwylwY7yZGGh1UzNkpCmgZOwoHTkhGBj7/rId95ZTNMp6n4dMlJQHdyY04a qC7kkztlQMfoz/WkNoZRwMwGFLVz2Mwp4uVZc2oXfESTfWlsmIsLUCF+C3+3TPCLok7g gKjK0x6U/qstVlzPQ3UlEc+wTeXRqM8yhVESFSvvHbNVRyGfXCP0mX3WWimkbx7bz7Ea aBoChufvFCU4P+b88/VrnBgA8vkoPKc1vDXGKDp1z6eQYqnMpUOic2Nuunakr8L5s9GO y1og== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=HD2cffVn; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id w4-20020a056a0014c400b0052ab37ed70asi15797584pfu.57.2022.09.14.03.22.11; Wed, 14 Sep 2022 03:22:22 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=HD2cffVn; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231126AbiINJm5 (ORCPT + 99 others); Wed, 14 Sep 2022 05:42:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60080 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231172AbiINJm2 (ORCPT ); Wed, 14 Sep 2022 05:42:28 -0400 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 258EB32AB5; Wed, 14 Sep 2022 02:42:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1663148528; x=1694684528; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=KygSRb8RNrq6ueX2RVvRzI4GlM9IvgjpZfDFHSuvf9I=; b=HD2cffVnRwWgEaSEMDuD4Ok07WPghqktwKfpdnGWMsXlXK6lBYSV2ooz ndYfcn0HAx72JgbvVf1zQlguPxaplgAOR8zcH5NQzHhVJRbsKH/idNg7P RW1Dxl2x8yEiD/439ZZYvf/LH5BvLiGY3KsgGGSjtvJWxBFmSylltCGYe C3bNZJJD6U3xHkG0JTBdoxMhS8RsWb5/Zbh422ULWzvNvVwGD1X6KetbN z8p9Hfq28aCLIdNX3IVGLXY1ncRPSvbJNsQ4R/HpOXMWgisWCBwRbXf3e zmwdDDv2KeOM565P2YHjDrSTotx/cYGZKohfUu6LYoCUGWuYWs1hTu4n6 A==; X-IronPort-AV: E=McAfee;i="6500,9779,10469"; a="278114977" X-IronPort-AV: E=Sophos;i="5.93,315,1654585200"; d="scan'208";a="278114977" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Sep 2022 02:42:07 -0700 X-IronPort-AV: E=Sophos;i="5.93,315,1654585200"; d="scan'208";a="685251593" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Sep 2022 02:42:04 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1oYOu9-0028hA-2F; Wed, 14 Sep 2022 12:42:01 +0300 Date: Wed, 14 Sep 2022 12:42:01 +0300 From: Andy Shevchenko To: Raul Rangel Cc: Linux ACPI , linux-input , "jingle.wu" , "Limonciello, Mario" , Tim Van Patten , Linus Walleij , Hans de Goede , "Rafael J. Wysocki" , Mika Westerberg , Wolfram Sang , "open list:I2C SUBSYSTEM HOST DRIVERS" , linux-kernel Subject: Re: [PATCH v2 07/13] i2c: acpi: Use ACPI wake capability bit to set wake_irq Message-ID: References: <20220912221317.2775651-1-rrangel@chromium.org> <20220912160931.v2.7.I8af4282adc72eb9f247adcd03676a43893a020a6@changeid> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_PASS, SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 13, 2022 at 12:56:37PM -0600, Raul Rangel wrote: > On Tue, Sep 13, 2022 at 12:33 PM Andy Shevchenko > wrote: > > On Tue, Sep 13, 2022 at 12:07:53PM -0600, Raul Rangel wrote: ... > > This is similar to what of_i2c_get_board_info() does, no? > > Note: _get_ there. > > `*info` is an out parameter in that case. Ideally I would have > `i2c_acpi_get_irq`, `acpi_dev_gpio_irq_get_wake`, > `platform_get_irq_optional`, and `i2c_dev_irq_from_resources` all > return a `struct irq_info {int irq; bool wake_capable;}`. This would > be a larger change though. Seems the ACPI analogue is i2c_acpi_fill_info(). Can we do it there? -- With Best Regards, Andy Shevchenko