Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <3cdc2e776dea77b07c75694ba1410bd21e8ed749.1662902045.git.christophe.jaillet@wanadoo.fr>
 <fac99d27-2e28-3c08-4cf3-c97afec99b77@wanadoo.fr>
In-Reply-To: <fac99d27-2e28-3c08-4cf3-c97afec99b77@wanadoo.fr>
From:   Linus Walleij <linus.walleij@linaro.org>
Date:   Wed, 14 Sep 2022 12:23:55 +0200
Message-ID: <CACRpkdbA4m87swhTSGibMz9WUdpffdMkQwodZh2wknLOw9jmOQ@mail.gmail.com>
Subject: Re: [RFC PATCH] checkpatch: Check check for places where
 dev_err_probe() would likely be better than dev_err()
To:     Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc:     Andy Whitcroft <apw@canonical.com>, Joe Perches <joe@perches.com>,
        Dwaipayan Ray <dwaipayanray1@gmail.com>,
        Lukas Bulwahn <lukas.bulwahn@gmail.com>,
        linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Sun, Sep 11, 2022 at 3:21 PM Christophe JAILLET
<christophe.jaillet@wanadoo.fr> wrote:
> Le 11/09/2022 =C3=A0 15:15, Christophe JAILLET a =C3=A9crit :
> > Some functions are known to potentially return -EPROBE_DEFER. In such a
> > case, it is likely that dev_err_probe() is a better choice than err_err=
().
> >
> > dev_err_probe():
> >    - is usually less verbose
> >    - generates smaller .o files
> >    - handles -EPROBE_DEFER so that logs are not spammed
> >    - automatically log the error code in a human readable way
> >
> > Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> > ---
> > This patch is only a PoC to see if there is some interest in such a new
> > check.
> > The hard coded '5 lines of context' has been chosen because a typical
> > pattern is:
> >
> >       clk =3D devm_clk_get(dev, "clk_lcd");
> >       if (IS_ERR(clk) {
> >               dev_err(dev, "Error meesage\n");
> >               return PTR_ERR(clk);
> >       }
>
> (adding Linus Walleij)
>
>
> I forgot to say that this patch is a try to address the comment from
> Linus Walleij at [1].
>
> It would not help "fixing a gazillion dev_err_probe()", but it could
> help not having more to fix later :)

Needless to say I am a big fan of this patch!
Acked-by: Linus Walleij <linus.walleij@linaro.org>

Yours,
Linus Walleij