Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 14 Sep 2022 03:12:07 -0700
From:   Guenter Roeck <linux@roeck-us.net>
To:     Mathew McBride <matt@traverse.com.au>
Cc:     linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org,
        jdelvare@suse.com, krzysztof.kozlowski+dt@linaro.org,
        shawnguo@kernel.org, leoyang.li@nxp.com, robh+dt@kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/3] hwmon: add Microchip EMC230X fan controller driver
Message-ID: <20220914101207.GA938301@roeck-us.net>
References: <20220914053030.8929-1-matt@traverse.com.au>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220914053030.8929-1-matt@traverse.com.au>
Precedence: bulk

On Wed, Sep 14, 2022 at 05:30:27AM +0000, Mathew McBride wrote:
> The Microchip EMC230X (formerly made by SMSC) family of fan controllers
> provide PWM control for up to 5 fans (in the EMC2305). The EMC230X is
> capable of maintaining (closed-loop) a target RPM speed through PWM.
> 
> This driver has been tested with the EMC2301 (on our Traverse Ten64
> appliance) and with the EMC2305 demo board (ADM00879).
> 
> The driver is by no means complete, for example, further work would
> be required to support the different PWM output frequencies for
> voltage-based fan speed control. (So far this driver has only been
> tested with direct PWM capable fans, like the 4 pin fans found
> in recent PCs)
> 
> The emc230x driver also has thermal subsystem integration which allows
> the emc230x-controlled fan(s) to be used as cooling devices.

I just accepted a driver or emc2301/2/3/5. Please submit improvements
on top of that driver if needed; we won't have competing drivers
for the same chip in the kernel, and replacing a just accepted driver
smply does not make any sense.

Guenter