Received: by 2002:a05:6358:489b:b0:bb:da1:e618 with SMTP id x27csp7740756rwn; Wed, 14 Sep 2022 03:53:32 -0700 (PDT) X-Google-Smtp-Source: AA6agR6OV1uVSvpiH6M9a4v6/5dUdBrpxtuaPdyfAhLTy+dN2F+4of8l65eNBzjxM/95uyjUDUUD X-Received: by 2002:a17:907:e9e:b0:77f:9688:2714 with SMTP id ho30-20020a1709070e9e00b0077f96882714mr7361706ejc.208.1663152811976; Wed, 14 Sep 2022 03:53:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1663152811; cv=none; d=google.com; s=arc-20160816; b=kpzxyQlMU42JL3SCgKk8dLqp/lFiQhx4ym14CpUU4ziNPKyCK50uhTmwnYjULv3WDT YQ7HzDu+NtGv6QDlwLy8OTPezTpUBYb+oAn4a17WfVMCqo4tD+oGI1iXt3FCTCJpD9Sg IsYV2vPih3baXJRNHoVEUcB1UOCpCWzFQPDxM4V1kJN1bA0znzzvcG1e73l/OJ9S+cbp mv25siCFkSTrYJaDSf4QnLWSWFO9jl0vJUIbuwwjCR9FY0BEIRceVXKZ5BYcFne6Zcxh BI6LgAjfrL0MYkE1HD9NbmcwVg+53qDwEGkbMV4OuJ7Yps92MqRqLik6BvkSUwrTu713 4XTw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent:references:in-reply-to :subject:cc:to:from:message-id:date:dkim-signature:dkim-signature; bh=PcVLr9WYJ9BVec82oUwDDAjvUYAC4fWLz+GAaqfWCXo=; b=uDtP/pzyguUX8CSpqbf5ntAQ90K2CV/eXl8GxmHco/pIruB4W2L4ReEPptqC9PN5LQ iQvldpYyjJzqSbsKc6TornTxGe6Arrx7y6cQ6nIx8YH/2q5GjmREcgu0MGKByoWo8hJW j+Qu4trZTGvoQjuwOFkQbXgxZ6hHRxbF2hXk7q5kYbvAKaS1Pm/p8eSTVeOKk84OxrGK 4VprNPQxUY3XZqtwC32+kI/rkiTZ9CZEyjbK42TYdtK7wX01hg33HJUpERipppTvRwyP 4kyl8oimCiI4xkvmr3olC2bPqMIaPZH5warka8kZEwWU4LrFuR0YXze82IYBzu6kFxon llWA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=MgwbfYaj; dkim=neutral (no key) header.i=@suse.de; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id hc14-20020a170907168e00b0077ed84da316si7093365ejc.217.2022.09.14.03.53.05; Wed, 14 Sep 2022 03:53:31 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=MgwbfYaj; dkim=neutral (no key) header.i=@suse.de; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229948AbiINKoA (ORCPT + 99 others); Wed, 14 Sep 2022 06:44:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55430 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229473AbiINKn6 (ORCPT ); Wed, 14 Sep 2022 06:43:58 -0400 Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 57CFE78BF1 for ; Wed, 14 Sep 2022 03:43:57 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 034D11F74A; Wed, 14 Sep 2022 10:43:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1663152236; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=PcVLr9WYJ9BVec82oUwDDAjvUYAC4fWLz+GAaqfWCXo=; b=MgwbfYajHqSN62u/3AGxahwjTt1TldXfGpM2koBbr49QYqNgN4PbLDgwJD1bMrPrwp9xrK cywZ4mjJZoiM/Q6M8V+kLrjoieGenMFOqkryYRvTVCyyiuRspwwbZM6s0X2lar8LC4/Cmg 3XXMJBaFhOatgqUUKx2bkgUdjvATm2M= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1663152236; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=PcVLr9WYJ9BVec82oUwDDAjvUYAC4fWLz+GAaqfWCXo=; b=NCWFoNLkoDIpPHVzpHZxyVCPGETTUuFog5S0yZTTyxUsC41ox0mcCjM5vC+OQfMg3Ug93d jhzL03FOm67iaTBw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id BB75013494; Wed, 14 Sep 2022 10:43:55 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id cSEHLWuwIWMhTwAAMHmgww (envelope-from ); Wed, 14 Sep 2022 10:43:55 +0000 Date: Wed, 14 Sep 2022 12:43:55 +0200 Message-ID: <87v8pqtevo.wl-tiwai@suse.de> From: Takashi Iwai To: Mark Brown Cc: Gaosheng Cui , cezary.rojewski@intel.com, tiwai@suse.com, ranjani.sridharan@linux.intel.com, pierre-louis.bossart@linux.intel.com, perex@perex.cz, liam.r.girdwood@linux.intel.com, kai.vehmanen@linux.intel.com, peter.ujfalusi@linux.intel.com, yung-chuan.liao@linux.intel.com, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH -next] ASoC: Intel: fix unused-variable warning in probe_codec In-Reply-To: References: <20220822035133.2147381-1-cuigaosheng1@huawei.com> <166314841746.314266.6045600836637107787.b4-ty@kernel.org> <87zgf2tfn3.wl-tiwai@suse.de> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 14 Sep 2022 12:31:23 +0200, Mark Brown wrote: > > On Wed, Sep 14, 2022 at 12:27:28PM +0200, Takashi Iwai wrote: > > Mark Brown wrote: > > > > [1/1] ASoC: Intel: fix unused-variable warning in probe_codec > > > commit: 515626a33a194c4caaf2879dbf9e00e882582af0 > > > I thought the buggy commit 3fd63658caed9 was present only in my tree > > for now, but if it's in your tree, that's fine to apply through > > yours. Then I'll drop from mine. > > Huh, right - I think you're right here and it is only in your > tree, it just didn't trigger any issues in my coverage tests > prior to merge. Probably best to leave it in your tree and > either have a double apply or I'll revert it from mine. Either > way it'll get fixed by the time it gets sent to Linus. > > I'd not remembered that you had any extra stuff for ASoC in your > tree, sorry. No problem, it was rather an exception. I don't mind to keep in both trees; it should be resolved at the merge of ASoC tree before the PR to Linus, if any. thanks, Takashi