Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 14 Sep 2022 12:43:55 +0200
Message-ID: <87v8pqtevo.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     Mark Brown <broonie@kernel.org>
Cc:     Gaosheng Cui <cuigaosheng1@huawei.com>, cezary.rojewski@intel.com,
        tiwai@suse.com, ranjani.sridharan@linux.intel.com,
        pierre-louis.bossart@linux.intel.com, perex@perex.cz,
        liam.r.girdwood@linux.intel.com, kai.vehmanen@linux.intel.com,
        peter.ujfalusi@linux.intel.com, yung-chuan.liao@linux.intel.com,
        alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] ASoC: Intel: fix unused-variable warning in probe_codec
In-Reply-To: <YyGte0fkdquTxLC4@sirena.org.uk>
References: <20220822035133.2147381-1-cuigaosheng1@huawei.com>
        <166314841746.314266.6045600836637107787.b4-ty@kernel.org>
        <87zgf2tfn3.wl-tiwai@suse.de>
        <YyGte0fkdquTxLC4@sirena.org.uk>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Wed, 14 Sep 2022 12:31:23 +0200,
Mark Brown wrote:
> 
> On Wed, Sep 14, 2022 at 12:27:28PM +0200, Takashi Iwai wrote:
> > Mark Brown wrote:
> 
> > > [1/1] ASoC: Intel: fix unused-variable warning in probe_codec
> > >       commit: 515626a33a194c4caaf2879dbf9e00e882582af0
> 
> > I thought the buggy commit 3fd63658caed9 was present only in my tree
> > for now, but if it's in your tree, that's fine to apply through
> > yours.  Then I'll drop from mine.
> 
> Huh, right - I think you're right here and it is only in your
> tree, it just didn't trigger any issues in my coverage tests
> prior to merge.  Probably best to leave it in your tree and
> either have a double apply or I'll revert it from mine.  Either
> way it'll get fixed by the time it gets sent to Linus.
>
> I'd not remembered that you had any extra stuff for ASoC in your
> tree, sorry.

No problem, it was rather an exception.

I don't mind to keep in both trees; it should be resolved at the merge
of ASoC tree before the PR to Linus, if any.


thanks,

Takashi