Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 14 Sep 2022 12:27:28 +0200
Message-ID: <87zgf2tfn3.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     Mark Brown <broonie@kernel.org>
Cc:     Gaosheng Cui <cuigaosheng1@huawei.com>, cezary.rojewski@intel.com,
        tiwai@suse.com, ranjani.sridharan@linux.intel.com,
        pierre-louis.bossart@linux.intel.com, perex@perex.cz,
        liam.r.girdwood@linux.intel.com, kai.vehmanen@linux.intel.com,
        peter.ujfalusi@linux.intel.com, yung-chuan.liao@linux.intel.com,
        alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] ASoC: Intel: fix unused-variable warning in probe_codec
In-Reply-To: <166314841746.314266.6045600836637107787.b4-ty@kernel.org>
References: <20220822035133.2147381-1-cuigaosheng1@huawei.com>
        <166314841746.314266.6045600836637107787.b4-ty@kernel.org>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=ISO-8859-7
Content-Transfer-Encoding: 8bit
Precedence: bulk

On Wed, 14 Sep 2022 11:40:17 +0200,
Mark Brown wrote:
> 
> On Mon, 22 Aug 2022 11:51:33 +0800, Gaosheng Cui wrote:
> > In configurations with CONFIG_SND_SOC_INTEL_SKYLAKE_HDAUDIO_CODEC=n,
> > gcc warns about an unused variable:
> > 
> > sound/soc/intel/skylake/skl.c: In function ?probe_codec?:
> > sound/soc/intel/skylake/skl.c:729:18: error: unused variable ?skl? [-Werror=unused-variable]
> >   struct skl_dev *skl = bus_to_skl(bus);
> >                   ^~~
> > cc1: all warnings being treated as errors
> > 
> > [...]
> 
> Applied to
> 
>    broonie/sound.git for-next
> 
> Thanks!
> 
> [1/1] ASoC: Intel: fix unused-variable warning in probe_codec
>       commit: 515626a33a194c4caaf2879dbf9e00e882582af0
> 
> All being well this means that it will be integrated into the linux-next
> tree (usually sometime in the next 24 hours) and sent to Linus during
> the next merge window (or sooner if it is a bug fix), however if
> problems are discovered then the patch may be dropped or reverted.
> 
> You may get further e-mails resulting from automated or manual testing
> and review of the tree, please engage with people reporting problems and
> send followup patches addressing any issues that are reported if needed.
> 
> If any updates are required or you are submitting further changes they
> should be sent as incremental updates against current git, existing
> patches will not be replaced.
> 
> Please add any relevant lists and maintainers to the CCs when replying
> to this mail.

I thought the buggy commit 3fd63658caed9 was present only in my tree
for now, but if it's in your tree, that's fine to apply through
yours.  Then I'll drop from mine.


thanks,

Takashi