Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Siddh Raman Pant <code@siddh.me>
To:     Konstantin Komarov <almaz.alexandrovich@paragon-software.com>
Cc:     ntfs3 <ntfs3@lists.linux.dev>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        syzbot+9d67170b20e8f94351c8@syzkaller.appspotmail.com,
        stable@vger.kernel.org
Message-ID: <20220914111643.14411-1-code@siddh.me>
Subject: [PATCH] ntfs3: Fix memory leak in ntfs_fill_super()
Date:   Wed, 14 Sep 2022 16:46:43 +0530
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=utf8
Precedence: bulk

Mount options ptr wasn't freed before putting the superblock in
ntfs_fill_super(), which resulted in a memory leak.

Bug report: https://syzkaller.appspot.com/bug?id=3D332ba47915d0e39e94b42a62=
2f195f0804ecb67f

Fixes: 9b75450d6c58 ("fs/ntfs3: Fix memory leak if fill_super failed")
Reported-and-tested-by: syzbot+9d67170b20e8f94351c8@syzkaller.appspotmail.c=
om
Cc: stable@vger.kernel.org # 5.15
Signed-off-by: Siddh Raman Pant <code@siddh.me>
---
 fs/ntfs3/super.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/fs/ntfs3/super.c b/fs/ntfs3/super.c
index 47012c9bf505..c0e45f170701 100644
--- a/fs/ntfs3/super.c
+++ b/fs/ntfs3/super.c
@@ -1281,6 +1281,7 @@ static int ntfs_fill_super(struct super_block *sb, st=
ruct fs_context *fc)
 =09 * Free resources here.
 =09 * ntfs_fs_free will be called with fc->s_fs_info =3D NULL
 =09 */
+=09put_mount_options(sbi->options);
 =09put_ntfs(sbi);
 =09sb->s_fs_info =3D NULL;
=20
--=20
2.35.1