Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <5ffe3dfa-28a5-a5fc-0ae2-28927c39dc03@nvidia.com>
Date:   Wed, 14 Sep 2022 12:25:51 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH V1] PCI: dwc: Use dev_info for PCIe link down event
 logging
Content-Language: en-US
To:     Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
        Vidya Sagar <vidyas@nvidia.com>
Cc:     Bjorn Helgaas <helgaas@kernel.org>, jingoohan1@gmail.com,
        gustavo.pimentel@synopsys.com, lpieralisi@kernel.org,
        robh@kernel.org, kw@linux.com, bhelgaas@google.com,
        treding@nvidia.com, linux-pci@vger.kernel.org,
        linux-kernel@vger.kernel.org, kthota@nvidia.com,
        mmaddireddy@nvidia.com, sagar.tv@gmail.com
References: <b1c243b0-2e6e-3254-eff0-a5276020a320@nvidia.com>
 <20220913200746.GA619956@bhelgaas> <20220914062411.GD16459@workstation>
 <29b39edd-10ab-b679-f270-67b0b406ca2f@nvidia.com>
 <20220914111857.GF16459@workstation>
From:   Jon Hunter <jonathanh@nvidia.com>
In-Reply-To: <20220914111857.GF16459@workstation>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YTFBTEg4N2g2WTg1Y2I1cjVTa1ZwTlBaeVA2cjY1S1J6OVg1LzlGMnQ3cVVN?=
 =?utf-8?B?UTlKOGlUNmUrOCtNM0pMNHFoQ1o4ejFsTEwxN3QzNDN2TUhUTkJ4dHJqRU1y?=
 =?utf-8?B?MWNrK0JnL3lDV3YxSUxVT2drL2QrY0lTQ3FsdG9uUDkzNlZEN2x6V2tQRGcw?=
 =?utf-8?B?RVo4ZnlIajdZcjdkQzdFMGpGcjRZQjNxcklkU1JSR3EvSzJQOTJhVW1wTm5k?=
 =?utf-8?B?SWlBUUhpbjVjdWNNZy9JNXNDVG5OaExyTnR2Nm1MSUVDenNGYS96ZGEvSVhq?=
 =?utf-8?B?N0U1USt2akpiemJHZ2pIUkJQeWIwSlpaTEoremtucXRsQUtwbVlVZTJ3VHZF?=
 =?utf-8?B?aDVZWitXTWJpeXYvYWpZWWVGbUxrcnlVdWFUNW0xcEJ0bTY1eG1xQzlDOEtC?=
 =?utf-8?B?YTNwUTZSR3d5d3Jmb1dsZDNGWk5CRmxBL1ZrNDI4NHNDS3JSYXZuOThleGM4?=
 =?utf-8?B?aGY4M1pCYURvcEt5YVFmQlc4cXdEVUdSTUV3R3hOaXJRdENPQThSOEpGY0lp?=
 =?utf-8?B?ampNbzNCbnZOYnE1ZEgrSjNMNVVGd25zOVNsdXJkZDNCZ1NTZU5kc3ZGaVg2?=
 =?utf-8?B?amhBSml0cFZVbjFWdSs3MEVjTGEzNWRUVGtlWmVOd1p0ZUNPSHJSVkgvSG96?=
 =?utf-8?B?b2hEVTVGeTF5MXJkVzlCWVhIWDBLNkxmck5XNmdwQk9RQVk0NEFhbjRtaEhF?=
 =?utf-8?B?STEzdUhmbWYzRlZLbkJ5ZkhqanBkckNULy81aTdOaTlCK3VmVlUrbXhQTThT?=
 =?utf-8?B?S1hmby8yS3c5MjYzcGxDWWJtSGorZ24wcjNueEY0ZkFZcnAyQUJOS3lRRUpn?=
 =?utf-8?B?UjlsUlJab0o0b3VHOGp5eVJPcTh3T3FBaU9LcUFCZXVHNGZQNVRRL3RiV2M1?=
 =?utf-8?B?eWVHVG1IS2RwMzRJYkRrc0c4OUt3SER4QVlzYVdmMEJncmVhOEVya3FjVGVY?=
 =?utf-8?B?NE5TdllHUWUvWG5sanAybCtGWEpPMDN4TE9EQzlpajhPa0hJYTRtSlFQUlRL?=
 =?utf-8?B?T1UzdTgwdGptdzdaaVhQdmFpdWZjeG1MRWRCa0Q0amI2ZFJCZHVXWFNhUS9W?=
 =?utf-8?B?djJPMkNTRTU3TUNrd0QxQlR0d3BleDZOTU14VStkUSs5REVmWE9BMnJjTDhC?=
 =?utf-8?B?ZkVVM3ZhWWczbXZmRDBZOWlxeGVhM1pmdFFoK0FoS096T01nU1dzallkZWdv?=
 =?utf-8?B?b245SjYwQ29hdVZGdVp1TXRld01SbU1qSjJub1JoU0lwWVBBQ1FjUnFTcFQ2?=
 =?utf-8?B?WlJoSWx2WjlwUHZQWjRNRzVtSDBOWjJqN1JYQk04eDZaSWtObVNKOE14VGZj?=
 =?utf-8?B?M1lOMmJvZGFCOTFVVEI0RjJneHJEZ0JDSTNRMEpNaldQNm1qek5vbDNDWnNy?=
 =?utf-8?B?VktJVGdjWXRCbUtrdGZGaXB1N1E2V1VreVJyazJVdTRaMEJkNjJnUUl0N0Rl?=
 =?utf-8?B?YkRCOEtJbGZzbjhnSnpWbjVxelNEWXFLQ0EySHZpRUV1VFdhY3RuQ2VSQ2Ir?=
 =?utf-8?B?Qmx2L2h0VWFCT3NBcGN6ZXpMeCsyZ3ZJS245Y3cvUVF6SUdnTmc4dlg3bm9t?=
 =?utf-8?B?eXg0K0tDNmFVTVNLWU9JY2JCUWZkZzRBdXJaaDJQaG5VY0xHblgrcTVPbHZ5?=
 =?utf-8?B?amNTVStKbUN3cXZxdmNkR0dTeWc0MjZwS29hSHQvVmxwbG8wcW14Qy90ekF4?=
 =?utf-8?B?ZGFmMWRZeDlDcTFUR1VVL040VGZESjZnWnNFbmFlcG4yYXlVSlhtd2tYWlBD?=
 =?utf-8?B?TUtmTVRSc3cvSmg5MEhrekZ2OVlYempIZ2tpWHZqdVdNeUJFaHJIZlJ5ODNL?=
 =?utf-8?B?a0VDZUllNVhXczJGU1hza0x0UTBtSjJYQmVxYVVOTXZ2RFk4azQyZHFjL000?=
 =?utf-8?B?SWtFc3FVSWw2cEc0dEhMVi8xRHJWb0k4QlNwdDloTFpIdFhJZTRhd0hYVjVi?=
 =?utf-8?B?QzMwcnNlS0VLM1BRWTJKS2F6ckVRL3BzbEVsVXQ2VGxJdmpaUTlOdWhHWVVk?=
 =?utf-8?B?OUFtZDBlZmdlRkU4eEhpbEMyTDRzelE5YXFxVTZEUDE4cTRoaVB1U2dKcURB?=
 =?utf-8?B?SUdoRkN6VUt4azFpUU1zVm1OYVdJYzhZY0RDUlNZQkp6NS9MRjlRUVJxc0VT?=
 =?utf-8?B?YWpzSlR1MHp0eERmWFZMTDRzRytweDNIQ1V6UFgxTUVLNkFSNERnYWpqeGly?=
 =?utf-8?B?bEhuTGVMc0UwMzArUXE1VTNxYy9aMktROHpyaEt3YzVJL29vcVVJUUI1SDl4?=
 =?utf-8?B?YURPNzZGaHNDQ0ZqbmdFSFJZSWN3PT0=?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2c530cfe-5745-4c29-5672-08da9643e5a0
X-MS-Exchange-CrossTenant-AuthSource: CO6PR12MB5444.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Sep 2022 11:25:58.8311
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: kEZ60473a+vhHrjnj/5tUWOK47rKWhFGzO+Y15zSdsqoJvhypj4CYWKvJmVn/PPwgzNX0MTu1wM5NLSLbEctrg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR12MB4588
X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,
        SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 14/09/2022 12:18, Manivannan Sadhasivam wrote:
> On Wed, Sep 14, 2022 at 04:32:10PM +0530, Vidya Sagar wrote:
>> Agree with Mani.
>> Not all form factors support PRSNT pin (Ex:- M.2 Key-M form factor) and even
>> if the slot form factor supports PRSNT, it is not mandatory to have a GPIO
>> routed to the PRSNT pin of the slot.
> 
> Right.
> 
>> Also, since these are development platforms, we wouldn't want to keep
>> changing a controller's status in the DT, instead want to know the device's
>> presence/absence (by way of link up) looking at the log.
>> In my honest opinion, I don't think the absence of a device in the slot
>> should be treated as an error.
>>
> 
> As I mentioned earlier, timeout can happen due to an issue with PHY layer
> also. In those cases, "dev_err()" is relevant.
> 
> And I also agree that absence of the device should not be treated as an
> error. But my question is, if you know that the slot is going to be
> empty always, why cannot you just disable it in dts?

I really don't think that makes sense from a usability perspective. You 
want to allow users to connect PCI cards and for them to work without 
having to update the DTB. I have plenty of open PCI slots on my PC and I 
would be a bit upset if someone told me I need to update the PC firmware 
each time I wanted to use a new slot.

Jon

-- 
nvpublic