Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <02ef1ae2-9dae-6f02-9951-1230939f06e2@linux.intel.com>
Date:   Wed, 14 Sep 2022 15:28:09 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Firefox/91.0 Thunderbird/91.11.0
Subject: Re: [PATCH] xhci: Don't show warning for reinit on known broken
 suspend
Content-Language: en-US
To:     Mario Limonciello <mario.limonciello@amd.com>,
        Mathias Nyman <mathias.nyman@intel.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Puma Hsu <pumahsu@google.com>
Cc:     "Artem S . Tashkinov" <aros@gmx.com>, linux-usb@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20220913203515.451-1-mario.limonciello@amd.com>
From:   Mathias Nyman <mathias.nyman@linux.intel.com>
In-Reply-To: <20220913203515.451-1-mario.limonciello@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 13.9.2022 23.35, Mario Limonciello wrote:
> commit 8b328f8002bc ("xhci: re-initialize the HC during resume if HCE was
> set") introduced a new warning message when the host controller error
> was set and re-initializing.
> 
> This is expected behavior on some designs which already set
> `xhci->broken_suspend` so the new warning is alarming to some users.
> 
> Modify the code to only show the warning if this was a surprising behavior
> to the XHCI driver.
> 
> Fixes: 8b328f8002bc ("xhci: re-initialize the HC during resume if HCE was set")
> Link: https://bugzilla.kernel.org/show_bug.cgi?id=216470
> Reported-by: Artem S. Tashkinov <aros@gmx.com>
> Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
> ---

Thanks, adding to queue

-Mathias