Received: by 2002:a05:6358:489b:b0:bb:da1:e618 with SMTP id x27csp7928414rwn; Wed, 14 Sep 2022 06:37:39 -0700 (PDT) X-Google-Smtp-Source: AA6agR5nkIx8wKJnaef27A+K80frWnrCD7Q3ymeOXNrGv9aoG2bRbQKSEJFl6jNDRCdGq5w+wFrr X-Received: by 2002:a17:902:820f:b0:176:9654:354d with SMTP id x15-20020a170902820f00b001769654354dmr36308898pln.79.1663162658821; Wed, 14 Sep 2022 06:37:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1663162658; cv=none; d=google.com; s=arc-20160816; b=sOz54rAn3wwsYif9ZL+3z6Zrz7GC7qYIN1uz9Wlz/1u8By/LxrV7iFo2el6bae5Wid zKoyhneGx4g+2JoV9elVRXKNGNKYsT1YC4zbNisfOQbXUAfVYkDmZ2gGEcNhvMZb2KPp DoMmkg1XsYICcGGsTo2auoDq4lRmHjC+NRI2jTs0HUtM5NcnJAEzoXZZm5c8osPowiE7 Zn1RB54YYAScMb6S9gdlqWX+62T6lU/JOmqCYegDNEr/6OAmI4TDteL/MRvMLa3fkHNG mFw8M7pWnexzxilpNpjyxwO2o3zxlSu/15NNYo6Kh+87WK7EKSjel64j04hrEz4sXQYU /ZKQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=K6WJMwP9TbXezrcFsb+pta0EfIwLar+TBDNhiWZanb0=; b=i+msLl5CejkasPt+COzBbKSNz3FwwHyB0lBiMbP7DEZzUhlyMOUfLEBJPACYyTyP1m 3HrZUXyqQvlsaZTYn1OpFMu0NMak5Sx610nCT68/lon+5g8FiOvChATiODENXJ4V4azH +HYtCjsTqj+Lu5LS+yNxS4oObSl0zBteeSIYpB0OMw+h+XiHR/XiVVV0k0snuI/2gnIX JYKgNFMgVtztaOZrLEwa1346v7CMxIxIqgixO20lwQWSO7jTFY5u7iuxSMndgb/duaOI B96VLZKlWCKT1lv1frVRR43LKO0U+EEh0F93CRIeHILbAhbg1jhOZ5p/50oUTcLRuwED nKWA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=D8ZN2cUS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id l7-20020a63ea47000000b0043077f2f57asi15502613pgk.213.2022.09.14.06.37.26; Wed, 14 Sep 2022 06:37:38 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=D8ZN2cUS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229738AbiINMur (ORCPT + 99 others); Wed, 14 Sep 2022 08:50:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51088 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229719AbiINMuo (ORCPT ); Wed, 14 Sep 2022 08:50:44 -0400 Received: from mail-ed1-x531.google.com (mail-ed1-x531.google.com [IPv6:2a00:1450:4864:20::531]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F14E677554 for ; Wed, 14 Sep 2022 05:50:43 -0700 (PDT) Received: by mail-ed1-x531.google.com with SMTP id z13so8099677edb.13 for ; Wed, 14 Sep 2022 05:50:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=K6WJMwP9TbXezrcFsb+pta0EfIwLar+TBDNhiWZanb0=; b=D8ZN2cUS/7eafu5ZwZde+hRVJf2S46PebOPPENpiKd9lNrz5CJi53nP6CIrrJe/Hd1 z44RBizqYQcRgt26Q52haOYkE0fbeXXI7mgKb7nW6EMibuIjz19GVLkPJg3qt4FymWBc cYPaGZzF2XEltkWIXtWntX4s8a2loBTKXdLf6+yAwihMjp2eyKUEVnRgEvLoFWBL6Sgs KhnIhHfyj9AvGV79m0dwN3YfwqArL/8xZNw53is2t7SAkanxWiEMOYfoLpxH2OVIr2/f 8DAYix1pJKP4Ne6/hWj1fvKJ8I3pqaLhynXwZAvd03x/hBT7KJfJkk3Um2a7iUD4cdwl HTjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=K6WJMwP9TbXezrcFsb+pta0EfIwLar+TBDNhiWZanb0=; b=BiGgEi09SmW9+RuG9G0tj7BnuZ7GtGvG85kVMiVhbAhUe8XtFwFG/oqzivJp+a3b+T MnRY/m1Ug0h0vu0eLInsxRZ9qu8yROr52CHt6SKNix3aqb5KK5pjs+d4Z+dg9Y/VYXSd SNpAdr4ZS/tye8m+pn0yoyxrzAlcazBrcVR2XG8K5s7nZ9eP7exTyE85DbIlqPFiTi3p EhmzlIP0cMMcfk0C+PRKozEBIfHAoxx59KQ1KqOUgq0xx9YSi2JASCPwTGqyeKaRwqSn ihXRTmm+7os+/2MSaoYldG1ZYDOwIAout25INGLZ5nwfwT/vLlbXnc+S4Yr6v2hDMyVu N97w== X-Gm-Message-State: ACgBeo32bd8gOy4RPxBaa92qVJCRAyBx9T/nvxe4yV1Bb3PF9/aYdFee 5qz7+wHdxYX2ZkscK+kDTRWROvkhDGrcUMavUvcYBBCbZJs= X-Received: by 2002:a05:6402:4517:b0:443:7fe1:2d60 with SMTP id ez23-20020a056402451700b004437fe12d60mr30408220edb.133.1663159842597; Wed, 14 Sep 2022 05:50:42 -0700 (PDT) MIME-Version: 1.0 References: <20220913071659.94677-1-wupeng58@huawei.com> In-Reply-To: <20220913071659.94677-1-wupeng58@huawei.com> From: Linus Walleij Date: Wed, 14 Sep 2022 14:50:31 +0200 Message-ID: Subject: Re: [PATCH] mfd: htc-i2cpld: Fix an IS_ERR() vs NULL bug in htcpld_core_probe To: Peng Wu Cc: lee@kernel.org, linux-kernel@vger.kernel.org, liwei391@huawei.com Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 13, 2022 at 9:19 AM Peng Wu wrote: > The gpiochip_request_own_desc() function returns error pointers on error, > it doesn't return NULL. > > Fixes: 0ef5164a81fbf ("mfd/omap1: htc-i2cpld: Convert to a pure GPIO driver") > Signed-off-by: Peng Wu Good catch! Reviewed-by: Linus Walleij Yours, Linus Walleij