Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220914075213.4998-1-hanyihao@vivo.com>
In-Reply-To: <20220914075213.4998-1-hanyihao@vivo.com>
From:   Alex Deucher <alexdeucher@gmail.com>
Date:   Wed, 14 Sep 2022 10:01:15 -0400
Message-ID: <CADnq5_O8N-_kbYtsM0DMR+zDE+6wJ+gGQFUjYgUHkoZcaQJg9Q@mail.gmail.com>
Subject: Re: [PATCH] drm/amd/display: fix boolconv.cocci warning
To:     Yihao Han <hanyihao@vivo.com>
Cc:     Harry Wentland <harry.wentland@amd.com>,
        Leo Li <sunpeng.li@amd.com>,
        Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>,
        Alex Deucher <alexander.deucher@amd.com>,
        =?UTF-8?Q?Christian_K=C3=B6nig?= <christian.koenig@amd.com>,
        "Pan, Xinhui" <Xinhui.Pan@amd.com>,
        David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>,
        Jiapeng Chong <jiapeng.chong@linux.alibaba.com>,
        Aurabindo Pillai <aurabindo.pillai@amd.com>,
        Martin Leung <Martin.Leung@amd.com>,
        amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Applied.  Thanks!

On Wed, Sep 14, 2022 at 3:53 AM Yihao Han <hanyihao@vivo.com> wrote:
>
> ./drivers/gpu/drm/amd/display/dc/dcn32/dcn32_mpc.c:729:63-68:
> WARNING: conversion to bool not needed here
>
> Generated by: scripts/coccinelle/misc/boolconv.cocci
> Signed-off-by: Yihao Han <hanyihao@vivo.com>
> ---
>  drivers/gpu/drm/amd/display/dc/dcn32/dcn32_mpc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/dcn32/dcn32_mpc.c b/drivers/gpu/drm/amd/display/dc/dcn32/dcn32_mpc.c
> index f4bc77972c4e..4edd0655965b 100644
> --- a/drivers/gpu/drm/amd/display/dc/dcn32/dcn32_mpc.c
> +++ b/drivers/gpu/drm/amd/display/dc/dcn32/dcn32_mpc.c
> @@ -726,7 +726,7 @@ static bool mpc32_program_shaper(
>         else
>                 next_mode = LUT_RAM_A;
>
> -       mpc32_configure_shaper_lut(mpc, next_mode == LUT_RAM_A ? true:false, mpcc_id);
> +       mpc32_configure_shaper_lut(mpc, next_mode == LUT_RAM_A, mpcc_id);
>
>         if (next_mode == LUT_RAM_A)
>                 mpc32_program_shaper_luta_settings(mpc, params, mpcc_id);
> --
> 2.17.1
>