Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Aakarsh Jain" <aakarsh.jain@samsung.com>
To:     "'Krzysztof Kozlowski'" <krzysztof.kozlowski@linaro.org>,
        "'Smitha T Murthy'" <smitha.t@samsung.com>,
        <linux-arm-kernel@lists.infradead.org>,
        <linux-media@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <devicetree@vger.kernel.org>
Cc:     <m.szyprowski@samsung.com>, <andrzej.hajda@intel.com>,
        <mchehab@kernel.org>, <hverkuil-cisco@xs4all.nl>,
        <ezequiel@vanguardiasur.com.ar>, <jernej.skrabec@gmail.com>,
        <benjamin.gaignard@collabora.com>, <stanimir.varbanov@linaro.org>,
        <dillon.minfei@gmail.com>, <david.plowman@raspberrypi.com>,
        <mark.rutland@arm.com>, <robh+dt@kernel.org>, <krzk+dt@kernel.org>,
        <andi@etezian.org>, <alim.akhtar@samsung.com>,
        <aswani.reddy@samsung.com>, <pankaj.dubey@samsung.com>,
        <linux-fsd@tesla.com>, <aakarsh.jain@samsung.com>
In-Reply-To: <7a164961-5b32-8d80-a6f6-8c9f64622085@linaro.org>
Subject: RE: [Patch v2 01/15] dt-bindings: media: s5p-mfc: Add new DT schema
 for MFC
Date:   Wed, 14 Sep 2022 18:18:13 +0530
Message-ID: <011f01d8c838$43234ba0$c969e2e0$@samsung.com>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Thread-Index: AQIwYET59QqMDNmfP0SYfUTdtmHMHgGIcczBAeDI2w8CVnGc/wIQr8+8ApxhNais3ElrcA==
Content-Language: en-in
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 105P
DLP-Filter: Pass
References: <20220907064715.55778-1-smitha.t@samsung.com>
        <CGME20220907063313epcas5p114f793010fd0f2797e93bd83ed18a1d7@epcas5p1.samsung.com>
        <20220907064715.55778-2-smitha.t@samsung.com>
        <08168057-853c-5b17-7d88-dc6c30e82f14@linaro.org>
        <000101d8c382$75750e00$605f2a00$@samsung.com>
        <7a164961-5b32-8d80-a6f6-8c9f64622085@linaro.org>
Precedence: bulk


> -----Original Message-----
> From: Krzysztof Kozlowski =5Bmailto:krzysztof.kozlowski=40linaro.org=5D
> Sent: 08 September 2022 20:41
> To: Aakarsh Jain <aakarsh.jain=40samsung.com>; 'Krzysztof Kozlowski'
> <krzysztof.kozlowski=40linaro.org>; 'Smitha T Murthy'
> <smitha.t=40samsung.com>; linux-arm-kernel=40lists.infradead.org; linux-
> media=40vger.kernel.org; linux-kernel=40vger.kernel.org;
> devicetree=40vger.kernel.org
> Cc: m.szyprowski=40samsung.com; andrzej.hajda=40intel.com;
> mchehab=40kernel.org; hverkuil-cisco=40xs4all.nl;
> ezequiel=40vanguardiasur.com.ar; jernej.skrabec=40gmail.com;
> benjamin.gaignard=40collabora.com; stanimir.varbanov=40linaro.org;
> dillon.minfei=40gmail.com; david.plowman=40raspberrypi.com;
> mark.rutland=40arm.com; robh+dt=40kernel.org; krzk+dt=40kernel.org;
> andi=40etezian.org; alim.akhtar=40samsung.com; aswani.reddy=40samsung.com=
;
> pankaj.dubey=40samsung.com; linux-fsd=40tesla.com
> Subject: Re: =5BPatch v2 01/15=5D dt-bindings: media: s5p-mfc: Add new DT
> schema for MFC
>=20
> On 08/09/2022 14:56, Aakarsh Jain wrote:
> >
> >
> >> -----Original Message-----
> >> From: Krzysztof Kozlowski =5Bmailto:krzysztof.kozlowski=40linaro.org=
=5D
> >> Sent: 07 September 2022 16:52
> >> To: Smitha T Murthy <smitha.t=40samsung.com>; linux-arm-
> >> kernel=40lists.infradead.org; linux-media=40vger.kernel.org; linux-
> >> kernel=40vger.kernel.org; devicetree=40vger.kernel.org
> >> Cc: m.szyprowski=40samsung.com; andrzej.hajda=40intel.com;
> >> mchehab=40kernel.org; hverkuil-cisco=40xs4all.nl;
> >> ezequiel=40vanguardiasur.com.ar; jernej.skrabec=40gmail.com;
> >> benjamin.gaignard=40collabora.com; stanimir.varbanov=40linaro.org;
> >> dillon.minfei=40gmail.com; david.plowman=40raspberrypi.com;
> >> mark.rutland=40arm.com; robh+dt=40kernel.org; krzk+dt=40kernel.org;
> >> andi=40etezian.org; alim.akhtar=40samsung.com;
> aswani.reddy=40samsung.com;
> >> pankaj.dubey=40samsung.com; linux-fsd=40tesla.com;
> >> aakarsh.jain=40samsung.com
> >> Subject: Re: =5BPatch v2 01/15=5D dt-bindings: media: s5p-mfc: Add new=
 DT
> >> schema for MFC
> >>
> >> On 07/09/2022 08:47, Smitha T Murthy wrote:
> >>> Adds DT schema for s5p-mfc in yaml format
> >>
> >> s/Adds/Convert/
> >> (as convert to DT schema)
> >>
> > ok, I will change.
> >
> >> Please mention here changes to original binding (I see at least
> >> adding iommus and dropping some properties).
> >>
> > ok. I will make this changes.
> >>>
> >>> Signed-off-by: Aakarsh Jain <aakarsh.jain=40samsung.com>
> >>> Signed-off-by: Smitha T Murthy <smitha.t=40samsung.com>
> >>> ---
> >>>  .../devicetree/bindings/media/s5p-mfc.txt     =7C  77 +------------
> >>>  .../bindings/media/samsung,s5p-mfc.yaml       =7C 109
> >> ++++++++++++++++++
> >>>  2 files changed, 110 insertions(+), 76 deletions(-)  create mode
> >>> 100644 Documentation/devicetree/bindings/media/samsung,s5p-
> mfc.yaml
> >>>
> >>> diff --git a/Documentation/devicetree/bindings/media/s5p-mfc.txt
> >>> b/Documentation/devicetree/bindings/media/s5p-mfc.txt
> >>> index aa54c8159d9f..0b7c4dd40095 100644
> >>> --- a/Documentation/devicetree/bindings/media/s5p-mfc.txt
> >>> +++ b/Documentation/devicetree/bindings/media/s5p-mfc.txt
> >>> =40=40 -1,76 +1 =40=40
> >>> -* Samsung Multi Format Codec (MFC)
> >>> -
> >>> -Multi Format Codec (MFC) is the IP present in Samsung SoCs which
> >>> -supports high resolution decoding and encoding functionalities.
> >>> -The MFC device driver is a v4l2 driver which can encode/decode
> >>> -video raw/elementary streams and has support for all popular -video
> codecs.
> >>> -
> >>> -Required properties:
> >>> -  - compatible : value should be either one among the following
> >>> -	(a) =22samsung,mfc-v5=22 for MFC v5 present in Exynos4 SoCs
> >>> -	(b) =22samsung,mfc-v6=22 for MFC v6 present in Exynos5 SoCs
> >>> -	(c) =22samsung,mfc-v7=22 for MFC v7 present in Exynos5420 SoC
> >>> -	(d) =22samsung,mfc-v8=22 for MFC v8 present in Exynos5800 SoC
> >>> -	(e) =22samsung,exynos5433-mfc=22 for MFC v8 present in Exynos5433
> >> SoC
> >>> -	(f) =22samsung,mfc-v10=22 for MFC v10 present in Exynos7880 SoC
> >>> -
> >>> -  - reg : Physical base address of the IP registers and length of me=
mory
> >>> -	  mapped region.
> >>> -
> >>> -  - interrupts : MFC interrupt number to the CPU.
> >>> -  - clocks : from common clock binding: handle to mfc clock.
> >>> -  - clock-names : from common clock binding: must contain =22mfc=22,
> >>> -		  corresponding to entry in the clocks property.
> >>> -
> >>> -Optional properties:
> >>> -  - power-domains : power-domain property defined with a phandle
> >>> -			   to respective power domain.
> >>> -  - memory-region : from reserved memory binding: phandles to two
> >> reserved
> >>> -	memory regions, first is for =22left=22 mfc memory bus interfaces,
> >>> -	second if for the =22right=22 mfc memory bus, used when no SYSMMU
> >>> -	support is available; used only by MFC v5 present in Exynos4 SoCs
> >>> -
> >>> -Obsolete properties:
> >>> -  - samsung,mfc-r, samsung,mfc-l : support removed, please use
> >>> memory-
> >> region
> >>> -	property instead
> >>
> >> When did they become obsolete? Is it enough of time to remove them?
> >
> > these properties were there earlier, we didn't added them in obsolete
> properties.
>=20
> This is not the answer to my question. Is it enough of time to remove
> deprecated properties?
>=20
sorry I misunderstood. These two mfc-l and mfc-r are still used in mfcv5 ve=
rsion as they use MFC_NUM_PORTS as 2, so we cannot make them obsolete yet. =
In next patch series we will add allOf: if: else: conditions for all the pr=
operties of each compatible string.
Thanks for the review.
>=20
>=20
> Best regards,
> Krzysztof