Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 14 Sep 2022 09:11:22 -0500
From:   Bjorn Andersson <andersson@kernel.org>
To:     Vinod Koul <vkoul@kernel.org>
Cc:     Stephen Boyd <sboyd@kernel.org>, linux-arm-msm@vger.kernel.org,
        linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        devicetree@vger.kernel.org, Rob Herring <robh@kernel.org>
Subject: Re: [PATCH v4 1/2] dt-bindings: spmi: Add qcom,bus-id
Message-ID: <20220914141122.td5y4dzp5ercuvpj@builder.lan>
References: <20220914112139.3680354-1-vkoul@kernel.org>
 <20220914112139.3680354-2-vkoul@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220914112139.3680354-2-vkoul@kernel.org>
Precedence: bulk

On Wed, Sep 14, 2022 at 04:51:38PM +0530, Vinod Koul wrote:
> For PMIC arbiter version 7 and beyond we need to define if we are using
> primary or secondary bus, so add a new property of qcom,bus-id
> 
> Signed-off-by: Vinod Koul <vkoul@kernel.org>
> Acked-by: Rob Herring <robh@kernel.org>
> ---
>  .../devicetree/bindings/spmi/qcom,spmi-pmic-arb.yaml  | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/spmi/qcom,spmi-pmic-arb.yaml b/Documentation/devicetree/bindings/spmi/qcom,spmi-pmic-arb.yaml
> index fee4f0eb4665..aa8e891b2bb4 100644
> --- a/Documentation/devicetree/bindings/spmi/qcom,spmi-pmic-arb.yaml
> +++ b/Documentation/devicetree/bindings/spmi/qcom,spmi-pmic-arb.yaml
> @@ -85,6 +85,14 @@ properties:
>      description: >
>        which of the PMIC Arb provided channels to use for accesses
>  
> +  qcom,bus-id:
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    minimum: 0
> +    maximum: 1
> +    description: >
> +      SPMI bus instance. only applicable to PMIC arbiter version 7 and beyond.
> +      Supported values, 0 = primary bus, 1 = secondary bus
> +
>  required:
>    - compatible
>    - reg-names
> @@ -113,5 +121,8 @@ examples:
>  
>          interrupt-controller;
>          #interrupt-cells = <4>;
> +
> +        qcom,bus-id = <0>;
> +

As you correct the author on patch 2/2, please drop this last empty
line.

Thanks,
Bjorn

>      };
>  
> -- 
> 2.37.3
>