Received: by 2002:a05:6358:489b:b0:bb:da1:e618 with SMTP id x27csp8003703rwn; Wed, 14 Sep 2022 07:36:44 -0700 (PDT) X-Google-Smtp-Source: AA6agR7yEXX//I1UQpyROCPTf6QD2tLJQX3mBd3JVOfs7A2q+ZZpYiymw/6ZKj/afWtdbwe4GQh8 X-Received: by 2002:a17:902:f606:b0:172:9c81:d788 with SMTP id n6-20020a170902f60600b001729c81d788mr36264976plg.42.1663166204118; Wed, 14 Sep 2022 07:36:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1663166204; cv=none; d=google.com; s=arc-20160816; b=MhWMFPnqqFDXTdilgeSkTZHoGED0nUHdZBWu6ox6v4fqeG3Z0L3tUZo1buHXS5IThY BTDrgKeo/20pv9ZHWZNlbGgf+PAorjCoXriZT1XEQFWkK0AWuRS0NhHYkoRuZQ6pjz/K JfyOCvCeS+rPE/7BxXCuspXgRTW5KxGJczdHnd4/5sq+CIxzzTbAdwlTmRsNFu1ckz52 R63mZwb6Hnp7Djg/Ji591mmr2aFtu1Oo41aFPLVATH/DCFi0DyY35Hue2/AEZpfE2Zct 72sxxpyTGUyaSdNKw9hEaUcU+sPjnxj9KQtoi+14Wo9uluNF7kTV3Auvk9MRHjUsCcYS tmQw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=RtJol4YS6sjuVDCVTSrpxuH2lPLMzFmXpCg6CjZNlf0=; b=oynPU2vv3fGmKTQZISZDzcAqle8tpzz0NR/F8Mxd38Qh0sBass57Htfj0MFrrZ8wse SX/XAQ2rvKI/iR4ALP8Cdsxnj9vfh+04foyCQaxJU2LagIQ4mQIt1fhpxeU9bGRaV2/Z L4OURlQL17ExvKcvRC70KRI9eB3b9gMvzZ7OJtfrL/V5xCx3TIateb6VwNhp++Q2lJYo 5CI5T0C5evPDS3Xm0rwYSDAXy/b/uAV4XI4yJA42IzhiTO9mIQrQK44/KdbmbWKaeF77 rsp5ryZ3tKwWUHPEEH5mH0yOs5tG7aXOKpVb4SM+VXlFTtDa9yeyKZknVjYb55YHsG7A CVYw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=OtqY7flp; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id nn17-20020a17090b38d100b00202dd7a4d3csi8730308pjb.113.2022.09.14.07.36.31; Wed, 14 Sep 2022 07:36:44 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=OtqY7flp; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229861AbiINOLN (ORCPT + 99 others); Wed, 14 Sep 2022 10:11:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42108 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230017AbiINOK4 (ORCPT ); Wed, 14 Sep 2022 10:10:56 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AEACF2FFCA; Wed, 14 Sep 2022 07:10:47 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 5550461DCE; Wed, 14 Sep 2022 14:10:47 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 43711C433D6; Wed, 14 Sep 2022 14:10:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1663164646; bh=RKdAhJmHQHgkapWrL0u+5jLAaWEEGdAMCSADr+xPYUw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=OtqY7flpg+M1CWCSEXVW6LxWxXq/A/NH0mnm9idjlh5dQQCdBaAabLaks6Y0QGlvu suSH5979UEv7SHohINDqBERrtCZlZLSY9Vr8geNQ9nxgWwDzVz5cw3/lF5ImjhHBQT v3WmVuQdiaRbytFenRzR/M5Kd2Wy0npYe43+hqx1BgY8Q9xxkX1TumlqGrg4GlmPKo eybHdBUGPMARfHc94unkihGJxmjtMkUOg/CRe15k/fEcKoBD4QdUq+UytrhoXsIXcN FW297Sw+7jknECFpVbdcU2K7ZuMP2GhbJUo10BBG40kRucJyvMjJJB79QBBTF1ul0a z4MKxj6SlE5Yw== Date: Wed, 14 Sep 2022 09:10:44 -0500 From: Bjorn Andersson To: Vinod Koul Cc: Stephen Boyd , linux-arm-msm@vger.kernel.org, David Dai , linux-kernel@vger.kernel.org, Dmitry Baryshkov Subject: Re: [PATCH v4 2/2] spmi: pmic-arb: Add support for PMIC v7 Message-ID: <20220914141044.jaepzwcqyo2nt4cw@builder.lan> References: <20220914112139.3680354-1-vkoul@kernel.org> <20220914112139.3680354-3-vkoul@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220914112139.3680354-3-vkoul@kernel.org> X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 14, 2022 at 04:51:39PM +0530, Vinod Koul wrote: > From: David Dai David Collins wrote the downstream patch that this is based on, so this should be David Collins > > PMIC v7 has different offset values and seqeunces, so add support for > this new version of PMIC > > Signed-off-by: David Dai Ditto. > Signed-off-by: Vinod Koul > Tested-by: Dmitry Baryshkov # SM8450 HDK The rest looks reasonable to me. Regards, Bjorn