Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 14 Sep 2022 09:24:16 -0500
From:   Bjorn Andersson <andersson@kernel.org>
To:     Huang Yiwei <quic_hyiwei@quicinc.com>
Cc:     djakov@kernel.org, agross@kernel.org, konrad.dybcio@somainline.org,
        dmitry.baryshkov@linaro.org, leo.yan@linaro.org,
        linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] interconnect: qcom: Kconfig: Make INTERCONNECT_QCOM
 tristate
Message-ID: <20220914142416.iuqqlwxaqywnwdlv@builder.lan>
References: <20220914064122.16222-1-quic_hyiwei@quicinc.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220914064122.16222-1-quic_hyiwei@quicinc.com>
Precedence: bulk

On Wed, Sep 14, 2022 at 02:41:22PM +0800, Huang Yiwei wrote:
> Make INTERCONNECT_QCOM tristate so that icc-common.c can be
> compiled as a module.
> 
> Signed-off-by: Huang Yiwei <quic_hyiwei@quicinc.com>

Looks like this could be useful to other platforms that need of_xlate
with tags, so we should be able to push this helper into the
interconnect core and get rid of icc-common.c.

But in the meantime, I like your change.

Reviewed-by: Bjorn Andersson <andersson@kernel.org>

Regards,
Bjorn

> ---
>  drivers/interconnect/qcom/Kconfig      | 2 +-
>  drivers/interconnect/qcom/icc-common.c | 3 +++
>  2 files changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/interconnect/qcom/Kconfig b/drivers/interconnect/qcom/Kconfig
> index 25d5b4baf6f6..1a1c941635a2 100644
> --- a/drivers/interconnect/qcom/Kconfig
> +++ b/drivers/interconnect/qcom/Kconfig
> @@ -1,6 +1,6 @@
>  # SPDX-License-Identifier: GPL-2.0-only
>  config INTERCONNECT_QCOM
> -	bool "Qualcomm Network-on-Chip interconnect drivers"
> +	tristate "Qualcomm Network-on-Chip interconnect drivers"
>  	depends on ARCH_QCOM
>  	help
>  	  Support for Qualcomm's Network-on-Chip interconnect hardware.
> diff --git a/drivers/interconnect/qcom/icc-common.c b/drivers/interconnect/qcom/icc-common.c
> index 0822ce207b5d..f27f4fdc4531 100644
> --- a/drivers/interconnect/qcom/icc-common.c
> +++ b/drivers/interconnect/qcom/icc-common.c
> @@ -5,6 +5,7 @@
>  
>  #include <linux/of.h>
>  #include <linux/slab.h>
> +#include <linux/module.h>
>  
>  #include "icc-common.h"
>  
> @@ -32,3 +33,5 @@ struct icc_node_data *qcom_icc_xlate_extended(struct of_phandle_args *spec, void
>  	return ndata;
>  }
>  EXPORT_SYMBOL_GPL(qcom_icc_xlate_extended);
> +
> +MODULE_LICENSE("GPL");
> -- 
> 2.17.1
>