Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Vladimir Oltean <vladimir.oltean@nxp.com>
To:     netdev@vger.kernel.org
Cc:     Vinicius Costa Gomes <vinicius.gomes@intel.com>,
        Jamal Hadi Salim <jhs@mojatatu.com>,
        Cong Wang <xiyou.wangcong@gmail.com>,
        Jiri Pirko <jiri@resnulli.us>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Voon Weifeng <weifeng.voon@intel.com>,
        Vladimir Oltean <olteanv@gmail.com>,
        Kurt Kanzenbach <kurt@linutronix.de>,
        linux-kernel@vger.kernel.org
Subject: [PATCH net 3/3] net/sched: taprio: dereference oper and admin sched under RCU in taprio_destroy
Date:   Wed, 14 Sep 2022 17:34:39 +0300
Message-Id: <20220914143439.1544363-4-vladimir.oltean@nxp.com>
In-Reply-To: <20220914143439.1544363-1-vladimir.oltean@nxp.com>
References: <20220914143439.1544363-1-vladimir.oltean@nxp.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?XMH16pDMXJn/+uKx4u7q3IqKXMfp4ndIMYMZ9l88VhrkkidEhSlV789A4DfP?=
 =?us-ascii?Q?mB57JIVUge5fLWkNYXDoNu7OKsBs4+M1u4rWoBlsikCN8lWprgPQNMKyrENz?=
 =?us-ascii?Q?xfBrW96BQP9mV84fePcHHGZUiUdANrMFRHDBQfG0hjxa3/FD+1xBIAIjaj4X?=
 =?us-ascii?Q?31az2sEtXg+hi1i60Lp0bbVU6WCyqBcHJtTXzKpkx1KHLo1t9v2Cq2/EBcoS?=
 =?us-ascii?Q?JRP5Bzdnu0G7UKR5ANk47VV/k1FW0F+UMQkqbAOkbli66/DXPt6GxVqu+RRT?=
 =?us-ascii?Q?nyKIbA0TQU4av4lPM9Maq1CzZUWXkmPfYfdeos076RrRHMM9xH095o5S8tHe?=
 =?us-ascii?Q?U+NsmcQ8p+k7rx/QFrOrsnoz1aEMR6tLu+FuXHZwmQkDkek2g7zlfdVkaqFp?=
 =?us-ascii?Q?PpnHJS+wr8K/r+nqu2YJYVJrnAC9FSeGeUWKZvlAYne6VQOPPQBO2aJdDyNK?=
 =?us-ascii?Q?C9T8DVuMKLOeENZgI84R8jvfsMbF7Di4q4BwZw+o3Lausfr93b7UxJpAOuoh?=
 =?us-ascii?Q?Fz/olYNjxO0tSQwzripuzkhtdORWJk38pUlX2rr8ROFfwLJvlg5jB42B+7k4?=
 =?us-ascii?Q?gwiXsQVYRRe407E5+j311AIX9H8hkR/81dyjCQbak6xYQlkKb86AaqkcF4xt?=
 =?us-ascii?Q?6OsidqLzIrD6fj1ZWkK/P1sPqpa56c9a1NEmSovE2oSqsCHsjLQUc0XLKHtC?=
 =?us-ascii?Q?AY9yJPsN6fYQQhEVNu/XmFsDe8HcrnjgxV1hQhkU+88onNNeSFtmzeN1vvPG?=
 =?us-ascii?Q?JQbK8TREnTUuCdQ2i3CaIDI7n/tE7GxeLOjOUVhm+iwZX2IbI6qS5gsEPcDZ?=
 =?us-ascii?Q?Dsi+WdEq74ZVyC+C+gy6tzuhX25v1v87YJOvfOwNQ+HCmz8OVKx6YW7h9LWv?=
 =?us-ascii?Q?qhvQxJ7oYqeGvn8QzdIJUJJpfCkE0lsAC4IJp8ooDqFBys3o7mmPvW+f9CYA?=
 =?us-ascii?Q?HzSDTCGPlPIBK7YAKaFgiSmI44g6ANfQPFIgvYiZC9TLB4NxiQtSBu3qs5tC?=
 =?us-ascii?Q?zNA85RubbnzJ7zUCXu07za+yDGICYN34xL+zyg2HlfBY/JfwMuxA3t8KVbhP?=
 =?us-ascii?Q?yWxYfdWKmnlIakXg+U0TGA5cxsV2qAXt/+oCB7TQ/NIDvKIzcukuzQdpvTC0?=
 =?us-ascii?Q?HW2eQ/iqmGYIhAF1vYlpRMKc1NDJPJM7X5VuuOpINCzrNpik45WDZzLlMV9I?=
 =?us-ascii?Q?o61XF1/wGOnNuMUYB92hFWJS6jbG2YVIo/N7SpetSs0Sm8cyh3gZxwnuk+Sq?=
 =?us-ascii?Q?ADBuO3y4WjF3kqarxwrNMKMV/LqskF/4bElli883b6B4aW55GE78koRAHygo?=
 =?us-ascii?Q?eKNpeSwjhboBZ+WJbv+33UugJNzr/JQQjqFCjg8alH/YflGrkIFRSUxXPRUR?=
 =?us-ascii?Q?2PebDL+0OxTdPp2IbIIzgOcRnEERT4Q9TSr/CML95b8v9F1uE+ba+WbWyg+F?=
 =?us-ascii?Q?4itRsDPOIiaw+dTuEftgb1WBeExD2pfo+5rdNqGjByUMv2oJpETmz3pjisUI?=
 =?us-ascii?Q?vuCeL3ecmqGAIqMXkSxA/Goh6YqpVQAF11nKc3WY6FOJxYyJO1oM438/+8TB?=
 =?us-ascii?Q?13j+KqE0e55jdfaNwAXLBSr6MONJVLWFrYaKsqbd1skIbSujVjdqrDXWL2uO?=
 =?us-ascii?Q?5w=3D=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4f042252-f1e1-4755-e36e-08da965e4ebb
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5136.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Sep 2022 14:35:02.0093
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Tgv9Pz+kl2EOo1iwcSCmbwGEau2tCdKRm2sF/Ovb4aqCyG4xbx5fVIgufCZFY95CsLTdAPc8V5Uuj/apvBZXPA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR04MB6777
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Sparse complains that taprio_destroy() dereferences q->oper_sched and
q->admin_sched without rcu_dereference(), since they are marked as __rcu
in the taprio private structure.

1671:28: warning: incorrect type in argument 1 (different address spaces)
1671:28:    expected struct callback_head *head
1671:28:    got struct callback_head [noderef] __rcu *
1674:28: warning: incorrect type in argument 1 (different address spaces)
1674:28:    expected struct callback_head *head
1674:28:    got struct callback_head [noderef] __rcu *

To silence that build warning, do actually use rcu_dereference().
It would have been good if we had a writer-side lock to be able to use
rcu_dereference_protected(), but even the writer side taprio_change()
uses rcu_dereference() on these, only to close the critical section
immediately afterwards (and still keep using the variables).

Fixes: a3d43c0d56f1 ("taprio: Add support adding an admin schedule")
Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
---
 net/sched/sch_taprio.c | 16 ++++++++++++----
 1 file changed, 12 insertions(+), 4 deletions(-)

diff --git a/net/sched/sch_taprio.c b/net/sched/sch_taprio.c
index 5bffc37022e0..fbf84404408f 100644
--- a/net/sched/sch_taprio.c
+++ b/net/sched/sch_taprio.c
@@ -1644,6 +1644,7 @@ static void taprio_destroy(struct Qdisc *sch)
 {
 	struct taprio_sched *q = qdisc_priv(sch);
 	struct net_device *dev = qdisc_dev(sch);
+	struct sched_gate_list *oper, *admin;
 	unsigned int i;
 
 	spin_lock(&taprio_list_lock);
@@ -1667,11 +1668,18 @@ static void taprio_destroy(struct Qdisc *sch)
 
 	netdev_reset_tc(dev);
 
-	if (q->oper_sched)
-		call_rcu(&q->oper_sched->rcu, taprio_free_sched_cb);
+	rcu_read_lock();
+
+	oper = rcu_dereference(q->oper_sched);
+	admin = rcu_dereference(q->admin_sched);
+
+	if (oper)
+		call_rcu(&oper->rcu, taprio_free_sched_cb);
 
-	if (q->admin_sched)
-		call_rcu(&q->admin_sched->rcu, taprio_free_sched_cb);
+	if (admin)
+		call_rcu(&admin->rcu, taprio_free_sched_cb);
+
+	rcu_read_unlock();
 }
 
 static int taprio_init(struct Qdisc *sch, struct nlattr *opt,
-- 
2.34.1