Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Rolf Eike Beer <eike-kernel@sf-tec.de>
To:     Li zeming <zeming@nfschina.com>,
        James.Bottomley@hansenpartnership.com, Helge Deller <deller@gmx.de>
Cc:     linux-parisc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] parisc: Increase the usage check of kmalloc allocated object a
Date:   Wed, 14 Sep 2022 16:25:59 +0200
Message-ID: <7266457.TOmriZnqnj@eto.sf-tec.de>
In-Reply-To: <3a72852c-2f28-2916-f02c-b52cb06efd7d@gmx.de>
References: <20220914060428.4039-1-zeming@nfschina.com> <1668528.WaZXzWfjLs@eto.sf-tec.de> <3a72852c-2f28-2916-f02c-b52cb06efd7d@gmx.de>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="nextPart3490446.bMliCE8gdQ"; micalg="pgp-sha1"; protocol="application/pgp-signature"
Precedence: bulk

--nextPart3490446.bMliCE8gdQ
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"; protected-headers="v1"
From: Rolf Eike Beer <eike-kernel@sf-tec.de>
Cc: linux-parisc@vger.kernel.org, linux-kernel@vger.kernel.org
Date: Wed, 14 Sep 2022 16:25:59 +0200
Message-ID: <7266457.TOmriZnqnj@eto.sf-tec.de>
In-Reply-To: <3a72852c-2f28-2916-f02c-b52cb06efd7d@gmx.de>
MIME-Version: 1.0

Am Mittwoch, 14. September 2022, 11:04:33 CEST schrieb Helge Deller:
> On 9/14/22 08:43, Rolf Eike Beer wrote:
> > Am Mittwoch, 14. September 2022, 08:18:19 CEST schrieb Helge Deller:
> >> On 9/14/22 08:04, Li zeming wrote:

> Yes, your proposal is good.
> Anyone want to send a patch (with a small comment that kcalloc() will return
> at least the required 8-byte alignment)?

Done.

> > And these functions end up propagating an allocation error in this file
> > and it will never reach kernel/setup.c, which seems bad.
> 
> That part I don't understand.
> The return value of iosapic_alloc_irt() is checked afterwards, but you
> probably meant something else?
> 
> > But I guess the only point where this really can go wrong if the PDC
> > returns an absurdly large number of entries.

What I meant was that if iosapic_alloc_irt() fails, then iosapic_load_irt() 
will return 0, which can either be "nothing to do" or "error". iosapic_init() 
is void, so even if it could detect the failure, it can't report it upwards to 
parisc_init(). Which is the same for basically all other *_init() calls in 
there.

Eike
--nextPart3490446.bMliCE8gdQ
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part.
Content-Transfer-Encoding: 7Bit

-----BEGIN PGP SIGNATURE-----

iF0EABECAB0WIQSaYVDeqwKa3fTXNeNcpIk+abn8TgUCYyHkdwAKCRBcpIk+abn8
TiFmAKCiYz0oM2+UTnWjzFdCTegZHOedFACfSwfqyw+ldoHibEfySzEWC9sw16g=
=rIPh
-----END PGP SIGNATURE-----

--nextPart3490446.bMliCE8gdQ--