Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 14 Sep 2022 17:47:34 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Philipp Hortmann <philipp.g.hortmann@gmail.com>
Cc:     Forest Bond <forest@alittletooquiet.net>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 04/12] staging: vt6655: Cleanup and rename function
 MACbSafeSoftwareReset
Message-ID: <YyHphle3DXIlIftH@kadam>
References: <cover.1662890990.git.philipp.g.hortmann@gmail.com>
 <540a684266610f7618b3ef6000d4699d065c8e6f.1662890990.git.philipp.g.hortmann@gmail.com>
 <YyBXp9x1LnBkku2g@kadam>
 <9abac5a2-e070-501d-ceba-f227a081bd4b@gmail.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <9abac5a2-e070-501d-ceba-f227a081bd4b@gmail.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?AcFraK0AtlaHtRx8QtM1fUNJCQkQmO3BEzg5uhN+fr0jlYCdT4vXj8DpqNXw?=
 =?us-ascii?Q?FYPElrOQmNimRX/PnHs31HngBQgkSms3W5J2NxagrGV+EwHGpGAVPuSr0jCo?=
 =?us-ascii?Q?t8dg6GBGztCxdYu/v8RxPMGgt0SU9knQvT1i0r/iWmY1YJYklKXRRRmlFp4s?=
 =?us-ascii?Q?VbiLWwmCjLWpoqMhlyMDVQFpOsbvOOgihdcL9CCm1pRpykAqtgaEJCfnlP4i?=
 =?us-ascii?Q?v5eaKx2GKnEwGV4S3zzONeNjAU/auWP7NZSBJqXlFGtCiWsaWxkiFuSBOpjy?=
 =?us-ascii?Q?9lD7ngWYZr8C2Lc9Vvaj66FYKluQKMUC5N7/9LKswATX/he+Bm+IZmlPjFuP?=
 =?us-ascii?Q?1Pb5lj7tTj8sZZKo27BrR+7SlxoeQMehNUTZakuL3PA5wtlSst0+ZqJCCQ6D?=
 =?us-ascii?Q?eo/Lh6XtDW4HJMHvx44RF5OrEVfy2aqQ5CshQEiaFD6e40tjnibL035VF6TO?=
 =?us-ascii?Q?EKzaFsp80/rQSJ1B6QNGPiH5oEAcsv038xmOjwfYDLkg8qvp4gvAMWAee3aw?=
 =?us-ascii?Q?ZssbRXE7r2/Ssh6N3MlKQWDA+K1mMLglwDl8/6uxzISromhv3h8pMY+zyb+I?=
 =?us-ascii?Q?jfUwER2hzGLFwKyorX3U/Oi1zxRx77PuINqQHeChikEypEPso9MtPZtOV3hd?=
 =?us-ascii?Q?ov7KhZBOVFWz8vPufTq9a8uGuRfsYs9fP2a2CxmsA46u+aurtx0bwaM6Csht?=
 =?us-ascii?Q?XKgkeuv1vAtwQw0zYw2NJmDecY9LHWGtzn0wAmw5YDCst1/rFUJ07JVRAjq2?=
 =?us-ascii?Q?f9HC+6Jh5FAHPaS5wqWn5oK5Yk9jq7T36w5+RJlQiIdplX5ZGljjmJYJ8hv9?=
 =?us-ascii?Q?6pEQ+IjjEmiVk15334FWFPl5+MzChHNuODjT9Gll+0IVvO4MZ7CBa12doFxy?=
 =?us-ascii?Q?24C9yZNRXE6eJvPakArG1T9d62zR03kB2EXvctCUUfrWhjH8UHJUzFQM4oTW?=
 =?us-ascii?Q?Ig0KPY5nK0RCwTg7+YcpQ/8V3GiEx3VNqL3vs0tTCjuxnfhkmitYs0DL8nm3?=
 =?us-ascii?Q?Ksgx31nWL8bTI9FeI2R1Ule8E4I+QqyZ1UGvZNLZ9smQ0In8I/6lwazsOFa2?=
 =?us-ascii?Q?UCEgfeZmm/CwbyGV1DbvAmlqpDzjH/R2dAelwhc3GdbzUoLmvQkarGrsPR9H?=
 =?us-ascii?Q?iZHxrc1VeF8BbZKwXU1TUgu9UDdv5k96agJ+iloABU7ICRdqtYzMHpemq+Sr?=
 =?us-ascii?Q?E1Oh+uYtYxmuKpWHPIcREW7QphDj5zWPDCMhXAW2guCWrRX0jSlsuAnNccOE?=
 =?us-ascii?Q?l+3B4wpCi+Kog6ZlNybF7VAPTdOov1ieQxO67L1HMnjAHraRGJllfc6cDoga?=
 =?us-ascii?Q?4UWp7XXCbKHJBy9T1Kl031lGunOWD09TV8uPezpTWdya5dM0vv+WYLpenfvd?=
 =?us-ascii?Q?8SAK5erg94CakqubSlVcuNVmVQqHSG7NKPCV3gws0XZO3FPJTJHLr0OedCiv?=
 =?us-ascii?Q?Cqzn698E8dcATn45opZJeYEVYRye8qhF9jY9aFfeXEU7cH1kREWSENd5cFMK?=
 =?us-ascii?Q?oGB7NZnlokwWqqOgrBvGbHgelqp7m7FUbZTcpziZhcC3dbDleTvnbWioX1kb?=
 =?us-ascii?Q?JbEdtBNyWEgda3iTn6Kbs4XIbUEn0WyQUznSX11l?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d200f108-2c2d-40f0-b9ef-08da96601852
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Sep 2022 14:47:49.7479
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: lAKOYBNPDwju3ghxMuSBzWbsNFE6GdUY/NgQx4tuGaJApPPmTY1d0lFqsXcg2jj144EPdeKBcgnmXrayv5DgYirXoVS9tn3i2VtS5x8wYcQ=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR10MB6729
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.528,FMLib:17.11.122.1
 definitions=2022-09-14_06,2022-09-14_04,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 adultscore=0
 malwarescore=0 spamscore=0 bulkscore=0 mlxscore=0 mlxlogscore=528
 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2208220000 definitions=main-2209140071
X-Proofpoint-ORIG-GUID: StC_EnpmtRHnsSOrIxWqNPpyZLftz9d3
X-Proofpoint-GUID: StC_EnpmtRHnsSOrIxWqNPpyZLftz9d3
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Sep 13, 2022 at 08:26:04PM +0200, Philipp Hortmann wrote:
> On 9/13/22 12:12, Dan Carpenter wrote:
> > On Sun, Sep 11, 2022 at 12:46:04PM +0200, Philipp Hortmann wrote:
> > > Rename function MACbSafeSoftwareReset to vt6655_mac_save_soft_reset and
> > > abyTmpRegData to tmp_reg_data to avoid CamelCase which is not accepted by
> > > checkpatch.pl. Remove return value bRetVal as it is unused by the calling
> > > functions.
> > Please don't mix this kind of stuff into a patch like this.
> > 
> 
> In the past Greg let me know that I used to many patches for a change in the
> same lines of code and that it would be easier for him to review when less
> patches do the same.
> 

It's some kind of an art to write patches that are easy to review...

regards,
dan carpenter