Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Vladimir Oltean <vladimir.oltean@nxp.com>
To:     netdev@vger.kernel.org
Cc:     "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Xiaoliang Yang <xiaoliang.yang_1@nxp.com>,
        Rui Sousa <rui.sousa@nxp.com>,
        Claudiu Manoil <claudiu.manoil@nxp.com>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        UNGLinuxDriver@microchip.com, Andrew Lunn <andrew@lunn.ch>,
        Vivien Didelot <vivien.didelot@gmail.com>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Michael Walle <michael@walle.cc>,
        Vinicius Costa Gomes <vinicius.gomes@intel.com>,
        Maxim Kochetkov <fido_max@inbox.ru>,
        Colin Foster <colin.foster@in-advantage.com>,
        Richie Pearn <richard.pearn@nxp.com>,
        Kurt Kanzenbach <kurt@linutronix.de>,
        Vladimir Oltean <olteanv@gmail.com>,
        Jesse Brandeburg <jesse.brandeburg@intel.com>,
        Tony Nguyen <anthony.l.nguyen@intel.com>,
        Giuseppe Cavallaro <peppe.cavallaro@st.com>,
        Alexandre Torgue <alexandre.torgue@foss.st.com>,
        Jose Abreu <joabreu@synopsys.com>,
        Jamal Hadi Salim <jhs@mojatatu.com>,
        Cong Wang <xiyou.wangcong@gmail.com>,
        Jiri Pirko <jiri@resnulli.us>,
        Gerhard Engleder <gerhard@engleder-embedded.com>,
        Grygorii Strashko <grygorii.strashko@ti.com>,
        linux-kernel@vger.kernel.org
Subject: [PATCH net-next 00/13] Add tc-taprio support for queueMaxSDU
Date:   Wed, 14 Sep 2022 18:32:50 +0300
Message-Id: <20220914153303.1792444-1-vladimir.oltean@nxp.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?JKmA8desCA+jkapzpItgaXMzjqOwYyjlIfDp3Vf70oheo7t4ND7R/YJDKz57?=
 =?us-ascii?Q?zXXP1D3w+d1S4U9+BVY/ivsYj+B/QKRQyvaOcYt9+glOCWp1bdFvqi8CyzX7?=
 =?us-ascii?Q?0CD3RvZnw/nMXDXwbkrVjHX2kxGFBVaizcS300aTqT+FYQeylqnIERaiJO/q?=
 =?us-ascii?Q?XJlfSYlLBqdE9/sThJ/qbU8iSzX5rBmegSPh4IFHydJ1q7jLQugyahjNCfl+?=
 =?us-ascii?Q?pBuQxcBvpUYymSA53DWv7P9R7otexSY5FvtsdbyWFbGGMe/YRpj/8QRY1orQ?=
 =?us-ascii?Q?m4e5zr3Io2BMLIR62Dhc0bYJwjosgpTs/TMooJ3vHeduNPQEessqTxE5g0Tu?=
 =?us-ascii?Q?1FhEQ7OP+QgMUFt3XVLdxn+Z+yRvD8RpFOKC5ykGURiiqmX/OdzcajhAd7ve?=
 =?us-ascii?Q?kha+yqPswzVS0X83c2FkwAeNRhhMzj628KYx6jnsVaM8x9xlwkApRtPhbigl?=
 =?us-ascii?Q?qt3aGh+iEOLXIc86PTGE/TUtUqAZJllP48VeCPKG/bh82aOVsSVFHdQLA84B?=
 =?us-ascii?Q?2arxor0vdCtKxHY3XC8OrMTP68uMU9l7UxnbbBBPD9BmFKrJrnGLMXZvdXRq?=
 =?us-ascii?Q?mn9A/Xr3kpIUcCGU5vh+9Bbs4la6UNBiRxMaBDKydTyGMW93w8I5xEaIiT1Z?=
 =?us-ascii?Q?N10on453glnHwUiWQq+pqIfUMfI4OoIAUidGXNGf3/Sl4sGbraw0XN2DZeJ/?=
 =?us-ascii?Q?LafBIKXDZx1YI9OGzbDAGLCpW7sIGRb1qmlFjy4/QhM4co7/ZOMBM0s8q2Lw?=
 =?us-ascii?Q?rpyJWL5yKJjqKQSmixKUGjlUtxukvYNeBFoiY/ebGk4sHDt50b4TIBjTjaGv?=
 =?us-ascii?Q?kBp9zrUEQ494526dgZSHcsjPAVQp/FwdmKz2jyDWYOgQAqmnse8wtvFVPUUB?=
 =?us-ascii?Q?A8/7rJpLbd1XfWOjRjncpior8Vtv5EdwwDPPPxLH855NpT/NArFfy5CbTZzM?=
 =?us-ascii?Q?fJBK+6RBkTbH1VyrMF49Lp3HVJBFAZDSlyrrcxtpEudWDS218b0bg41zbrcA?=
 =?us-ascii?Q?25kZKJ4GEdmVc1SQKakHa4rCMwzXxIEriuQ9+W4b1U9PeAwIXZK/lHA87QaQ?=
 =?us-ascii?Q?YNOmR+8vXFmPY3+y4wutelEorBvZHEXiSgrGu5UrDvyPBScPRgIGhHsu0hOB?=
 =?us-ascii?Q?E6uV2oNfGPUPC2lk8bDofD9CX4c9iDEdRVDPxr//KGkVAnlP3ws6dLYMl6YZ?=
 =?us-ascii?Q?xv9BpGSwaHx20fG+vNMfKOX6zq40muHbNDz9Ea1RTG6nCYqVz9Rhm/s1lG96?=
 =?us-ascii?Q?QBQGafaTcFSO3Beqrd8bhMmzit9hefDSdJhYnvajwPENk4A+ltT12xnFhoAU?=
 =?us-ascii?Q?JOPtL4eoVaDIsSUaVLv0JgbRB2+SAAr974f+WlLfbJ5i4DVVtaP2dqO+y9U8?=
 =?us-ascii?Q?q97GBf421609awndpYJ0pSqxVvrgJR/IQ+WW5L0DKDwccpJME4+kjcLx5KeL?=
 =?us-ascii?Q?+A4J8aDlpW2PVdGSyS0dSojnFKX2uxnIfLer1KNkwZl2fOtLsofivwqwM4jb?=
 =?us-ascii?Q?zWv0yxeUUDRqyMLNcvio81f9ptuIoEWmh2AuHnp4nWQ83oQrfX2E6OMrO8M0?=
 =?us-ascii?Q?4H3L14QC6I0FumQ22PzJ1SIa7hCOcn7jSqPSLhsBjBXckTefEvPGiQjEBidL?=
 =?us-ascii?Q?zQ=3D=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5fc9c83f-9f0d-4e0c-e3f1-08da9666752f
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5136.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Sep 2022 15:33:22.5124
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: vYZPO9UaONfFuHci73+1/Pqs4mJbyub3ACVc26ynH6C06v82J5z/TBoSGm5tn/xKsPImGnc67CvaQjxlN/hSSA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8949
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Michael and Xiaoliang will probably be aware that the tc-taprio offload
mode supported by the Felix DSA driver has limitations surrounding its
guard bands.

The initial discussion was at:
https://lore.kernel.org/netdev/c7618025da6723418c56a54fe4683bd7@walle.cc/

with the latest status being that we now have a vsc9959_tas_guard_bands_update()
method which makes a best-guess attempt at how much useful space to
reserve for packet scheduling in a taprio interval, and how much to
reserve for guard bands.

IEEE 802.1Q actually does offer a tunable variable (queueMaxSDU) which
can determine the max MTU supported per traffic class. In turn we can
determine the size we need for the guard bands, depending on the
queueMaxSDU. This way we can make the guard band of small taprio
intervals smaller than one full MTU worth of transmission time, if we
know that said traffic class will transport only smaller packets.

Allow input of queueMaxSDU through netlink into tc-taprio, offload it to
the hardware I have access to (LS1028A), and deny non-default values to
everyone else.

First 3 patches are some cleanups I made while figuring out what exactly
gets called for taprio software mode, and what gets called for offload
mode.

Vladimir Oltean (13):
  net/sched: taprio: remove redundant FULL_OFFLOAD_IS_ENABLED check in
    taprio_enqueue
  net/sched: taprio: stop going through private ops for dequeue and peek
  net/sched: taprio: add extack messages in taprio_init
  net/sched: taprio: allow user input of per-tc max SDU
  net: dsa: felix: offload per-tc max SDU from tc-taprio
  net: enetc: cache accesses to &priv->si->hw
  net: enetc: offload per-tc max SDU from tc-taprio
  net: dsa: hellcreek: deny tc-taprio changes to per-tc max SDU
  net: dsa: sja1105: deny tc-taprio changes to per-tc max SDU
  tsnep: deny tc-taprio changes to per-tc max SDU
  igc: deny tc-taprio changes to per-tc max SDU
  net: stmmac: deny tc-taprio changes to per-tc max SDU
  net: am65-cpsw: deny tc-taprio changes to per-tc max SDU

 drivers/net/dsa/hirschmann/hellcreek.c        |   5 +
 drivers/net/dsa/ocelot/felix_vsc9959.c        |  20 +-
 drivers/net/dsa/sja1105/sja1105_tas.c         |   6 +-
 drivers/net/ethernet/engleder/tsnep_tc.c      |   6 +-
 drivers/net/ethernet/freescale/enetc/enetc.c  |  28 ++-
 drivers/net/ethernet/freescale/enetc/enetc.h  |  12 +-
 .../net/ethernet/freescale/enetc/enetc_pf.c   |  25 ++-
 .../net/ethernet/freescale/enetc/enetc_qos.c  |  70 +++----
 drivers/net/ethernet/intel/igc/igc_main.c     |   6 +-
 .../net/ethernet/stmicro/stmmac/stmmac_tc.c   |   6 +-
 drivers/net/ethernet/ti/am65-cpsw-qos.c       |   6 +-
 include/net/pkt_sched.h                       |   1 +
 include/uapi/linux/pkt_sched.h                |  11 +
 net/sched/sch_taprio.c                        | 194 +++++++++++++-----
 14 files changed, 283 insertions(+), 113 deletions(-)

-- 
2.34.1