Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Vladimir Oltean <vladimir.oltean@nxp.com>
To:     netdev@vger.kernel.org
Cc:     "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Xiaoliang Yang <xiaoliang.yang_1@nxp.com>,
        Rui Sousa <rui.sousa@nxp.com>,
        Claudiu Manoil <claudiu.manoil@nxp.com>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        UNGLinuxDriver@microchip.com, Andrew Lunn <andrew@lunn.ch>,
        Vivien Didelot <vivien.didelot@gmail.com>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Michael Walle <michael@walle.cc>,
        Vinicius Costa Gomes <vinicius.gomes@intel.com>,
        Maxim Kochetkov <fido_max@inbox.ru>,
        Colin Foster <colin.foster@in-advantage.com>,
        Richie Pearn <richard.pearn@nxp.com>,
        Kurt Kanzenbach <kurt@linutronix.de>,
        Vladimir Oltean <olteanv@gmail.com>,
        Jesse Brandeburg <jesse.brandeburg@intel.com>,
        Tony Nguyen <anthony.l.nguyen@intel.com>,
        Giuseppe Cavallaro <peppe.cavallaro@st.com>,
        Alexandre Torgue <alexandre.torgue@foss.st.com>,
        Jose Abreu <joabreu@synopsys.com>,
        Jamal Hadi Salim <jhs@mojatatu.com>,
        Cong Wang <xiyou.wangcong@gmail.com>,
        Jiri Pirko <jiri@resnulli.us>,
        Gerhard Engleder <gerhard@engleder-embedded.com>,
        Grygorii Strashko <grygorii.strashko@ti.com>,
        linux-kernel@vger.kernel.org
Subject: [PATCH net-next 03/13] net/sched: taprio: add extack messages in taprio_init
Date:   Wed, 14 Sep 2022 18:32:53 +0300
Message-Id: <20220914153303.1792444-4-vladimir.oltean@nxp.com>
In-Reply-To: <20220914153303.1792444-1-vladimir.oltean@nxp.com>
References: <20220914153303.1792444-1-vladimir.oltean@nxp.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Y8qkXJfbKSboRzLnJzRyDwuSVAv1FHsijUY7/YPvWMFr8d7ypLDI81BpWuns?=
 =?us-ascii?Q?qtXGX53Rt3axFTRNLPHK1lkQRi7rWHqa5iOW98GcWAEMZgld1jsxBMyCDGjU?=
 =?us-ascii?Q?GgHHr/3eo5urQ0nCHSZaBCnHvFnCoOB8nektuh//TRviyFkzkPuLHFhbTve/?=
 =?us-ascii?Q?SVj2VTDb//sQ/5ppyEHJoOYhoLBJkjJQCREZOh2IcorM82Ck9iD+3RZS9Cj+?=
 =?us-ascii?Q?VJmHGk5t9B8Br0u0SjnBu9EIuNVVaOl5iuqL+XmhPB01VqH5byY7h+iOsUiK?=
 =?us-ascii?Q?mtZytCi94O8fis+j2YCT7c8Vjtx2x5a8QPDcWkeB3U6h67Bit5ZBH0PO467P?=
 =?us-ascii?Q?SBXCLbMKpeJCK36uL2g5p8jnEK8uuLqjwXzJbOnEe1lKocvKXjp8A15PmJYN?=
 =?us-ascii?Q?UsaEa289hfqnXT0eZ3o49VDaJkgml/9DXXQPiq+IUknqlu0k1m2MPSHcm8Iq?=
 =?us-ascii?Q?4+pLRJEySfVDvF6BOXPc1wXMU4Q8do0kcwt+agU0XQD7ImW+qLvhRhhfN15d?=
 =?us-ascii?Q?sZTGXRilHnDrWbc/v8bBPq7+gYkNQCw9+lAtQxbH6URt88CGWqOrhXBlsVC9?=
 =?us-ascii?Q?au21/CpWUc8SXIG58fwDelTi1QKre8xKSTSbmoQ/wLZEZnSJ+B58ZV0dklWA?=
 =?us-ascii?Q?4F4v0+r8TJ+Hcz1zzzwkuEogvU026Mxklv3p4oZ8TIfdT42ptLgWI1dn0kQR?=
 =?us-ascii?Q?R3IvI9aJgLgRZZovzx1SlaEA8OOOJZRYypM9oggg+uBZoId8krPUP8PFt0Y3?=
 =?us-ascii?Q?1fNqjlhS0xtSuHbxFm01KuDmhXt/9iqBvQk515k2mi7xy5nR4sT+gC2jEjhx?=
 =?us-ascii?Q?BXsgP6Td8l9Katx9iJ+Q8MyUTw7H4NEwr7qSmFKEu5tm/Tr1xj6DxXRJhpgj?=
 =?us-ascii?Q?LbI8eIWmwuyYzzCvH8FHfJK7reeErvGH0yDqfGGBI/DjuBVACw7oDl1itaJ9?=
 =?us-ascii?Q?MKgJeO9Kpt/F9akXM5A4phLGlEclakQlMZxwWi+eIgOgW/HveNvB3sLexMUK?=
 =?us-ascii?Q?51gGHOUKNfuNYe6iW5P7gIsmKBivXs9rbAR0+roDXJh8j8+6Xl1jF2sFpMON?=
 =?us-ascii?Q?qzONf+n18lGy0FA46ZPuMYO38CK5F4lBHQLN/3t2wZpztxDt1obJ6jKlzt3D?=
 =?us-ascii?Q?LsJMpitiKvEZ7KF64w/y412gyqQV0EsR238KEXjuX8WDgPlt+Q7MqGyI7kCV?=
 =?us-ascii?Q?95OryMNqmp6xqtz23FblunRsbLhIq006Fyvu802YTdafngsQfWeZIS1v78/y?=
 =?us-ascii?Q?rKsrfgAvAij6Qb5vM5zjqJD2qjohu7fDV3xgxmmh7rEOymS8pCLwU95Q0D41?=
 =?us-ascii?Q?rH8IPyCLQkkMwIJEe/vPduPk5u5G+5v4WcMD1Y0cSXoCrMYB2JJslRtjrqFY?=
 =?us-ascii?Q?2Y01sGX8Meveu77EENiBnCDkbNl7p+ugF3kj8mHPvCSdrUalj3R+YbRY+S5X?=
 =?us-ascii?Q?75Xzp6rq+KG4Susk/ngMYORo4OV5JyGCZOx4EUItiwr3d+oct7slF9Fha/+e?=
 =?us-ascii?Q?b63xKnbhpKXmiRcY2QwsinVu2tOzdQuuruy4NpfSBr+eblQ713JnZvfNBVdW?=
 =?us-ascii?Q?4mcVt4xO1tu18gXnQ/R4KwAqeYF6TJb9bW1Z0ELh5MY6s7xtgSPP/NREKDcl?=
 =?us-ascii?Q?uQ=3D=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: bb23f6bd-6a71-4109-f0ac-08da96667a66
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5136.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Sep 2022 15:33:31.3556
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 2+0Mwn1bgcX2xNjLR72SH1Vz6pqxG/XAp++ptMK5lLmQ+0yOXHbfdoTLdzfRkfASL6fXsViH7iO8h8vCASzaeA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8949
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Stop contributing to the proverbial user unfriendliness of tc, and tell
the user what is wrong wherever possible.

Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
---
 net/sched/sch_taprio.c | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/net/sched/sch_taprio.c b/net/sched/sch_taprio.c
index 226aa6efb365..2a4b8f59f444 100644
--- a/net/sched/sch_taprio.c
+++ b/net/sched/sch_taprio.c
@@ -1675,11 +1675,15 @@ static int taprio_init(struct Qdisc *sch, struct nlattr *opt,
 	list_add(&q->taprio_list, &taprio_list);
 	spin_unlock(&taprio_list_lock);
 
-	if (sch->parent != TC_H_ROOT)
+	if (sch->parent != TC_H_ROOT) {
+		NL_SET_ERR_MSG_MOD(extack, "Can only be attached as root qdisc");
 		return -EOPNOTSUPP;
+	}
 
-	if (!netif_is_multiqueue(dev))
+	if (!netif_is_multiqueue(dev)) {
+		NL_SET_ERR_MSG_MOD(extack, "Multi-queue device is required");
 		return -EOPNOTSUPP;
+	}
 
 	/* pre-allocate qdisc, attachment can't fail */
 	q->qdiscs = kcalloc(dev->num_tx_queues,
-- 
2.34.1