Received: by 2002:a05:6358:489b:b0:bb:da1:e618 with SMTP id x27csp8078136rwn; Wed, 14 Sep 2022 08:37:54 -0700 (PDT) X-Google-Smtp-Source: AA6agR6/RPTFEOYBjaH98DbPBQseCsyEMEZeAqyry9plzZD0pbccfclOD9zmF8wfWeH+iitmUKmn X-Received: by 2002:a05:6402:1e8d:b0:441:58db:b6a2 with SMTP id f13-20020a0564021e8d00b0044158dbb6a2mr30290906edf.277.1663169874379; Wed, 14 Sep 2022 08:37:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1663169874; cv=none; d=google.com; s=arc-20160816; b=AUYrqoya1O9lvIlWp1PuRZaET6JHJwKLVw7IwiiuBx00W7+wRDNDlAjO6TwgsrBXv+ Swygen10tfd57vayCMJqB3EiYE5v7UvL8mdajdLQVY1pwWyl4kzLmEK/hJc6dIuKG0+I UEVEYDIHk6CnIqAZ0ShY0zZKDWU2H0EuCoHyN68fDI9aTAThFcxqXmZssz6NtNlpleJu Ap0g4OQkrzApCe5zKEjGqTtv6iVHm+iNOxMpud0LsdrYVVMR3X9no4J1VQqFYoIdUh8G iQX0YzY+vgnuHctaBJ/4sO0gjsIUn+UU5pkqyfLWkHX8BzCzcOkqFZMfmXbJAiV2NDBU 0IRA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=8sVnRYf4lRZtHclJFM/PYgijezwVHsVwJUa/M1F9Nfw=; b=NIwBDEKiIzMSZCgTtbo7LH2q3nHT62OuKkQaB3VU004KWVvo1V5XvecHoLoj98aAra JFQgnzTPMOaFnyo+KJ8n2utHDpalGJ6woGOJOHIR+XH4zzo3m0Xepq+vpa7o3y/KAzyc ZPya1PnCI/woGV8/PK1MMhr93jKKwP7x1nxJHhnwKEzbZLfraE7bIIwXUKOfEgVqGAZ/ +n/RS6Jz1sPLbsgKWvrDhfbzBqV5fHurZNFRd+3VmdgeswzPkS0vHz1aHNiHu/aUASL7 3/hA1OZkI21OIX4nccHiOO1Zta9Gp4AgNrS7wweMmLrYBjui7HVqFlZmeRZFCc05vJy9 SGJg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=aU+pRvep; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id g12-20020a056402090c00b00450f5384073si14289541edz.527.2022.09.14.08.37.28; Wed, 14 Sep 2022 08:37:54 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=aU+pRvep; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229559AbiINPVh (ORCPT + 99 others); Wed, 14 Sep 2022 11:21:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57348 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229844AbiINPVf (ORCPT ); Wed, 14 Sep 2022 11:21:35 -0400 Received: from mail-io1-xd35.google.com (mail-io1-xd35.google.com [IPv6:2607:f8b0:4864:20::d35]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6F4F22FFF0 for ; Wed, 14 Sep 2022 08:21:33 -0700 (PDT) Received: by mail-io1-xd35.google.com with SMTP id g8so9901920iob.0 for ; Wed, 14 Sep 2022 08:21:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=8sVnRYf4lRZtHclJFM/PYgijezwVHsVwJUa/M1F9Nfw=; b=aU+pRvep+sXGVRr01+jPV7M1KGeUuIOdGm/7Imgv2e35rdbyXzmARUq1pX7NbUK31d P7JnZtuwOHE1Y3V+NSrCkrjcfy/IVgYVBkLzYROVFEJ2rN4QRKzlug+IhDRBgsnblfD/ z6gvdEo890XqggiMeBDVIPT5KAcHLF/iLDo5o= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=8sVnRYf4lRZtHclJFM/PYgijezwVHsVwJUa/M1F9Nfw=; b=Ytpbrwzh+E6KIouTNtNJU4YLNK82rP7hb4heJxafJALXHYIHkVevnmIXYwam6F5FPK 0IjHFtUx1MpOd2f+IG2QGpw3PTvucKQSf4YU8NuWcsavOJkzR7L4xK1VQvZvUr9inEAf XUqvxlmfW/IGv0VbqvS+2KIbV5FrEWtrKti2eedl8HVnpkW4v6iq7tpuj5jmSVzRHDsx 36lq0y9cZfwYmX76NSwPCpZ8JBN/Aguow31SJtcpYxmdZqBElPCkWMCXhCdMxxmIbxDI 6/rXz6+XHTKG/DMuLInGk8wIv3Vr4A7CGsz5tsULSsLLGF2WN6vPSR8vpUH6Zlx4ofAW 2VWA== X-Gm-Message-State: ACgBeo3dd1J4honb28LljhGHNSpCR8fjizMemrGDAOlQpsRGn2V5Ib7L 7gsYddDHVkHqmj2jPcSp59L/PTSnTDq6Dw== X-Received: by 2002:a02:90d2:0:b0:349:f259:a097 with SMTP id c18-20020a0290d2000000b00349f259a097mr19009697jag.141.1663168892500; Wed, 14 Sep 2022 08:21:32 -0700 (PDT) Received: from mail-io1-f54.google.com (mail-io1-f54.google.com. [209.85.166.54]) by smtp.gmail.com with ESMTPSA id cx22-20020a056638491600b00356744215f6sm7264816jab.47.2022.09.14.08.21.31 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 14 Sep 2022 08:21:32 -0700 (PDT) Received: by mail-io1-f54.google.com with SMTP id i7so3560967ioa.5 for ; Wed, 14 Sep 2022 08:21:31 -0700 (PDT) X-Received: by 2002:a02:9509:0:b0:349:b6cb:9745 with SMTP id y9-20020a029509000000b00349b6cb9745mr18869971jah.281.1663168880396; Wed, 14 Sep 2022 08:21:20 -0700 (PDT) MIME-Version: 1.0 References: <20220912221317.2775651-1-rrangel@chromium.org> <20220912160931.v2.5.I4ff95ba7e884a486d7814ee888bf864be2ebdef4@changeid> In-Reply-To: From: Raul Rangel Date: Wed, 14 Sep 2022 09:21:08 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 05/13] gpiolib: acpi: Add wake_capable parameter to acpi_dev_gpio_irq_get_by To: Mika Westerberg Cc: Linux ACPI , linux-input , Andy Shevchenko , "jingle.wu" , "Limonciello, Mario" , Tim Van Patten , Linus Walleij , Hans de Goede , "Rafael J. Wysocki" , Asmaa Mnebhi , Bartosz Golaszewski , "David S. Miller" , David Thompson , Eric Dumazet , Jakub Kicinski , Len Brown , Lu Wei , Paolo Abeni , "open list:GPIO SUBSYSTEM" , linux-kernel , netdev@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 13, 2022 at 11:55 PM Mika Westerberg wrote: > > Hi, > > On Mon, Sep 12, 2022 at 04:13:09PM -0600, Raul E Rangel wrote: > > +int acpi_dev_gpio_irq_get_by(struct acpi_device *adev, const char *name, > > + int index, int *wake_capable) > > Here too bool. I've incorporated both of your suggestions. I instead added `acpi_dev_gpio_irq_wake_get_by` as the basic function and left `acpi_dev_gpio_irq_get_by` the same. THis way I don't have to update any of the callers.