Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Vladimir Oltean <vladimir.oltean@nxp.com>
To:     netdev@vger.kernel.org
Cc:     "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Xiaoliang Yang <xiaoliang.yang_1@nxp.com>,
        Rui Sousa <rui.sousa@nxp.com>,
        Claudiu Manoil <claudiu.manoil@nxp.com>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        UNGLinuxDriver@microchip.com, Andrew Lunn <andrew@lunn.ch>,
        Vivien Didelot <vivien.didelot@gmail.com>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Michael Walle <michael@walle.cc>,
        Vinicius Costa Gomes <vinicius.gomes@intel.com>,
        Maxim Kochetkov <fido_max@inbox.ru>,
        Colin Foster <colin.foster@in-advantage.com>,
        Richie Pearn <richard.pearn@nxp.com>,
        Kurt Kanzenbach <kurt@linutronix.de>,
        Vladimir Oltean <olteanv@gmail.com>,
        Jesse Brandeburg <jesse.brandeburg@intel.com>,
        Tony Nguyen <anthony.l.nguyen@intel.com>,
        Giuseppe Cavallaro <peppe.cavallaro@st.com>,
        Alexandre Torgue <alexandre.torgue@foss.st.com>,
        Jose Abreu <joabreu@synopsys.com>,
        Jamal Hadi Salim <jhs@mojatatu.com>,
        Cong Wang <xiyou.wangcong@gmail.com>,
        Jiri Pirko <jiri@resnulli.us>,
        Gerhard Engleder <gerhard@engleder-embedded.com>,
        Grygorii Strashko <grygorii.strashko@ti.com>,
        linux-kernel@vger.kernel.org
Subject: [PATCH net-next 12/13] net: stmmac: deny tc-taprio changes to per-tc max SDU
Date:   Wed, 14 Sep 2022 18:33:02 +0300
Message-Id: <20220914153303.1792444-13-vladimir.oltean@nxp.com>
In-Reply-To: <20220914153303.1792444-1-vladimir.oltean@nxp.com>
References: <20220914153303.1792444-1-vladimir.oltean@nxp.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?uk9ImEY15PtVAz4Qu6STwoTzl24YX9OIYnFtTu00kHP1Cl0Y0EqEri/A2XkL?=
 =?us-ascii?Q?P2mrCfRBkO1Ur6Mau+ZFYlGXjil2ZxwRwyD+u5VzpU7koRYMOatNG0a5eFxe?=
 =?us-ascii?Q?kJ4bIUqkRyxFQBS2Xoj+zidspxYZ2v84+N5CMQqqbh27mKx7cMczxgRSkoE7?=
 =?us-ascii?Q?eEvX6rDcvjc7wL+qFaoYm0n69zVKxUcQpz2GJPhRwuilJDUKbVbGZxwo05WD?=
 =?us-ascii?Q?UtjdcCwAlrGqG+OpRZpVRZLVBu+ig/tSfs8dY5LYn8hi+do3HAywQiCMH+28?=
 =?us-ascii?Q?VQUrwEa3A/LXHDUDP0SVWyEsXU8f6Cqogy4khqBnEkW1Q4mG/pmIAZQ5Y9mn?=
 =?us-ascii?Q?r6qrdvhu3BlV9cEvG5mpmb/ofJoTrwE2St3rr4wipl3UoMgkUY5h/8sv+1qq?=
 =?us-ascii?Q?BPT8t8rFg0XM/E3TRNtCVDNarqH8ni0A+segmtdxw0a9x3ocXLDsreZDfOGI?=
 =?us-ascii?Q?6l3mHzKnfy7zNF2Xdu1d+t6URZC7hFfhoBNnTCxFh3yxbrmKaewPMTfuxKT+?=
 =?us-ascii?Q?3KtkVVp2BXCAEjqVxWiLxpo7pebtDiA/YXWJ9WGtbeXBXcGbyWKzlvtMsTBI?=
 =?us-ascii?Q?ZQqGFTOycIAYeKV3awEz4CZ6A2eUaGcklvMP3H+qe7MXzCn37Zpz2DsTLZpF?=
 =?us-ascii?Q?0eQlinYsmL1z0YI3pML425DxWwapHsCgUxs/VWUoSPCdogsusjajQvisjBdh?=
 =?us-ascii?Q?WB4hCWY8HCrZv3cqR50HbF4vcKTpPB1l+2ZY+lFqECNBhPVvv/o0t0CTlHah?=
 =?us-ascii?Q?3ZTzHIaM9NuUadPc+8CMgGFqqPKb8bAPWqOh0V5nBY432eJy2LGRCHZvwCdi?=
 =?us-ascii?Q?Jo53W9ivTc0DbcPmGS0zAVcNYNl+7l4WWQVCqE9B1j24S22g6S4Ykz2zKBKi?=
 =?us-ascii?Q?HD1A9y3X1hVdLoBkumjRQqgdfoeNeSTPZq88uAsxRkFeYcYjwjhNatgXdxcT?=
 =?us-ascii?Q?vZqJczPfbX2xmjvp2dUmvczFAghrdsrmEU4447QHucFnECbavvFbOlC4HR6q?=
 =?us-ascii?Q?QZaCD+pU1+GjS2vCYN2JKw84NAET5rn9yGmoPtmregLmr+ZZxQ0G01wgqyAg?=
 =?us-ascii?Q?lIpKf+LlyQcPmsxDfpLu8eZzQrOnvdrq7e8o1wNv0SoTsxGxJ+v7V0YuHOi1?=
 =?us-ascii?Q?JiV4WFBvf3QJ2HGnbMn3Yb7ywdGIGCFw/MLvE1VDF7Q4Xx6JpE/kNac1f11B?=
 =?us-ascii?Q?2v8fUFjDOXLmDb/YJg71qTuGN0GsFl1BLtOpuZwHZcm4SEyjvXUi+AldpM9Q?=
 =?us-ascii?Q?vGs4dMEAxJp2tS2jf/SVlZk3+/TnZ3NN0PDemp1RSkM3ZajW3kpCMBofrBUa?=
 =?us-ascii?Q?mQZ0jLH3DCbSRYzJiQK7oSwEykxYCDcVS99842IyJXyLzqJTjjAsh/GqanAp?=
 =?us-ascii?Q?NqbWwhhjdyJd2naO1/ELdl1t1PSDak2kvYS/0ezky4HzxXxTPgRJ9YSuoKfa?=
 =?us-ascii?Q?mcjNcZXqATte32dL6IaOH4c1z3P123iYWioAr/wXK0A4YIzXlMrg6KkIBgEY?=
 =?us-ascii?Q?MleblXsCou5MCjKKhhlgpWXiwscDDsi8EalNGUsRBz1udGypS2+gvMR7Ro3f?=
 =?us-ascii?Q?uqGmjcnyEvk1pC40yAtuZu8QJJlzE4PDProtakqOcgbJCIF+n2IpkpiCyKlE?=
 =?us-ascii?Q?uw=3D=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5bef213d-3788-416b-d572-08da96668a6d
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5136.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Sep 2022 15:33:58.1505
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Ou1p6AlWHkHQoMbN0Da4fgun5AOUtEI1MljTMrYcrlUe9HPSOaf5jn7nfNjwB/6deJ/3m0brmIwyAKxJazmjiQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR04MB7908
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Since the driver does not act upon the max_sdu argument, deny any other
values except the default all-zeroes, which means that all traffic
classes should use the same MTU as the port itself.

Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
---
 drivers/net/ethernet/stmicro/stmmac/stmmac_tc.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_tc.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_tc.c
index 773e415cc2de..8e9c7d54fb4c 100644
--- a/drivers/net/ethernet/stmicro/stmmac/stmmac_tc.c
+++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_tc.c
@@ -922,13 +922,17 @@ static int tc_setup_taprio(struct stmmac_priv *priv,
 	struct plat_stmmacenet_data *plat = priv->plat;
 	struct timespec64 time, current_time, qopt_time;
 	ktime_t current_time_ns;
+	int i, tc, ret = 0;
 	bool fpe = false;
-	int i, ret = 0;
 	u64 ctr;
 
 	if (!priv->dma_cap.estsel)
 		return -EOPNOTSUPP;
 
+	for (tc = 0; tc < TC_MAX_QUEUE; tc++)
+		if (qopt->max_sdu[tc])
+			return -EOPNOTSUPP;
+
 	switch (wid) {
 	case 0x1:
 		wid = 16;
-- 
2.34.1