Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Vladimir Oltean <vladimir.oltean@nxp.com>
To:     netdev@vger.kernel.org
Cc:     "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Xiaoliang Yang <xiaoliang.yang_1@nxp.com>,
        Rui Sousa <rui.sousa@nxp.com>,
        Claudiu Manoil <claudiu.manoil@nxp.com>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        UNGLinuxDriver@microchip.com, Andrew Lunn <andrew@lunn.ch>,
        Vivien Didelot <vivien.didelot@gmail.com>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Michael Walle <michael@walle.cc>,
        Vinicius Costa Gomes <vinicius.gomes@intel.com>,
        Maxim Kochetkov <fido_max@inbox.ru>,
        Colin Foster <colin.foster@in-advantage.com>,
        Richie Pearn <richard.pearn@nxp.com>,
        Kurt Kanzenbach <kurt@linutronix.de>,
        Vladimir Oltean <olteanv@gmail.com>,
        Jesse Brandeburg <jesse.brandeburg@intel.com>,
        Tony Nguyen <anthony.l.nguyen@intel.com>,
        Giuseppe Cavallaro <peppe.cavallaro@st.com>,
        Alexandre Torgue <alexandre.torgue@foss.st.com>,
        Jose Abreu <joabreu@synopsys.com>,
        Jamal Hadi Salim <jhs@mojatatu.com>,
        Cong Wang <xiyou.wangcong@gmail.com>,
        Jiri Pirko <jiri@resnulli.us>,
        Gerhard Engleder <gerhard@engleder-embedded.com>,
        Grygorii Strashko <grygorii.strashko@ti.com>,
        linux-kernel@vger.kernel.org
Subject: [PATCH net-next 13/13] net: am65-cpsw: deny tc-taprio changes to per-tc max SDU
Date:   Wed, 14 Sep 2022 18:33:03 +0300
Message-Id: <20220914153303.1792444-14-vladimir.oltean@nxp.com>
In-Reply-To: <20220914153303.1792444-1-vladimir.oltean@nxp.com>
References: <20220914153303.1792444-1-vladimir.oltean@nxp.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Y1+d+TKKdlE3bHdT8ZGloONkFdoeQA9/MwyMt1LcwMdUe7Yw07qUJ+Q3BoXs?=
 =?us-ascii?Q?LLrNroU6EBBLYsfeBH4nzWqWiPNMWpyP0PLXtEf/9zc5X7mxFpJWKMygpQZf?=
 =?us-ascii?Q?DmVWpqwW8ZValknjbLmx1og/uquAswmFE2xn30bDIGNu+Y219fPLChPy8ox0?=
 =?us-ascii?Q?bHqb61b7oj8P41GK3n7VsQ8WsUxNrQOAlzMFWBjgnvAhaWEt3HSVLkBgdYYc?=
 =?us-ascii?Q?kNarBoxqViWj42wYeQutGc5kDUIFmGdwigrLJPhX0cLpiOExb+rpk0cVig9G?=
 =?us-ascii?Q?jXs3bq1a28kmheldUSrStVVukTkQSvFmJP7d7bU1YgBQOUR+xV9tfB5nMQpy?=
 =?us-ascii?Q?4ffr2JR1a99tghtsbHAEkPf3640sd0gi2i3LEIee3HlRZmjX5NZtdAGff3fi?=
 =?us-ascii?Q?rEzZv7nlMjmSi3ipaZ+769aFi4dXTRDx0FlFwatwG+qrPxLvFpOXRKJG9VGD?=
 =?us-ascii?Q?DHfViCqv5woQInJlYgmYeq39nBp/MnGwuJ1ozd5mr5DQi0wUSXMFn/uJ8IJb?=
 =?us-ascii?Q?cfRo+fQTXIi9aRPLI7q7bL7IXWqVCpsBXe2PukLJWhGTlZMsTyvHQ58bc+cc?=
 =?us-ascii?Q?TX/MDR04UokZv2vZxiOaRDBdSiCzGoLI9cc0QMH9mNBD8pv5+FTxxDR3mA4S?=
 =?us-ascii?Q?9bYSgCGlFwBI5T1AkNak/5BBnaJqDiAnthSwskCVClzsThEZA8c4WijVsenl?=
 =?us-ascii?Q?yl9nfx2rNpEqDzGgKreBCvk6NmKFGr+gOMii6z7xvtDWqU3edt49hkEzr1Eh?=
 =?us-ascii?Q?yNtWvj+9h882k1GItbzL/cJB1uDUXGfKXprknN+sPC8mdcZ+jefFn1xv41Ts?=
 =?us-ascii?Q?Of/mAkYWIevsQ0/AqCkQqBgsDP/GnQcqQX/q5LQelMnbsU+3N5X22r2uDAfD?=
 =?us-ascii?Q?dg29SKxYYHJvcTrCPJcgMtZLN3y2umeLxP6e9sWYRIXOerqnLJZPsQUUOVV0?=
 =?us-ascii?Q?CrGUYieAhumssaF2FZCejqUSPcwkTCiwKJJro44eUAH+EsVMlobUtbEzHAvx?=
 =?us-ascii?Q?BgIOW/x4nNKg7FruPGyDzAe8MYzydzV91OkycgXb3pKpU9RQzvIgyyW/fR6A?=
 =?us-ascii?Q?5N/rsAVvYu3nxsySQVlUYq2DH6nZ/ZTWRd/OOcDF/TIYnMTDgNo5rpn3JlK8?=
 =?us-ascii?Q?ZOkCrUn5yMC8hrHT5xql+1xWW6QbceJJZ/RHWMZ7mvA4i39tRuiS7Hpqcmzr?=
 =?us-ascii?Q?UrcS9kDOINelzqwT7UFQ/yUBYwuLmmY49MR3L9MzxEF54slqnGLXivs0nSOX?=
 =?us-ascii?Q?7nY6dtE1NyIQOz5HthoCMHMuBh42cE/7Q85dPWcEwY+qAWO+xHhs8VuoIX2X?=
 =?us-ascii?Q?IMe8vA3ejy8V7ngFWCvs2qhJoTNsybUXWe6bFKVuluoJiyGhy98oyb7qX9po?=
 =?us-ascii?Q?Ld5den36QFjC9al6HwDm7wmRhBIB4c3VflBNzPQgcI+SXK8oIoZQKIPaq4I7?=
 =?us-ascii?Q?HO1/MnNfWZ6LCP4EOm5uqeTf+hiG7hP8SM4soiNtan/Paf2XNdXb4yw9ApD/?=
 =?us-ascii?Q?fNPOUlIH0bpHZ6hl2H+Dc946tCMnoRxzraRbc8GBaa2X7eyHt5/8+TuttN3A?=
 =?us-ascii?Q?KPPykOfgwKYIBfKqXFmpyGvs1PboYUYEKw64BISkwhTH0Yuk3F8Cx5QhCLEW?=
 =?us-ascii?Q?HA=3D=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 47a7de7d-0457-4acb-b991-08da96668c1f
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5136.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Sep 2022 15:34:00.9941
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: QwAcLvbwVaUYXSmmV822IBtMuEEFPF31Mtdj5ggB1wY3YyZRWBF9F7GuMfk90lMOmvCkpPZ2OHDBZtfFdKGodA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR04MB7908
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Since the driver does not act upon the max_sdu argument, deny any other
values except the default all-zeroes, which means that all traffic
classes should use the same MTU as the port itself.

Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
---
 drivers/net/ethernet/ti/am65-cpsw-qos.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/ti/am65-cpsw-qos.c b/drivers/net/ethernet/ti/am65-cpsw-qos.c
index e162771893af..bd3b425083aa 100644
--- a/drivers/net/ethernet/ti/am65-cpsw-qos.c
+++ b/drivers/net/ethernet/ti/am65-cpsw-qos.c
@@ -503,7 +503,11 @@ static int am65_cpsw_set_taprio(struct net_device *ndev, void *type_data)
 	struct am65_cpsw_port *port = am65_ndev_to_port(ndev);
 	struct tc_taprio_qopt_offload *taprio = type_data;
 	struct am65_cpsw_est *est_new;
-	int ret = 0;
+	int tc, ret = 0;
+
+	for (tc = 0; tc < TC_MAX_QUEUE; tc++)
+		if (taprio->max_sdu[tc])
+			return -EOPNOTSUPP;
 
 	if (taprio->cycle_time_extension) {
 		dev_err(&ndev->dev, "Failed to set cycle time extension");
-- 
2.34.1