Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 14 Sep 2022 18:45:05 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Dorota Czaplejewicz <dorota.czaplejewicz@puri.sm>
Cc:     Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
        Steve Longerbeam <slongerbeam@gmail.com>,
        Philipp Zabel <p.zabel@pengutronix.de>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Shawn Guo <shawnguo@kernel.org>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        Pengutronix Kernel Team <kernel@pengutronix.de>,
        Fabio Estevam <festevam@gmail.com>,
        NXP Linux Team <linux-imx@nxp.com>,
        linux-media@vger.kernel.org, linux-staging@lists.linux.dev,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        kernel@puri.sm, phone-devel@vger.kernel.org
Subject: Re: [PATCHv2 1/1] media: imx: Round line size to 4 bytes
Message-ID: <YyH3ASYQsgD7i2Yt@kadam>
References: <20220914173236.3040f3a1.dorota.czaplejewicz@puri.sm>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220914173236.3040f3a1.dorota.czaplejewicz@puri.sm>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?6ZGu5UfeG+tJAJPn3NFQlZ+rZhtPWojCpkNXSDklUu3R4tE9Z3gZk22wiWym?=
 =?us-ascii?Q?8drzQ7p0fTW9rpap2dsqqG2BTtc+Osti9S8pv0R9VF6ftM2ykEQcYjNOnUSY?=
 =?us-ascii?Q?B2VY+QARopzC0tmOMOAjDblTVAszeeU34bN0L6QMgX+KZVQAxH0V8RJc9nor?=
 =?us-ascii?Q?C8ekgd1fZozfDIe1uN7anQ8y53MOdbwiOT/S5oWoyQE/5n5C6ru50RUKNFBH?=
 =?us-ascii?Q?GCJZrm+yNH8klvGyjXuNYMNAYBbQHptEX/zCgk8mk7dyvXf1CKYvS9JyHGVF?=
 =?us-ascii?Q?PEUMzx/NFzWs16tAtRq99nkWgS5U5qXHFcw0r+XLZsS3sLDgB6cdLUxTFy2+?=
 =?us-ascii?Q?KIB9MMf3y4bnAfPe4OFpQOjb/rofDShgGOJGVqKwZZ4EdAM0seXgoN6EyvEq?=
 =?us-ascii?Q?qNSOVHpSLDWkLOw5Xm3/BM1h3qIfjSKoUxsEBsWE/k1jKWUENEhGy95A2g/P?=
 =?us-ascii?Q?Z7YT5J5fRT9sCY6whWxgK6xRHzSd+GSV+9/46162R1asufnoluM8Tt/P+uaZ?=
 =?us-ascii?Q?LfVUbz/SJeJxxGH7W/hPi1PEiaegJ1evDDR1fbtWGBwtBJ13SuH8r0F+gd6J?=
 =?us-ascii?Q?azUXoZsPdmB9r9Ms9iTMvgwER84H8ZgJw4aakJAkqMFjQGA0ehlLznZfHp5n?=
 =?us-ascii?Q?DEONQm++TMnlOH5Um1cJqe2QEWys9v7m/9S3M3qO5ugMh1cIXWDVs9BKeWz/?=
 =?us-ascii?Q?bi/twHu+kncNBmPxDkNPH1Qd281h0VtMvj5GD53NNgKXFq7thPGhA3mRQaa4?=
 =?us-ascii?Q?aJ2wdh3pRgLYGVFUbmz/qW18pQwdgG5CODa/bXW3BxYw8rYQnzuuUYtmB6zt?=
 =?us-ascii?Q?Nh3j5dMsEbze6yqgOQQF3Lo4oHZ8arQh7PsKeFuPkteRKqemDmQYjMcUmqHP?=
 =?us-ascii?Q?iUkASWA3AaqBQKGcC/8Nl6cekxftd9x0cB1812adptI4C4TwOlYkXE0Ur3Wj?=
 =?us-ascii?Q?txRqipab2yosekR1PK2jZe2zWdO9UFju9jvwBWn+5Tuz1ZT9Va613ovA5LcB?=
 =?us-ascii?Q?NtDTTWJIXAvMU+YCwkASOmaMCjRbFIXSi5FYMAQ3n4se4uPp72i36soN5sKy?=
 =?us-ascii?Q?pilaOUQt50sxuNtOB3yVQ8sfGMSqpapwADB49s2TlNpQKadKqoC1yCkLIgPD?=
 =?us-ascii?Q?yjz38C5UGFR2oKi3F8u7z/Y0y6WS5Kpz5DEFcqyLe9Zde+T5Kpn+VdPdDfD8?=
 =?us-ascii?Q?GNYGIp1Xr0g6e5wGrvKSqmWHQbEge+3M1ZBDSPcN7zdFm07KWK6Ryau8z7Aa?=
 =?us-ascii?Q?svXUCMx9aIAZR6CzL5xN3ukN2yNNaakvtIrUnDc3JE8Y6b2Lsa+AA6XYdGo9?=
 =?us-ascii?Q?JNQPjJ+WQnawYf5QlUNZKPncK93EdCo/JU2XgGrTvh7s5ApfQ517XjnPEik7?=
 =?us-ascii?Q?EvAPop5e1FE43zAVKgqGvEokdtOzeDb9TOgAL7wJl39G5VQ9n4/LcS4aOQXX?=
 =?us-ascii?Q?wAuRKSWMVfFxbSx6Lf9rVn0s9xo7+8VH0MQHqfekR+Yq8F8VlRbi/wWQwQw7?=
 =?us-ascii?Q?hhrF9+38aMiX5+QiO41fiaKOnwXu+nA7PTgY2eUvwIePG6/4sx6pzH5uspsc?=
 =?us-ascii?Q?rlxq3AH0OfHsmJ5V5f7B7JxLpvCfHdZF8+DJUqDr89Fx+7uSTQKA9MZCqUzC?=
 =?us-ascii?Q?zA=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4ce61486-4331-44dd-d9e4-08da96682137
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Sep 2022 15:45:20.7701
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 4+r4qVO5axUeE87xObpZ5Vc4M9fVu2+UShU85IS5+XF4g1T2iBHoKKv/bpQGHSQTXVYimouT1/QzbukYqQY4mdQp935/cwhJiFi+UiFl9xc=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR10MB6524
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.528,FMLib:17.11.122.1
 definitions=2022-09-14_06,2022-09-14_04,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 adultscore=0
 malwarescore=0 spamscore=0 bulkscore=0 mlxscore=0 mlxlogscore=995
 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2208220000 definitions=main-2209140076
X-Proofpoint-ORIG-GUID: UpPDD3VKu8azdMRKmpO6cjtxIRZEWka0
X-Proofpoint-GUID: UpPDD3VKu8azdMRKmpO6cjtxIRZEWka0
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Sep 14, 2022 at 05:32:36PM +0200, Dorota Czaplejewicz wrote:
> Section 13.7.6.13 "CSI Image Parameter Register" of the
> i.MX 8M Quad Applications Processors Reference Manual
> states that the line size should be divisible by 8 bytes.
> However, the hardware also accepts sizes divisible by 4 bytes,
> which are needed to fully utilize the S5K3L6XX sensors.
> 
> This patch accepts line sizes divisible 4-bytes in non-planar mode.
> 
> ---

So do we need a Fixes tag?  Was this ever working in kernel?

Definitely need a Signed-off-by line, though. ;)

regards,
dan carpenter