Received: by 2002:a05:6358:489b:b0:bb:da1:e618 with SMTP id x27csp8113808rwn; Wed, 14 Sep 2022 09:07:45 -0700 (PDT) X-Google-Smtp-Source: AA6agR6zpihs6Cep7LYeX+/zIwoInZl26MIZmoz1JrrDs7+cfJpzYQycy1oZxjXM/8juDFEdMzjj X-Received: by 2002:a50:ed0f:0:b0:44e:89d7:1ae1 with SMTP id j15-20020a50ed0f000000b0044e89d71ae1mr31972545eds.174.1663171665232; Wed, 14 Sep 2022 09:07:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1663171665; cv=none; d=google.com; s=arc-20160816; b=lOoQq1h6oDvayQHwVZwZcwf4TLW/rS8hECu/Uvhkf4p/yew2UUKV4j/mQaeOq/yxdP jZaig5o5A2nd6Jt1TejgUmJo0iA3VN7zZE/EkHw6HRLHLEOuh5tyo8hTP9uG0StaWtrP RcjrV0fYg3Cv8ddbJA3+rgmlwYMfUBmJMWZTtSct+13VBpBgp2nRWC09BaUfCZtv/CBT EkXYfryOVr7y6LDIvLzY2PEtAzmGf8X4Jip3UzVDXNZHKSgQj/ZFXbPpOldxbQPjqFN1 m7/YlrDJ67jJA8wKsGd+tDL+lmmYNUIbSH8Jv61pJaoXtX/BH8f/a+ICDg6oYnIbnpAW n1+Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=VEgFxnLOYI3T5ObrGlqO5YffaSdFPuBvr+1++nbH3q0=; b=OUSs8hTQLb91UOknMMxRGn0abIBl+3c1j3rdEXJSPjYo2NslExT5odfd6Alr/o06WO 7BdYiLJu/RAmNmBLj/AiqCaiRKtcqWMFfMz0JqRrLpQij2lKUKUuIdluq2i+5kpjXtXa dXlvnqIwLhSThUfwzxwF/el19tzImXPg6LUGJgMeyC6Gf5LFM8pQQxifSkApDhbSwiek /xSiMGGdgr4+NGEZcLIGaPd5npl5sD9pMHOPKh129y4BwQChwDY81gvpjG/gutYwk3cn l3nqDMlC+tJa9htqH+AsCSTDNyRah1zHRV4BsH8jFfHnFO9sXtfTkCMWHT0zbI40u+27 K0/w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=XVRxF0UR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id dn21-20020a17090794d500b00777a40d515dsi13414078ejc.456.2022.09.14.09.07.07; Wed, 14 Sep 2022 09:07:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=XVRxF0UR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230310AbiINPrx (ORCPT + 99 others); Wed, 14 Sep 2022 11:47:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42208 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230291AbiINPrr (ORCPT ); Wed, 14 Sep 2022 11:47:47 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F0C3080B74; Wed, 14 Sep 2022 08:47:40 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 59C32B8191E; Wed, 14 Sep 2022 15:47:39 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 23291C433C1; Wed, 14 Sep 2022 15:47:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1663170458; bh=Vuv4mlyU327q6kYHLPn8YLNWd6wwgr4aGa8caHJflFI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=XVRxF0URqbKj6vE8FlXeL2bi6W+wzGtUCzISCA+WL2Qa8Kw2CH4UDlBAFgBehHzZY g3ypqU0/w0EaX5HxgxM1LCdOZCjcFxPA6vDqGMxQgbRYpyzHripv/JVXlZ6+zE95bI Cy9i/H3ZlADJ54kOeOD9gffE/aTEae4ajkGQ8fKys9x1bZjAkqIaEfbWpao6YWldk9 IjifSHvRauyZz4IISlSUNs09xe14tA8D7cBSIboTYRnRsYvShXS51Xcm8oGD8l/Fo9 uvHP0UwP0RSKkyN3H5wi1ZyIq+S2dgkEMdViOtATnGFxm3F31+qggbXjJIC9M1k5DL NNmW2ej3jkhfQ== From: Lorenzo Pieralisi To: Dmitry Torokhov , Marc Zyngier , Alyssa Rosenzweig Cc: Lorenzo Pieralisi , Hector Martin , Rob Herring , =?UTF-8?q?Krzysztof=20Wilczy=C5=84ski?= , Bjorn Helgaas , linux-pci@vger.kernel.org, Sven Peter , linux-kernel@vger.kernel.org Subject: Re: [PATCH] PCI: apple: do not leak reset GPIO on unbind/unload/error Date: Wed, 14 Sep 2022 17:47:31 +0200 Message-Id: <166317043943.2639676.3222680734266270030.b4-ty@kernel.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 5 Sep 2022 19:15:23 -0700, Dmitry Torokhov wrote: > The driver allocates reset GPIO in apple_pcie_setup_port() but neither > releases the resource, nor uses devm API to have it released > automatically. > > Let's fix this by switching to devm API. While at it let's use generic > devm_fwnode_gpiod_get() instead of OF-specific gpiod_get_from_of_node() > - this will allow us top stop exporting the latter down the road. > > [...] Applied to pci/apple, thanks! [1/1] PCI: apple: do not leak reset GPIO on unbind/unload/error https://git.kernel.org/lpieralisi/pci/c/a6b9ede1f3df Thanks, Lorenzo