Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Vladimir Oltean <vladimir.oltean@nxp.com>
To:     netdev@vger.kernel.org
Cc:     "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Xiaoliang Yang <xiaoliang.yang_1@nxp.com>,
        Rui Sousa <rui.sousa@nxp.com>,
        Claudiu Manoil <claudiu.manoil@nxp.com>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        UNGLinuxDriver@microchip.com, Andrew Lunn <andrew@lunn.ch>,
        Vivien Didelot <vivien.didelot@gmail.com>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Michael Walle <michael@walle.cc>,
        Vinicius Costa Gomes <vinicius.gomes@intel.com>,
        Maxim Kochetkov <fido_max@inbox.ru>,
        Colin Foster <colin.foster@in-advantage.com>,
        Richie Pearn <richard.pearn@nxp.com>,
        Kurt Kanzenbach <kurt@linutronix.de>,
        Vladimir Oltean <olteanv@gmail.com>,
        Jesse Brandeburg <jesse.brandeburg@intel.com>,
        Tony Nguyen <anthony.l.nguyen@intel.com>,
        Giuseppe Cavallaro <peppe.cavallaro@st.com>,
        Alexandre Torgue <alexandre.torgue@foss.st.com>,
        Jose Abreu <joabreu@synopsys.com>,
        Jamal Hadi Salim <jhs@mojatatu.com>,
        Cong Wang <xiyou.wangcong@gmail.com>,
        Jiri Pirko <jiri@resnulli.us>,
        Gerhard Engleder <gerhard@engleder-embedded.com>,
        Grygorii Strashko <grygorii.strashko@ti.com>,
        linux-kernel@vger.kernel.org
Subject: [PATCH net-next 11/13] igc: deny tc-taprio changes to per-tc max SDU
Date:   Wed, 14 Sep 2022 18:33:01 +0300
Message-Id: <20220914153303.1792444-12-vladimir.oltean@nxp.com>
In-Reply-To: <20220914153303.1792444-1-vladimir.oltean@nxp.com>
References: <20220914153303.1792444-1-vladimir.oltean@nxp.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?IzL+N7nuJCKItJPOgiEExW3S4mIbsSBUHElUUalow96AVo5fNdD1F3nbYQ3V?=
 =?us-ascii?Q?smwVfmUVZ+tBTnyhHGmmen5/XV5Kdel6tBjRAF3VRSV1KJOtTp6u7GohrOTh?=
 =?us-ascii?Q?4iXPLTXxuAN/PD473PhYnHgktr3Zi9RwEfYERl+55DYpxXd2YHOQaSCmkoaH?=
 =?us-ascii?Q?IAW3YUQEOmY3FeozxBmgMg5CJQXskehkStPUrddhyJVsUP9x7L+8qluIm1uB?=
 =?us-ascii?Q?Mf880nYqIxQAB6XXBeHh0VHPOxj4besUbsIXvG7n5dyV6NnvtD3v34lh5Css?=
 =?us-ascii?Q?uGBE31pzNZYqOyavItCvd8Vjz6CyCjIDa0OZ+ZOc/arVlaYbzca0gLfDunqx?=
 =?us-ascii?Q?h1p4za55zNCP4Se2deDlMn3RVVkLK+diRj3bC1bLLwZ7gO7TwnOtpwMQewdv?=
 =?us-ascii?Q?C6yDSG5khHun+gpc19ep1Ow44sUT0bgrD4Ztx4UvcwFUURgVD7IVd/Bbs4yL?=
 =?us-ascii?Q?cQdRxQZFxO7kP3vobMuf8AhUZNQ6jg6upY3XsRRdOoLhe07MmnGMDB/gPGCX?=
 =?us-ascii?Q?054XkqS0+Iu1L6cPzIos+pqS+hCfcytDSuiIfDbINOtlxE1boYtUgaejoA7K?=
 =?us-ascii?Q?QaEzMdpDYeVjY5JBGsdXPbrBvrUbrxdh2ofgsa0c8cTSgwZf86F+SlBBmwyS?=
 =?us-ascii?Q?MlV4yGIF4R6YMpb2piuzIpaOu9nQ+HUlDd4zMGXY2X8eSVsSwY5e9ZyW6e7d?=
 =?us-ascii?Q?3gzpDdRn+ssB/68lf0gK0tBXcZtM/W3f4kHMD6/I4ulT38rfU0igC2BwBpMj?=
 =?us-ascii?Q?ZIP29JDV0lRObubudCResvHDURAa7t49LkZNos02aVjXcqc8kHgkfz59FRSC?=
 =?us-ascii?Q?IWhva4dKcQNxJxCr6PK9MZiXvIY70pqlWYiu8TgTMw4xRUg5WlU5cFYUfMjL?=
 =?us-ascii?Q?WXHg4hJ4iacBmd1+QjSjZ34J0dyyVjlxe8TYD+JuTzKXxaK3HyaMdPwgsaU3?=
 =?us-ascii?Q?BdYObmsP74dD6T+/B45Gia9UH9LyafVhsyFyUFy339tCP3AiSrZD+Vf99ibM?=
 =?us-ascii?Q?vwmZr/AoLhZCdTojXvsx8lTyu/Osvse/30RKapayCuLW6iBoApbX6rWXCbdA?=
 =?us-ascii?Q?wuRQ3USFCu6VkFhz9UcF6pe44WnYHc+wColnXMYcbpC0knxGikDMx842wcfV?=
 =?us-ascii?Q?rNlOnhqcVp5dVo1syg7IHrPUnUm2KE8hQb+5l/sqSnnk8k07ekQAzFH4YOvF?=
 =?us-ascii?Q?1j1hyrUK6IPEdRGJMKupCfWCVSVmu85777RLdiCADZl0T1zDlsEq+vTDWEtP?=
 =?us-ascii?Q?rYc0IAP0rxCWfPaEjr6XcUI2YrSUJHeCFP4IpHcNmQYHmBSnPIhFvIwl9t9A?=
 =?us-ascii?Q?SlELmOEzbmygTJp1jzsNh4hSIDKgH2bzQiAvFGeSHlAaQILVZZEOa2iKLloW?=
 =?us-ascii?Q?uCM7hESyDHcPuPaZuXbub6tz9TYASg8d93CQFTbyvCiBkklM3b94Gk5lI5G+?=
 =?us-ascii?Q?BpCeEw2wXwREC1tkASSQ9lhpnq+GxO2uW7dz/MNg0vvURqObtucoUvheNAnw?=
 =?us-ascii?Q?g+8Nn27xF6jRchR4ba56mNHkZ/xKeNBn3aL/IwDByu57rMjzsZsAqrRaV5Oy?=
 =?us-ascii?Q?1/N2ERivv4WXW+4qE5y7St1Kw+v94/D7spPzbanzlCck+kXN9undIIT3k3AM?=
 =?us-ascii?Q?2w=3D=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: fcbbced7-a60d-4ff1-1a4c-08da966688a4
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5136.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Sep 2022 15:33:55.2914
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: QXpyx1vLNn9ysZC2SftH8LEZd4QNFqfQQvE8Lk6pmOq8S6EGILS0OzJWkfIehDRyxJJl+W83Umu79BlN+pw2AQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR04MB7908
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Since the driver does not act upon the max_sdu argument, deny any other
values except the default all-zeroes, which means that all traffic
classes should use the same MTU as the port itself.

Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
---
 drivers/net/ethernet/intel/igc/igc_main.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/intel/igc/igc_main.c b/drivers/net/ethernet/intel/igc/igc_main.c
index bf6c461e1a2a..47fae443066c 100644
--- a/drivers/net/ethernet/intel/igc/igc_main.c
+++ b/drivers/net/ethernet/intel/igc/igc_main.c
@@ -5965,11 +5965,15 @@ static int igc_tsn_enable_qbv_scheduling(struct igc_adapter *adapter,
 					 struct tc_taprio_qopt_offload *qopt)
 {
 	struct igc_hw *hw = &adapter->hw;
-	int err;
+	int tc, err;
 
 	if (hw->mac.type != igc_i225)
 		return -EOPNOTSUPP;
 
+	for (tc = 0; tc < TC_MAX_QUEUE; tc++)
+		if (qopt->max_sdu[tc])
+			return -EOPNOTSUPP;
+
 	err = igc_save_qbv_schedule(adapter, qopt);
 	if (err)
 		return err;
-- 
2.34.1