Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Himanshu Madhani <himanshu.madhani@oracle.com>
To:     Rafael Mendonca <rafaelmendsr@gmail.com>
CC:     Nilesh Javali <njavali@marvell.com>,
        GR-QLogic-Storage-Upstream <GR-QLogic-Storage-Upstream@marvell.com>,
        "James E.J. Bottomley" <jejb@linux.ibm.com>,
        Martin Petersen <martin.petersen@oracle.com>,
        Michael Christie <michael.christie@oracle.com>,
        linux-scsi <linux-scsi@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] scsi: qla2xxx: Fix memory leak in
 __qlt_24xx_handle_abts()
Thread-Topic: [PATCH] scsi: qla2xxx: Fix memory leak in
 __qlt_24xx_handle_abts()
Thread-Index: AQHYx+SjMrMXH8lkYE2CBQQw7hx0P63fHNqA
Date:   Wed, 14 Sep 2022 16:23:28 +0000
Message-ID: <4E653C94-D457-4881-BAAC-35EA5DC178D8@oracle.com>
References: <20220914024924.695604-1-rafaelmendsr@gmail.com>
In-Reply-To: <20220914024924.695604-1-rafaelmendsr@gmail.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?bKnSiCMkb5POIByp1bZ3p/ODFbRQ8TJM4iPkHYfEuDS/vGDE5f0/rJLHhu5H?=
 =?us-ascii?Q?cB1wp9RTxZsvgJWpUwXC9nE1AgVc7As0SiII5PlnDpmJ3IGoIJ9zhbX3tnB4?=
 =?us-ascii?Q?UCwXBX8fw2cjVndq60pd8m5Y5R3b+e/bnRE7A9kJSYZSDWId3I+MiEmHSIIR?=
 =?us-ascii?Q?VkcOlTTzhh4+kX687qGHeAWFMccF3vFKyaA8FZzMblikiF2YZiRonKGSmNUE?=
 =?us-ascii?Q?1PCZMkF74Do0ugxndEcPaCLosxQkkbnj9HGJCfvlYJi3Nem5zIHaIhgaJaP7?=
 =?us-ascii?Q?c75xTPa775FJcpSjx8pKlwiJMTDGitWQumTLIceKhSM0eULfTzqoBRpiyRQJ?=
 =?us-ascii?Q?Np6CT0Ct4inQWtAlBfqFJUt2G2GefNeZVg4LZVkNUDE6opEVE4+5xoM/9IHj?=
 =?us-ascii?Q?00oBJLiKW3F2EXO+OP0YzpZ3W2GXRObcKw29ja6rek1VbMLE35XiyCP68Oea?=
 =?us-ascii?Q?Yhvu7uaAO8C4UifLdcfRq6uU+SyaAVxacEWlIjdxs6hPriiqGps1HHevu3CC?=
 =?us-ascii?Q?t4hRHc/J4i31vQkqSCCXEXud5kVNPj4qaOG4fSlTnafAYO4+P5uMGbW402tG?=
 =?us-ascii?Q?JfcYcYq1eY8au8/kjuelXjrBBAF7P9aWGsmfHauhFe7y00GHZbGDerqWhpiK?=
 =?us-ascii?Q?O8gPytvmbA81U9IhnTBItzS//OjeWYrxHBnuRP+flRzvWcszSTQ8Szd7lUZx?=
 =?us-ascii?Q?w6sIt7ArW1pQebk2MgCAXrQPOT9FcskN2Y48IVrhIQmCgZ2N68bDO7N7vijl?=
 =?us-ascii?Q?aoZZz1ZAf6dCjmNqfOkiUP6hPL8HjfvHMBXHvxJzgxVhoRN3oKpACWbKZiB2?=
 =?us-ascii?Q?zAxOolLlrfkd++J6FJ7JmZ+LlDiDQSdBHOsbGG2Nh19y/YtTLWOZwzssNou1?=
 =?us-ascii?Q?BYs1HoOUP4dFy4M3ZHE7X+xMStTQgUknxMDASZRzG2W+mqVFPfW0fcJrwh2y?=
 =?us-ascii?Q?tsT5V8qBwEcToXxReu6Ee4MzBZNvjGSXfUTwgeR8HH3EXox3CjHkS/t+0Xu8?=
 =?us-ascii?Q?kJtctCfHBQRNFNR/95o+o8uSxLjDMMluTQ0RhlWA+YE661SyYegJwbm3yhd4?=
 =?us-ascii?Q?Pbai+85CzJqYmOnF3V+xLEK4Jl9G0BXKBUq8fHOx3Km9IlKRNGiPArkXH4dr?=
 =?us-ascii?Q?m2d4u7wWqG23q7aMMV/HiqT3WvOQW/M8VP+eNpN6/yVFjRhvjzL66GZ5E0dI?=
 =?us-ascii?Q?XVcjNPzuuSOxTJWlZIFMBoNWHmOis/jxOR09cd7USawQzEXawGxxL8+B84H2?=
 =?us-ascii?Q?OOWbXYE32iFa3xJUhPfryKtDMQQwEC2xr0V5eMi/4EDSbu8Z+ewtejF6GihU?=
 =?us-ascii?Q?RUzwOkwSwW8S9Qj6hjBOQVjjmmCjViJDkfix70Lx2RIkAwr1BoT1jcrd0PTM?=
 =?us-ascii?Q?cDI41FvhZ4d8fSvW+prRLHawFQ6xAVbCshGoHH2MEChUYRM0xEe0xdpQwVE/?=
 =?us-ascii?Q?gPIYuMB3Qc9hgRuwHRI2bVsrl7Eisjpe7QTPKI2WA6N7tGLZNGj8uH5U5O61?=
 =?us-ascii?Q?VMjUvzXxydTZKCnOYZOr9oWrAnLJk9KQgQC7CVkRdS3BXT/rSLzqOfczKyiv?=
 =?us-ascii?Q?0JC7oJjPizBBUeaoSUWNdeONZCHL5yaOjwMVvbM4Ml2U4BjKPCMWjhyYTQDP?=
 =?us-ascii?Q?NA=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <795FFEE752D8EE49A73B84EB6B461E87@namprd10.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SN6PR10MB2943.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 44d4ef0c-5954-4a49-0d5a-08da966d74e9
X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Sep 2022 16:23:28.3222
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: OKCiJTLMuWWAFOBa4nMTgqV59sy+NeFhZ6Pt4tqeAXQI4r7mI37xySCuWbKtV+0zjDU0SLyBVCdMpcdIGhFIzTrlOFmM5TVM0ioyALCv0/8=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR10MB5070
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.528,FMLib:17.11.122.1
 definitions=2022-09-14_07,2022-09-14_04,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 mlxlogscore=999
 bulkscore=0 phishscore=0 spamscore=0 suspectscore=0 adultscore=0
 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2208220000 definitions=main-2209140079
X-Proofpoint-ORIG-GUID: HqdwpqGxYMGK8qVMOou4inhvm3i0ILSJ
X-Proofpoint-GUID: HqdwpqGxYMGK8qVMOou4inhvm3i0ILSJ
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> On Sep 13, 2022, at 7:49 PM, Rafael Mendonca <rafaelmendsr@gmail.com> wro=
te:
>=20
> Commit 8f394da36a36 ("scsi: qla2xxx: Drop TARGET_SCF_LOOKUP_LUN_FROM_TAG"=
)
> made the __qlt_24xx_handle_abts() function return early if
> tcm_qla2xxx_find_cmd_by_tag() doesn't find a command, but it missed to
> clean up the allocated memory for the management command in such a case.
>=20
> Fixes: 8f394da36a36 ("scsi: qla2xxx: Drop TARGET_SCF_LOOKUP_LUN_FROM_TAG"=
)
> Signed-off-by: Rafael Mendonca <rafaelmendsr@gmail.com>
> ---
> drivers/scsi/qla2xxx/qla_target.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>=20
> diff --git a/drivers/scsi/qla2xxx/qla_target.c b/drivers/scsi/qla2xxx/qla=
_target.c
> index 62666df1a59e..4acff4e84b90 100644
> --- a/drivers/scsi/qla2xxx/qla_target.c
> +++ b/drivers/scsi/qla2xxx/qla_target.c
> @@ -2151,8 +2151,10 @@ static int __qlt_24xx_handle_abts(struct scsi_qla_=
host *vha,
>=20
> 	abort_cmd =3D ha->tgt.tgt_ops->find_cmd_by_tag(sess,
> 				le32_to_cpu(abts->exchange_addr_to_abort));
> -	if (!abort_cmd)
> +	if (!abort_cmd) {
> +		mempool_free(mcmd, qla_tgt_mgmt_cmd_mempool);
> 		return -EIO;
> +	}
> 	mcmd->unpacked_lun =3D abort_cmd->se_cmd.orig_fe_lun;
>=20
> 	if (abort_cmd->qpair) {
> --=20
> 2.34.1
>=20
Looks Good.

Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>

--=20
Himanshu Madhani	Oracle Linux Engineering