Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 14 Sep 2022 22:22:39 +0530
From:   Vinod Koul <vkoul@kernel.org>
To:     Bjorn Andersson <andersson@kernel.org>
Cc:     Stephen Boyd <sboyd@kernel.org>, linux-arm-msm@vger.kernel.org,
        David Dai <daidavid1@codeaurora.org>,
        linux-kernel@vger.kernel.org,
        Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Subject: Re: [PATCH v4 2/2] spmi: pmic-arb: Add support for PMIC v7
Message-ID: <YyIG19E/EMNQzqcr@matsya>
References: <20220914112139.3680354-1-vkoul@kernel.org>
 <20220914112139.3680354-3-vkoul@kernel.org>
 <20220914141044.jaepzwcqyo2nt4cw@builder.lan>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220914141044.jaepzwcqyo2nt4cw@builder.lan>
Precedence: bulk

On 14-09-22, 09:10, Bjorn Andersson wrote:
> On Wed, Sep 14, 2022 at 04:51:39PM +0530, Vinod Koul wrote:
> > From: David Dai <daidavid1@codeaurora.org>
> 
> David Collins wrote the downstream patch that this is based on, so this
> should be David Collins <collinsd@codeaurora.org>

Thanks updated and posted v5

> 
> > 
> > PMIC v7 has different offset values and seqeunces, so add support for
> > this new version of PMIC
> > 
> > Signed-off-by: David Dai <daidavid1@codeaurora.org>
> 
> Ditto.
> 
> > Signed-off-by: Vinod Koul <vkoul@kernel.org>
> > Tested-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> # SM8450 HDK
> 
> The rest looks reasonable to me.
> 
> Regards,
> Bjorn

-- 
~Vinod