Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 14 Sep 2022 10:08:00 -0700
From:   Mike Kravetz <mike.kravetz@oracle.com>
To:     Doug Berger <opendmb@gmail.com>
Cc:     Matthew Wilcox <willy@infradead.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Jonathan Corbet <corbet@lwn.net>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Frank Rowand <frowand.list@gmail.com>,
        Muchun Song <songmuchun@bytedance.com>,
        Mike Rapoport <rppt@kernel.org>,
        Christoph Hellwig <hch@lst.de>,
        Marek Szyprowski <m.szyprowski@samsung.com>,
        Robin Murphy <robin.murphy@arm.com>,
        Borislav Petkov <bp@suse.de>,
        "Paul E. McKenney" <paulmck@kernel.org>,
        Neeraj Upadhyay <quic_neeraju@quicinc.com>,
        Randy Dunlap <rdunlap@infradead.org>,
        Damien Le Moal <damien.lemoal@opensource.wdc.com>,
        Florian Fainelli <f.fainelli@gmail.com>,
        David Hildenbrand <david@redhat.com>, Zi Yan <ziy@nvidia.com>,
        Oscar Salvador <osalvador@suse.de>,
        Hari Bathini <hbathini@linux.ibm.com>,
        Kees Cook <keescook@chromium.org>,
        - <devicetree-spec@vger.kernel.org>,
        KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
        Mel Gorman <mgorman@suse.de>, linux-doc@vger.kernel.org,
        linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
        linux-mm@kvack.org, iommu@lists.linux.dev
Subject: Re: [PATCH 03/21] mm/hugetlb: correct demote page offset logic
Message-ID: <YyIKcNRP+Q0Vt3CT@monkey>
References: <20220913195508.3511038-1-opendmb@gmail.com>
 <20220913195508.3511038-4-opendmb@gmail.com>
 <YyETeBdbldnoRZ+x@casper.infradead.org>
 <33ff9543-3396-7609-3865-7eed20b853f5@gmail.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <33ff9543-3396-7609-3865-7eed20b853f5@gmail.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?knZ2ZqrGiEj3eBWtMRs4PDCbE3aJzxPGFzWt0nLgIYeIFaMZbVAKufrn4v2r?=
 =?us-ascii?Q?NISZDavDnrXNzP9obS/z9jkCz0gmWnd/7qaukeUmhBkMNROVQXpldgTEebHd?=
 =?us-ascii?Q?5bJ1LoLXRgx/CGAQMfuatykwsUnQgV/MusM4eBpz8rxLM+P8d1n9yGQM0Jmw?=
 =?us-ascii?Q?5LiXWVyL5S8EML+fxRvDNPJ2w7iy3hLW2i8fMC+RRGJKDUPJ8ipqBAX+sc6g?=
 =?us-ascii?Q?oUyc/MUBkk7pvQ3WOgOTdTQB9qKWbnD0zQv6RNdIAsQmxFOoRPAJAF7zJ5M6?=
 =?us-ascii?Q?RLarze7AFdcc0O6dDZ+DLgjpBvW3VEg86l41KuSmS7QMpYqOWNB9tvW4UGj4?=
 =?us-ascii?Q?ZQn107NQnZDNLVDPQQjyBXobjhPnLJRGF1dt67VCsjFjRfwdNlwmMozZCzCs?=
 =?us-ascii?Q?uwjO55a3I7WMaSYs8kFRy4q9Sk1L9jC+O93I73sm6taqhivOZsan7FEx9834?=
 =?us-ascii?Q?2UlM0bNiXKG/WprNNnEiGGUdwa8N79vcmu4hu9CulyzfzeBv57xtHM/2SMwS?=
 =?us-ascii?Q?f6XpqfI7zd8Zy+iep+uJUaOaNa5sZIUpOEdPapl311AOfC+DWjYo4uuw9Dnj?=
 =?us-ascii?Q?U9WKo8rc5pW2F5HIdvPabkEcKPNPAsAVVjV0yaABD0zZWeOvGW8AgQ/HdAW5?=
 =?us-ascii?Q?hSchvx4kb0uA77q0f2k0Z8XP/u2XviBXl8aYv2oHtoEbEAl8wEay57kYI8uc?=
 =?us-ascii?Q?JGLu1GRh+rwxdrInmfyF6Iwipq9+vUfbquzM2Pb3zVIGF+FsIEFM1YmE64dd?=
 =?us-ascii?Q?i9HM8AG1dHfBvE0hBHaJkeLO0zYenxVZo/83lmHKFHDlV0fqQ3Zu94sW/9ID?=
 =?us-ascii?Q?dGPjC+/0aW6NwR+Cb6j8SoEGGlC/xNL75RlIvU0GQQBaZmMh0br2CnX+X3Qd?=
 =?us-ascii?Q?uVQ/2fR33Q2q0+AxUXRD3fZ/gycv+AX0KQpazTQFiDhrXPzriaj7vir6ULS4?=
 =?us-ascii?Q?zA+cruh/3FkmiHip7zU+k8W3e1IGdlfNXzSOv+mDQdfg2I9dJHJ5Gfa0w7yL?=
 =?us-ascii?Q?nfC8ERfZKlXE77Gma62sSZvuCidg9zznU9Q3Z1bcTPdm9K29IvZXdHqYNxbt?=
 =?us-ascii?Q?VrO2KMkt4TpXdjawRZmPh18JKb3Ssd/4SUkd2P8YuHHPEqcTNqdn/UUYZKMu?=
 =?us-ascii?Q?7k+/A+MDmkF7Fd5YhWG3yh8QXAlddE1kNv86ZR6A9sH8/SDsII6tHeSA2DAv?=
 =?us-ascii?Q?Q+9W/+bImRqaM+gY1gGtlI90EK5nsg3kQpHYjM5dZXU15plm5GA6HUqvDxoN?=
 =?us-ascii?Q?hn5wH+0wv6cx20svAl0YZ5P2TOu0xF0lAV2fDIjOPx59AhMySg+KmKEf2qFQ?=
 =?us-ascii?Q?xWgKx2CBUpyq7zIAS37Gs9CJ7Q++VQSnWCAfABiXF2D6fCPHMD4P4Ba/EcGJ?=
 =?us-ascii?Q?0S/pJzWaRd+854Ql9nFmpoXz12B/O88tFL80MvbwiOeqvQnW/SEaQGMvZkbq?=
 =?us-ascii?Q?GDaxkJOsz7c9Whm9HaSL2bFWXidVh4M1BoC4bPqy1iyP63kKVEDBOaky+Za8?=
 =?us-ascii?Q?uA1V5RvU3qdwu9W+97NYXHzrllKi6bhLvsFvtrIOddDE/8i8Yw+UJeQgsjfE?=
 =?us-ascii?Q?jXMVDIywmaEFBRHbzXFp7D/MwhX6UR5dtJwmhMdTuhcvyXl2Nlfhv9WncZZD?=
 =?us-ascii?Q?ww=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3ed0a77b-28fc-4240-9658-08da9673af4e
X-MS-Exchange-CrossTenant-AuthSource: BY5PR10MB4196.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Sep 2022 17:08:03.5414
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: /NQG/Di8089dYWYcI8veLTApzl3kGrSD6E3Bfl4MCaBvJVbVaBshwTZOv9N2FQwGp78XuKU0FPHFIfuK2xTfVA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR10MB4149
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.528,FMLib:17.11.122.1
 definitions=2022-09-14_08,2022-09-14_04,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 suspectscore=0 adultscore=0
 phishscore=0 malwarescore=0 spamscore=0 mlxlogscore=842 mlxscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2208220000
 definitions=main-2209140083
X-Proofpoint-GUID: bc0MjNNQTBxUiAaxWQSyLoC09UJ72SJO
X-Proofpoint-ORIG-GUID: bc0MjNNQTBxUiAaxWQSyLoC09UJ72SJO
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 09/13/22 18:07, Doug Berger wrote:
> On 9/13/2022 4:34 PM, Matthew Wilcox wrote:
> > On Tue, Sep 13, 2022 at 12:54:50PM -0700, Doug Berger wrote:
> > > With gigantic pages it may not be true that struct page structures
> > > are contiguous across the entire gigantic page. The mem_map_offset
> > > function is used here in place of direct pointer arithmetic to
> > > correct for this.
> > 
> > We're just eliminating mem_map_offset().  Please use nth_page()
> > instead.That's good to know. I will include that in v2.

Thanks Doug and Matthew.  I will take a closer look at this series soon.

It seems like this patch is a fix independent of the series.  If so, I
would suggest sending separate to make it easy for backports to stable.
-- 
Mike Kravetz