Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <6e9c94e7-3f0b-83bd-b419-db6c002f7d98@baylibre.com>
Date:   Wed, 14 Sep 2022 21:44:24 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.13.0
Subject: Re: [PATCH] arm64: dts: mediatek: mt8183: remove thermal zones
 without trips.
Content-Language: en-US
To:     Matthias Brugger <matthias.bgg@gmail.com>,
        Rob Herring <robh+dt@kernel.org>
Cc:     Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org
References: <20220914131339.18348-1-aouledameur@baylibre.com>
 <a8af4c54-12a2-a314-f190-f12859ef4ddd@gmail.com>
From:   Amjad Ouled-Ameur <aouledameur@baylibre.com>
In-Reply-To: <a8af4c54-12a2-a314-f190-f12859ef4ddd@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

Hi Matthias,

Thank you for your review.

On 9/14/22 16:15, Matthias Brugger wrote:
>
>
> On 14/09/2022 15:13, Amjad Ouled-Ameur wrote:
>> Thermal zones without trip point are not registered by thermal core.
>>
>> tzts1 ~ tzts6 zones of mt8183 were intially introduced for test-purpose
>> only but are not supposed to remain on DT.
>>
>> Remove the zones above and keep only cpu_thermal.
>>
>
> My understanding is that this thermal zones exist but are not used. 
> DTS should describe the HW as it is, so I propose to add
> status = "disabled";
> to the zones.
>
Correct, they are unused unless for testing purposes. Thus, your 
suggestion of disabling them seems more relevant

than removal.


Regards,

Amjad

> Regards,
> Matthias
>
>> Signed-off-by: Amjad Ouled-Ameur <aouledameur@baylibre.com>
>> ---
>>   arch/arm64/boot/dts/mediatek/mt8183.dtsi | 57 ------------------------
>>   1 file changed, 57 deletions(-)
>>
>> diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi 
>> b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
>> index 9d32871973a2..f65fae8939de 100644
>> --- a/arch/arm64/boot/dts/mediatek/mt8183.dtsi
>> +++ b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
>> @@ -1182,63 +1182,6 @@ THERMAL_NO_LIMIT
>>                       };
>>                   };
>>               };
>> -
>> -            /* The tzts1 ~ tzts6 don't need to polling */
>> -            /* The tzts1 ~ tzts6 don't need to thermal throttle */
>> -
>> -            tzts1: tzts1 {
>> -                polling-delay-passive = <0>;
>> -                polling-delay = <0>;
>> -                thermal-sensors = <&thermal 1>;
>> -                sustainable-power = <5000>;
>> -                trips {};
>> -                cooling-maps {};
>> -            };
>> -
>> -            tzts2: tzts2 {
>> -                polling-delay-passive = <0>;
>> -                polling-delay = <0>;
>> -                thermal-sensors = <&thermal 2>;
>> -                sustainable-power = <5000>;
>> -                trips {};
>> -                cooling-maps {};
>> -            };
>> -
>> -            tzts3: tzts3 {
>> -                polling-delay-passive = <0>;
>> -                polling-delay = <0>;
>> -                thermal-sensors = <&thermal 3>;
>> -                sustainable-power = <5000>;
>> -                trips {};
>> -                cooling-maps {};
>> -            };
>> -
>> -            tzts4: tzts4 {
>> -                polling-delay-passive = <0>;
>> -                polling-delay = <0>;
>> -                thermal-sensors = <&thermal 4>;
>> -                sustainable-power = <5000>;
>> -                trips {};
>> -                cooling-maps {};
>> -            };
>> -
>> -            tzts5: tzts5 {
>> -                polling-delay-passive = <0>;
>> -                polling-delay = <0>;
>> -                thermal-sensors = <&thermal 5>;
>> -                sustainable-power = <5000>;
>> -                trips {};
>> -                cooling-maps {};
>> -            };
>> -
>> -            tztsABB: tztsABB {
>> -                polling-delay-passive = <0>;
>> -                polling-delay = <0>;
>> -                thermal-sensors = <&thermal 6>;
>> -                sustainable-power = <5000>;
>> -                trips {};
>> -                cooling-maps {};
>> -            };
>>           };
>>             pwm0: pwm@1100e000 {