Received: by 2002:a05:6358:489b:b0:bb:da1:e618 with SMTP id x27csp8363899rwn; Wed, 14 Sep 2022 13:11:52 -0700 (PDT) X-Google-Smtp-Source: AA6agR49VVm1GL+5cYKF1P4nHRRs+ijo6LPpYRZ+e1b92rAfWWFHXu/dXPoEREX7+BGYptrHI3gt X-Received: by 2002:a63:2546:0:b0:438:fe66:dc3 with SMTP id l67-20020a632546000000b00438fe660dc3mr14897468pgl.113.1663186311746; Wed, 14 Sep 2022 13:11:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1663186311; cv=none; d=google.com; s=arc-20160816; b=BtnnLbj+PBBto4R1DR9b/g2B9oor65MIZSwqLZhNFGm4hP4GijRY+pUNwF3xCf4VVA GZ8LN5ot9KRq9DQUM9icvRuZ6LzrzjUFsIhK+0fkiFCZQIaTWpwQX2+ouoogd2cDWcMD Ij7Dg6lIhDHGfcDiGz5+NKmwRkO+9ZwTxvNsRx95DEpuBoVOHMzulU0CORiVcHbl2mYG Ap/N6SLSng4724wgzahu5n1QDFSmD60TQHlQadKWrWYxZtzL1cCNx/bLr3JyeTzu1uip 93HH7YHMwK7DP7TY9M8HBZmcOONxLStKnnsTeSlfILVYPbQy8JDsMGSTBtin8fgl6Cmx fIPQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=lvw0ITSOs48BzL5oyBMZqWQqhouQBNn9dv3MjD3BUko=; b=gxy5rvb4a6gBJnIl1XcT2Pa20F4AnU/PuEgJOiq9/m9ltHRfTYmdLrXMw8PbyxCUA/ Zawk4tBnku8PUdUATn50e/kyMlLrLBqgVgxTLIz6FNhSFjx+LWxXPoKz+IcmYsAM1geu sophgg37eDjifn1oJq7BH5Mv+TKU43yKgA0ok0Ns4ziBVRMJpXxREagdrWR+Ovr/uq8R DgqQRW0E6IS9CL4//h3cpKBlHst0zkiZOy/JGK0Mfcoa47i749n9/LkutgRLPiGTNVJZ 8/zBMi+86AcSIZWl+s0+CcDGu1GfsKml9CJBLkLw9eHacZlzF171DXLDW64R0u3bRbkz 8xrA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id m184-20020a6326c1000000b0043476101149si16499364pgm.59.2022.09.14.13.11.05; Wed, 14 Sep 2022 13:11:51 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229682AbiINTuk (ORCPT + 99 others); Wed, 14 Sep 2022 15:50:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34852 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229599AbiINTui (ORCPT ); Wed, 14 Sep 2022 15:50:38 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0BDFB58DFE for ; Wed, 14 Sep 2022 12:50:36 -0700 (PDT) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oYYOv-000279-OY; Wed, 14 Sep 2022 21:50:25 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1oYYOv-000krD-Pi; Wed, 14 Sep 2022 21:50:24 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1oYYOt-000vyV-Ge; Wed, 14 Sep 2022 21:50:23 +0200 Date: Wed, 14 Sep 2022 21:50:19 +0200 From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= To: zhaoxiao Cc: thierry.reding@gmail.com, heiko@sntech.de, linux-pwm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATH v5] pwm: rockchip: Convert to use dev_err_probe() Message-ID: <20220914195019.wfh3havo7l44nyzp@pengutronix.de> References: <20220822081848.5126-1-zhaoxiao@uniontech.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="hjtfz2vfkl6wa2pk" Content-Disposition: inline In-Reply-To: <20220822081848.5126-1-zhaoxiao@uniontech.com> X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --hjtfz2vfkl6wa2pk Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Aug 22, 2022 at 04:18:48PM +0800, zhaoxiao wrote: > It's fine to call dev_err_probe() in ->probe() when error code is known. > Convert the driver to use dev_err_probe(). >=20 > Signed-off-by: zhaoxiao Looks fine now: Reviewed-by: Uwe Kleine-K=F6nig Best regards Uwe --=20 Pengutronix e.K. | Uwe Kleine-K=F6nig | Industrial Linux Solutions | https://www.pengutronix.de/ | --hjtfz2vfkl6wa2pk Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEfnIqFpAYrP8+dKQLwfwUeK3K7AkFAmMiMHgACgkQwfwUeK3K 7Akazgf+JObTEgkacuKZlOdRlYqDkIMo2O8xXlf2w/NdJzZD5k2xCQHFZRdWfXf6 q4U+heL7Zf26lCpBDDMld09db6IVHJlt4K9fwS6ZpCWT2CwUIvbM4BAOkhZp0C0f 1Yh0UM/j79+GD6gx1RjvBZMqPHT/qbzrwxcL1rwkF2MU0aNcRXCJdPXil2sDleH9 FUzzkHxRYUALDfT6tYilF0QHIWX+0X/qc5eDTxySAdS58LrJ2pdArnirPbM8D1JP 4NuqWQdjBpUFbgwKC0hQJzZsfUjzIJ2F5S9I8LrTeNqzHg18unNj1MIMviUvzjpe EzzB99kvi+EZgig0QTY+Rf0OfcQfWg== =XaE2 -----END PGP SIGNATURE----- --hjtfz2vfkl6wa2pk--