Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 14 Sep 2022 21:59:46 +0200
From:   Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de>
To:     Conor Dooley <conor.dooley@microchip.com>
Cc:     Thierry Reding <thierry.reding@gmail.com>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Daire McNamara <daire.mcnamara@microchip.com>,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-pwm@vger.kernel.org, linux-riscv@lists.infradead.org
Subject: Re: [PATCH v10 2/4] riscv: dts: fix the icicle's #pwm-cells
Message-ID: <20220914195946.eadkppkgqwgwdace@pengutronix.de>
References: <20220824091215.141577-1-conor.dooley@microchip.com>
 <20220824091215.141577-3-conor.dooley@microchip.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="xhs4rna6j2neqkiv"
Content-Disposition: inline
In-Reply-To: <20220824091215.141577-3-conor.dooley@microchip.com>
Precedence: bulk


--xhs4rna6j2neqkiv
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hello,

On Wed, Aug 24, 2022 at 10:12:13AM +0100, Conor Dooley wrote:
> \#pwm-cells for the Icicle kit's fabric PWM was incorrectly set to 2 &
> blindly overridden by the (out of tree) driver anyway. The core can
> support inverted operation, so update the entry to correctly report its
> capabilities.
>=20
> Fixes: 72560c6559b8 ("riscv: dts: microchip: add fpga fabric section to i=
cicle kit")
> Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
> ---
>  arch/riscv/boot/dts/microchip/mpfs-icicle-kit-fabric.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/arch/riscv/boot/dts/microchip/mpfs-icicle-kit-fabric.dtsi b/=
arch/riscv/boot/dts/microchip/mpfs-icicle-kit-fabric.dtsi
> index 0d28858b83f2..e09a13aef268 100644
> --- a/arch/riscv/boot/dts/microchip/mpfs-icicle-kit-fabric.dtsi
> +++ b/arch/riscv/boot/dts/microchip/mpfs-icicle-kit-fabric.dtsi
> @@ -8,7 +8,7 @@ core_pwm0: pwm@41000000 {
>  		compatible =3D "microchip,corepwm-rtl-v4";
>  		reg =3D <0x0 0x41000000 0x0 0xF0>;
>  		microchip,sync-update-mask =3D /bits/ 32 <0>;
> -		#pwm-cells =3D <2>;
> +		#pwm-cells =3D <3>;
>  		clocks =3D <&fabric_clk3>;
>  		status =3D "disabled";
>  	};

there are no phandles on that PWM, so there is nothing that needs a
followup adaption.

Reviewed-by: Uwe Kleine-K=F6nig <u.kleine-koenig@pengutronix.de>

Best regards
Uwe

--=20
Pengutronix e.K.                           | Uwe Kleine-K=F6nig            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

--xhs4rna6j2neqkiv
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEfnIqFpAYrP8+dKQLwfwUeK3K7AkFAmMiMq8ACgkQwfwUeK3K
7Ak7Zwf+OlC3O2dW/x6W5h0S9s75i5/nHm6Qx6dJ+U0/9ukUC7hv6MpgLDPI08d4
MQwDXMwEZ3G1Y/UnlbOKWRhtqI3lJ+CPy3yvjpnL5JfmuOh2dpAApo2qjOTZUhqA
MW7+voTOO667MO4uTXK2BEm+2mbT5NQUkvpGK/EOyPMADNo/VOVu/+c6oQu42v9f
G7trOzs9N5WUSZ6egtXHuY53p5LU1I0yReOzWPZsE03JN0xMUJWp3itac/mb7jU/
5ANyCAfTNzhZG9AGCv6jVnk5wSvlglLYV243HG/tELYR5cULQuxhSdY+IwSZmfXq
JtnxMFPz+BxcgoLtxTFO+/Tb31Nr0Q==
=l8aw
-----END PGP SIGNATURE-----

--xhs4rna6j2neqkiv--