Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Han Xu <han.xu@nxp.com>
To:     Abel Vesa <abelvesa@kernel.org>,
        Michael Turquette <mturquette@baylibre.com>,
        Stephen Boyd <sboyd@kernel.org>,
        Shawn Guo <shawnguo@kernel.org>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        Pengutronix Kernel Team <kernel@pengutronix.de>,
        Fabio Estevam <festevam@gmail.com>,
        NXP Linux Team <linux-imx@nxp.com>,
        linux-clk@vger.kernel.org (open list:NXP i.MX CLOCK DRIVERS),
        linux-arm-kernel@lists.infradead.org (moderated list:ARM/FREESCALE IMX
        / MXC ARM ARCHITECTURE), linux-kernel@vger.kernel.org (open list)
Cc:     miquel.raynal@bootlin.com, linux-mtd@lists.infradead.org,
        han.xu@nxp.com
Subject: [PATCH] clk: imx: imx6sx: remove the SET_RATE_PARENT flag for QSPI clocks
Date:   Wed, 14 Sep 2022 15:10:48 -0500
Message-Id: <20220914201049.3508104-1-han.xu@nxp.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?n5OITiVF4TEi4Nn9vXFuhRYFUWbF6kCbfn9Su+6ues+KyoQgBth6d4nrrcms?=
 =?us-ascii?Q?SQePAktxmbelXtTNt9uun/WQzbrV9IM36CCIiLzhftNmrf8e+2zbT27cn5gh?=
 =?us-ascii?Q?5YrpaTNmTjwWnv9NaMgQsPqHC4JoULqULgxwZ8cRo73uq4Yqzdtphu8rCXU9?=
 =?us-ascii?Q?vkpI3pAJmrU+DZd0H1JnK6PPlGfMuefS6XOl/mGdGY+BlsdWhJbnuIWDRfs9?=
 =?us-ascii?Q?NO4nAbX/9/GLgW7xzVpiUG4EJq947i+lvrkVfXNv2W+VY1nEbOIi7rh+OiNA?=
 =?us-ascii?Q?Hh0GKDTqpiLiSF4TasiD6ySKncgSCpz4WKZs+B0PqrI1Uto8liB3xGRFM2/O?=
 =?us-ascii?Q?dG21m+ZGOYP17h9jgZ2hsGIuAoFJedSh36CZXHZTrT6cQf879OWgjvXfU0tn?=
 =?us-ascii?Q?byTHDj1Psg4wvT7UQpamFA5hD2Y4lG636+nUCcDWfU+pdHVUIQ7nAQdRzRsg?=
 =?us-ascii?Q?xnlJtnKwv3x4Y7qd3vwo22f4eaIQeiOJscjIjucAfE/OALHCdWT27uHOlFfb?=
 =?us-ascii?Q?4MbQcCc0Sn7g8twjLbSM1BEi/bhB9lmB8emQV496fR0w4T3EJO9U9jz8TgXN?=
 =?us-ascii?Q?56Mq3+NEWz+Akdn2D7f6g6Eu8bbZkPbMJIIdImS/S5FMs+7EtLBfI48zX2y+?=
 =?us-ascii?Q?ORERSOjMRbyHtu8oA7UoQiq4wbeK/yCO1GsV33u9q3ZFncU90IaEkPUCJzvT?=
 =?us-ascii?Q?380QaY+5OSAJ3OO/0O5g42n/QjUhk368XzIgny8wxvAjlVtxBElHiiRfhNae?=
 =?us-ascii?Q?HhEk/4JBRGUw0A7+/XaakObFe6phIY+of6zvvbNaMYUtRoGtzzpZ2Yusgl5G?=
 =?us-ascii?Q?je07qn0mKJoY719ptMOGnc2IuMkh0cuM8DEWhOxAeiJsD4mcOcI173tPvV4b?=
 =?us-ascii?Q?2O62sr5gpsmLY8u70pongQOiQIDqbtAXojSZL2ixkQ1vMgGsIuEjGuMufYS6?=
 =?us-ascii?Q?XQsQ/FqxV+KlbBRzhX8PQxwxb5PpzzZjpo23yLixjZHEdEzR+WOFmefx0fnq?=
 =?us-ascii?Q?+INAKF543hTHjIiR5Khzds2cYI8VqAnv+yKaQlHOgnYb0naI27QZ/qFurdB5?=
 =?us-ascii?Q?CDH1/+24xOQkh7IVWlMqCKUkvVMeh1tKrA7O+iwa06xtVvzEVNf0iVGMxoJj?=
 =?us-ascii?Q?Eu273kFJPvNehB2rE3bISUBQFzy8J5RiSCKDpVse4bP7Bws3pcGCVoNNnrK9?=
 =?us-ascii?Q?cQSqJupcLhesF1UudAKjF9pEDK9gBM05Esc3nSY6xkO0RQ5zcrvXk1fnRbQ7?=
 =?us-ascii?Q?9wxqeJpDILQqpXLPCwwQ2zwCzZHq5oDb0oD4gB185Ut/yTr25hxg711E7FJR?=
 =?us-ascii?Q?sg7jKUkNFumVkiybiCxtgDPENFYzZlLVT7m2AhPJBR+aRnWgnkMS9yqETOxY?=
 =?us-ascii?Q?kV9/kJGvDk0DcH3TUc18P2w6e/w6vo+wguT5OoD04yK/4HjsSd31GjcDV+Ga?=
 =?us-ascii?Q?Fp2fwM+PhlE1nL3lzQ9/9XQPhvDBJ8XQ9DzMN7z3ZPJFLho8VlYa7GNlHNYv?=
 =?us-ascii?Q?/ck61RqYCY3R2NFJkKZYaJF3D8SwQ8J5+39If7FogqYl7kXPhOGDgRyPQfyL?=
 =?us-ascii?Q?lF01JxWaWDOccHodcIE=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 86a2cea4-6678-44c0-f957-08da968d45e9
X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8781.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Sep 2022 20:11:13.5581
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: YvEXsYWqZ+m9kEwwDNgTktQrtJDUEtL4aDkQBwPV26yGkWYCSdMxnOu1J8IfYOjU
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB8249
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

There is no dedicate parent clock for QSPI so SET_RATE_PARENT flag
should not be used. For instance, the default parent clock for QSPI is
pll2_bus, which is also the parent clock for quite a few modules, such
as MMDC, once GPMI NAND set clock rate for EDO5 mode can cause system
hang due to pll2_bus rate changed.

Fixes: f1541e15e38e ("clk: imx6sx: Switch to clk_hw based API")
Signed-off-by: Han Xu <han.xu@nxp.com>
---
 drivers/clk/imx/clk-imx6sx.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/clk/imx/clk-imx6sx.c b/drivers/clk/imx/clk-imx6sx.c
index 2301d8fb8c76..1e53e366cde7 100644
--- a/drivers/clk/imx/clk-imx6sx.c
+++ b/drivers/clk/imx/clk-imx6sx.c
@@ -324,13 +324,13 @@ static void __init imx6sx_clocks_init(struct device_node *ccm_node)
 	hws[IMX6SX_CLK_SSI3_SEL]           = imx_clk_hw_mux("ssi3_sel",         base + 0x1c,  14,     2,      ssi_sels,          ARRAY_SIZE(ssi_sels));
 	hws[IMX6SX_CLK_SSI2_SEL]           = imx_clk_hw_mux("ssi2_sel",         base + 0x1c,  12,     2,      ssi_sels,          ARRAY_SIZE(ssi_sels));
 	hws[IMX6SX_CLK_SSI1_SEL]           = imx_clk_hw_mux("ssi1_sel",         base + 0x1c,  10,     2,      ssi_sels,          ARRAY_SIZE(ssi_sels));
-	hws[IMX6SX_CLK_QSPI1_SEL]          = imx_clk_hw_mux_flags("qspi1_sel", base + 0x1c,  7, 3, qspi1_sels, ARRAY_SIZE(qspi1_sels), CLK_SET_RATE_PARENT);
+	hws[IMX6SX_CLK_QSPI1_SEL]          = imx_clk_hw_mux("qspi1_sel",        base + 0x1c,  7,      3,      qspi1_sels,        ARRAY_SIZE(qspi1_sels);
 	hws[IMX6SX_CLK_PERCLK_SEL]         = imx_clk_hw_mux("perclk_sel",       base + 0x1c,  6,      1,      perclk_sels,       ARRAY_SIZE(perclk_sels));
 	hws[IMX6SX_CLK_VID_SEL]            = imx_clk_hw_mux("vid_sel",          base + 0x20,  21,     3,      vid_sels,          ARRAY_SIZE(vid_sels));
 	hws[IMX6SX_CLK_ESAI_SEL]           = imx_clk_hw_mux("esai_sel",         base + 0x20,  19,     2,      audio_sels,        ARRAY_SIZE(audio_sels));
 	hws[IMX6SX_CLK_CAN_SEL]            = imx_clk_hw_mux("can_sel",          base + 0x20,  8,      2,      can_sels,          ARRAY_SIZE(can_sels));
 	hws[IMX6SX_CLK_UART_SEL]           = imx_clk_hw_mux("uart_sel",         base + 0x24,  6,      1,      uart_sels,         ARRAY_SIZE(uart_sels));
-	hws[IMX6SX_CLK_QSPI2_SEL]          = imx_clk_hw_mux_flags("qspi2_sel", base + 0x2c, 15, 3, qspi2_sels, ARRAY_SIZE(qspi2_sels), CLK_SET_RATE_PARENT);
+	hws[IMX6SX_CLK_QSPI2_SEL]          = imx_clk_hw_mux("qspi2_sel",        base + 0x2c,  15,     3,      qspi2_sels,        ARRAY_SIZE(qspi2_sels);
 	hws[IMX6SX_CLK_SPDIF_SEL]          = imx_clk_hw_mux("spdif_sel",        base + 0x30,  20,     2,      audio_sels,        ARRAY_SIZE(audio_sels));
 	hws[IMX6SX_CLK_AUDIO_SEL]          = imx_clk_hw_mux("audio_sel",        base + 0x30,  7,      2,      audio_sels,        ARRAY_SIZE(audio_sels));
 	hws[IMX6SX_CLK_ENET_PRE_SEL]       = imx_clk_hw_mux("enet_pre_sel",     base + 0x34,  15,     3,      enet_pre_sels,     ARRAY_SIZE(enet_pre_sels));
-- 
2.25.1