Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 14 Sep 2022 14:18:57 -0700
From:   Mike Kravetz <mike.kravetz@oracle.com>
To:     Doug Berger <opendmb@gmail.com>,
        Andrew Morton <akpm@linux-foundation.org>
Cc:     Muchun Song <songmuchun@bytedance.com>,
        Oscar Salvador <osalvador@suse.de>, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH] mm/hugetlb: correct demote page offset logic
Message-ID: <YyJFQaZtZr08fMhj@monkey>
References: <20220914190917.3517663-1-opendmb@gmail.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220914190917.3517663-1-opendmb@gmail.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?x3KnXRJ81r3FJIF0InanYxORrgCIAAn46N0LphT0AeAAoCz44ZWGn9A5ochx?=
 =?us-ascii?Q?iSIfRHhXP8jAs6CXO3w3/BG1jUJ2sexmT0q4X3NmWiN3XyMF8yHLMySA4suS?=
 =?us-ascii?Q?hleD7I5hQl7cOWKsd9S6vIwrl4gUVSPqeY6AiDCR41PXTqdhaIhVL+HhZknA?=
 =?us-ascii?Q?yhKbnRnzzURInHksekBp2qookbY/wJprBFnqil/lfDmr9ODdD06NXN/lkHtL?=
 =?us-ascii?Q?7hx3ExxjHfKHFFmjZ2v3c1oHhjTPE3OmtG/otE2Ha6Ko+b95a3ChgttD6fh/?=
 =?us-ascii?Q?I42KXTGVDz7xlYvn8tOha1ZP8BpwTW4wzwy3xEzaY+T8/rZRzpRbeS9m/5MB?=
 =?us-ascii?Q?9wnk70gxH7NekTAS4yRidgn7pbSf3IvS77frPR8AebnK3mz6YSJFLmSJ7Tqm?=
 =?us-ascii?Q?PuYbhyPgsOtZ5f7x4TNPCmdh0doBCGFAi+H7L6t8qQwqayLY7c3PBZr8rI5g?=
 =?us-ascii?Q?D4+wlotTgLjjTLThOx+sZRyo4/NP/BItaYwq9uGKou1rXt03Ptkn0jWoLIgJ?=
 =?us-ascii?Q?xGx0MuK6OWhtEZn5oStIXBXHXJCiCXJlxjITVN7sr2o+OSg0FqL4ZaIAT8on?=
 =?us-ascii?Q?fH7gxlChEbLOFB9tE5flttn5cQmJziT40BC4WjTJfdhVYQpNoHzr+BSpO8G7?=
 =?us-ascii?Q?tmJcjcPhs09rTXalWGpNr105wiHRogCpXvCioWY+eQGutrz4BNxnNfDXFs2J?=
 =?us-ascii?Q?cu7SPXPslL1WxHPwXujomcYKbfYl3OiyfWlpC69l0O3ZfWWgWbB9njWJb/ia?=
 =?us-ascii?Q?G19SjM1f86+FSyPlchS1IJMjsu1ukIMMosGMi+3QbAIL7xFz0sWaq+v/nBtl?=
 =?us-ascii?Q?lshUTOI+pERqDqjssHLHr8VXuF/q6kxpYao7ImZ6qw8MH6mENYIrbX2FKpEf?=
 =?us-ascii?Q?bvhtnpy/L1IH4vQcjEVIt2W99Gh3AYl50MjUqzWa6Ygkn3sPob09ntnsuaDn?=
 =?us-ascii?Q?WGg/mQ5ntN6wcwpVqJyAdXtpCrSyS84RyeYV+BvkOES+HX9pC3+Ex603HoVK?=
 =?us-ascii?Q?ZwvJmjCCjMTofIhdgDOT1q57om7XkMkntaiJ5kRh01Rj9KTlGhq0JPgVzZcQ?=
 =?us-ascii?Q?FAV4xXcRYB901zf32wasd+mNpnab2Ihdj+y7OvGXXaBw9Pa3SGxcA3vMTRW+?=
 =?us-ascii?Q?T4kfj6uNu/SjLw0dK6PLDKloSYvYlctlA3hiuNlBY5MD5z3f7xPKHV8ea8bB?=
 =?us-ascii?Q?QWocWuORG++2uYVxxZkBItCJUFK4d/AbbfSl67ltwL1ZBMqnfMvwg15yT+YK?=
 =?us-ascii?Q?kKkEZK9w9txoi5ZICBCaTQoDKtQlNO0ng2059y02//AOkRGYSAUkPItnEyzv?=
 =?us-ascii?Q?nd+ozNmLG/yWV9oqTvWhNWkZEZEYZ+ZDgOPlqlpFK6LLPF6+FqyMxBySD1zf?=
 =?us-ascii?Q?ctoA3diahma4J4rUTpjRj2zay56m++HO2tDcquD4CendDCQDvv4J9mpGt5/M?=
 =?us-ascii?Q?qcI53WhnW2JcDv6Tmi5QiN8DVzKlhfPMfq5OHrOlNieN9rEC2qzzTeW59g4e?=
 =?us-ascii?Q?gIsgL13oEamNiah1iZPCxzB5A9O+9JfiYmxUllbCDhhe/Ck/fSwrprfBgh+B?=
 =?us-ascii?Q?4gHaZOeXpdKVIls8Y8C0BTC5T8a/0CBpZzPLG5Cg25nEa1rlGijGWqTjlxOw?=
 =?us-ascii?Q?Vg=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 66e05612-3885-4ca1-a0a6-08da9696be57
X-MS-Exchange-CrossTenant-AuthSource: BY5PR10MB4196.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Sep 2022 21:19:01.0128
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ZBmy0FFYjaTH9sdFRpcEnPaDFc8K8by+o4WG3v2l+LfN9HYCvIfV6sp7hDWKFcsv73WFHEcwD5meRdqU29VH6w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR10MB6731
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.528,FMLib:17.11.122.1
 definitions=2022-09-14_09,2022-09-14_04,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 suspectscore=0 adultscore=0
 phishscore=0 malwarescore=0 spamscore=0 mlxlogscore=999 mlxscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2208220000
 definitions=main-2209140103
X-Proofpoint-ORIG-GUID: l15a-4Knl8Dc34juGv0i7R4jCikbsKf9
X-Proofpoint-GUID: l15a-4Knl8Dc34juGv0i7R4jCikbsKf9
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 09/14/22 12:09, Doug Berger wrote:
> With gigantic pages it may not be true that struct page structures
> are contiguous across the entire gigantic page. The nth_page macro
> is used here in place of direct pointer arithmetic to correct for
> this.
> 
> Fixes: 8531fc6f52f5 ("hugetlb: add hugetlb demote page support")
> Signed-off-by: Doug Berger <opendmb@gmail.com>
> Cc: <stable@vger.kernel.org>
> ---
>  mm/hugetlb.c | 14 ++++++++------
>  1 file changed, 8 insertions(+), 6 deletions(-)

Thanks!

Reviewed-by: Mike Kravetz <mike.kravetz@oracle.com>

To answer Andrew's question about user-visible runtime effects.
We could get addressing exceptions.  However, this is only possible in
configurations where CONFIG_SPARSEMEM && !CONFIG_SPARSEMEM_VMEMMAP.
Such a configuration option is rare an unknown to be the default
anywhere.
-- 
Mike Kravetz