Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 14 Sep 2022 14:11:05 -0700
From:   Mike Kravetz <mike.kravetz@oracle.com>
To:     Andrew Morton <akpm@linux-foundation.org>
Cc:     Doug Berger <opendmb@gmail.com>, Jonathan Corbet <corbet@lwn.net>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Frank Rowand <frowand.list@gmail.com>,
        Muchun Song <songmuchun@bytedance.com>,
        Mike Rapoport <rppt@kernel.org>,
        Christoph Hellwig <hch@lst.de>,
        Marek Szyprowski <m.szyprowski@samsung.com>,
        Robin Murphy <robin.murphy@arm.com>,
        Borislav Petkov <bp@suse.de>,
        "Paul E. McKenney" <paulmck@kernel.org>,
        Neeraj Upadhyay <quic_neeraju@quicinc.com>,
        Randy Dunlap <rdunlap@infradead.org>,
        Damien Le Moal <damien.lemoal@opensource.wdc.com>,
        Florian Fainelli <f.fainelli@gmail.com>,
        David Hildenbrand <david@redhat.com>, Zi Yan <ziy@nvidia.com>,
        Oscar Salvador <osalvador@suse.de>,
        Hari Bathini <hbathini@linux.ibm.com>,
        Kees Cook <keescook@chromium.org>,
        - <devicetree-spec@vger.kernel.org>,
        KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
        Mel Gorman <mgorman@suse.de>, linux-doc@vger.kernel.org,
        linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
        linux-mm@kvack.org, iommu@lists.linux.dev
Subject: Re: [PATCH 02/21] mm/hugetlb: correct max_huge_pages accounting on
 demote
Message-ID: <YyJDaVRrKy5jgewU@monkey>
References: <20220913195508.3511038-1-opendmb@gmail.com>
 <20220913195508.3511038-3-opendmb@gmail.com>
 <YyIN+bpKdCb3JuuY@monkey>
 <20220914135825.88814aa1699e93c8a782abc6@linux-foundation.org>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220914135825.88814aa1699e93c8a782abc6@linux-foundation.org>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Xs/rUxOkxCNyFmGAzdTXlrpuh72vfJwLEM4PwSbCIXBcv0P44vAIgKvJQWkg?=
 =?us-ascii?Q?2WF0uqKHR8v6b6N0cW7+97zAnbW0CaLtZeLPotw4C9oJ+uVIpVpXkCvwvqkx?=
 =?us-ascii?Q?EgLXRt/d9I8VBt+UvIsclsEkOcrqyYtATUZ4XG8951KOBWu4k4k06BZJoKBK?=
 =?us-ascii?Q?OIGwkfFxODSUrzFJZiO7tebnNm7Ye4VgE92zU9ta7QlLFAP4Tt6ZzhpLMX2o?=
 =?us-ascii?Q?n+M4TmXAQJR/OGbjq89AKmzCcS1yG1XbxlABRytE8ucaahgK74OZVFKATIiv?=
 =?us-ascii?Q?frXBTOmnU6x9W+rjzy3gfTYPtcrETsNIrh/fhX0aSgMcUc4KipEE4o4aa/lk?=
 =?us-ascii?Q?hffGTfmgHIJyJ5sSwQ/mIGrR1Mmf3L+HcezxmrjhAVRLWBtNEZ4dAYkWxp5e?=
 =?us-ascii?Q?m1xReRZVHH8TtzTOqO0fYzQh7sa6ITuCWIOacUXGtf/dfTAWDsymlupYZH8q?=
 =?us-ascii?Q?73rtGuRLhcnRrCRpYcFvrqYNhpEdZNWk2A0g/4IY3XOS4FoCf2D73dp+NNq9?=
 =?us-ascii?Q?QxMgetJ7lyrmb2uXA44Pdlsg6x2WrWgXpLJJcW5CCj+B+HW+KX6FdSXp83lI?=
 =?us-ascii?Q?buTIszkKduz7gqSJvUOuilecMGVKdsK/QOQb6QHSbq7jY8Ln3DdkhlPuM7Vp?=
 =?us-ascii?Q?Koy4FzCwePLy0NXS7Yihd5eUiaskdreNNBXvsrJ1Mb7vto8Ng5rs/tDRXmrT?=
 =?us-ascii?Q?E1Kril92Ibr9GUmVcy8tBaQ0BoqIUAzsb5OAIXarewi1403btgxs4FZaM5JB?=
 =?us-ascii?Q?ZLKXvEB80+z3WXQOvOghPZteAWBb8PpvSKV0kDgyzl3l5Z3F+Ly9s9iuFYQg?=
 =?us-ascii?Q?6Y4s5eweE9jCPTLLXdZn1TfAHxhd/JTpSztRBaykIGbKeJxhW38iOvJq6EJ6?=
 =?us-ascii?Q?9VQTgKOBTrUEr7SKE70/Bfu4hzQNREGpIMKCOtOgq8G+pGm5OTI1WY8Y/x0E?=
 =?us-ascii?Q?eBMjPt6bKb57rMnjnKxgHcqD4quZEqZk+TdOq50dMK3+n1imCk4x3u8qHKsq?=
 =?us-ascii?Q?+Ca701NCbvLZGKimjaW5DzZuhzXovEcMwOj3KJCdalpevp8vsxPq8qHcMl8F?=
 =?us-ascii?Q?+rF+CtmA8TFlST+pUFZ++zKjMEcb4S8280JvZdXoERy/MuI3QTUb/eSP1gmm?=
 =?us-ascii?Q?FlTLN4pT7oeQCH3Gr40dPwAFK6jgX8KsWC2uRg8S06TP6MOvEKY1uQ1hbfhQ?=
 =?us-ascii?Q?cn7ADZFkWE1Qw4jJenqikAsyQnr8LvaNkqDM3cF0mYTs6VILOxhqagWmDedA?=
 =?us-ascii?Q?ULE8hdaCN09M0MYZB+wjdgKED8S0zMLQC6QkzCTfyQDVva8Fvi4A6+rI9HGS?=
 =?us-ascii?Q?Djid3Wzm0O1+rZIG9RipHjLJhfsGTQBBKu1skKAWlyHZFCIPwmtZfjD7mZid?=
 =?us-ascii?Q?BJAI2KXes+KTUIG/6LKhylTiphD8tZ6lRU6wR35WtpSHgSs7LTuWGU7yZXjq?=
 =?us-ascii?Q?JGGNkZy+kY38EiNEtrhiGMN9oGFZaNXoWXymjMSonKS4FyPqmQxiqFUMxs9g?=
 =?us-ascii?Q?3Sp33SjJbgBKTOKiUjN4yFwONCyHmscu7xyfnKfTKDHmbuk9sNMcjXUGzJ/n?=
 =?us-ascii?Q?CGNerF89mX0Xk070PdTyGQAJTTurSjBhnYSqqmKfwNLIsm2B0ts75CXvt1Nr?=
 =?us-ascii?Q?Jw=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8f63acdc-4995-48d7-f0ec-08da9695a51e
X-MS-Exchange-CrossTenant-AuthSource: BY5PR10MB4196.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Sep 2022 21:11:09.3876
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 5sdo4ydswmtTgWF7/BBBNl6S+jLzBTJbigakwT3nRqPK/jyAvkBUz0nUJbwHOv1YhkQFvt0DUIL/NdL0gP20fw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR10MB6047
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.528,FMLib:17.11.122.1
 definitions=2022-09-14_09,2022-09-14_04,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 mlxlogscore=999
 bulkscore=0 phishscore=0 spamscore=0 suspectscore=0 adultscore=0
 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2208220000 definitions=main-2209140102
X-Proofpoint-ORIG-GUID: o47Za2_nWZCmQWDSLjUhUfHgjtNLBAOg
X-Proofpoint-GUID: o47Za2_nWZCmQWDSLjUhUfHgjtNLBAOg
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 09/14/22 13:58, Andrew Morton wrote:
> On Wed, 14 Sep 2022 10:23:05 -0700 Mike Kravetz <mike.kravetz@oracle.com> wrote:
> 
> > On 09/13/22 12:54, Doug Berger wrote:
> > > When demoting a hugepage to a smaller order, the number of pages
> > > added to the target hstate will be the size of the large page
> > > divided by the size of the smaller page.
> > > 
> > > Fixes: 8531fc6f52f5 ("hugetlb: add hugetlb demote page support")
> > > Signed-off-by: Doug Berger <opendmb@gmail.com>
> > > ---
> > >  mm/hugetlb.c | 3 ++-
> > >  1 file changed, 2 insertions(+), 1 deletion(-)
> > > 
> > > diff --git a/mm/hugetlb.c b/mm/hugetlb.c
> > > index e070b8593b37..79949893ac12 100644
> > > --- a/mm/hugetlb.c
> > > +++ b/mm/hugetlb.c
> > > @@ -3472,7 +3472,8 @@ static int demote_free_huge_page(struct hstate *h, struct page *page)
> > >  	 * based on pool changes for the demoted page.
> > >  	 */
> > >  	h->max_huge_pages--;
> > > -	target_hstate->max_huge_pages += pages_per_huge_page(h);
> > > +	target_hstate->max_huge_pages += pages_per_huge_page(h) /
> > > +					 pages_per_huge_page(target_hstate);
> > >  
> > >  	return rc;
> > >  }
> > 
> > This has already been fixed here,
> > 
> > https://lore.kernel.org/linux-mm/20220823030209.57434-2-linmiaohe@huawei.com/
> 
> Neither version tells us the user-visible runtime effects of the change :(

Sorry, I should have pushed harder on this with Miaohe's patch.

There are no user-visible runtime effects.  In fact, this change really causes
no functional change (unless I am mistaken and Miaohe did not correct me).
max_huge_pages is not used again until it is reset.  See my explanation at:
https://lore.kernel.org/linux-mm/YvwfvxXewnZpHQcz@monkey/
-- 
Mike Kravetz