Received: by 2002:a05:6358:489b:b0:bb:da1:e618 with SMTP id x27csp208477rwn; Wed, 14 Sep 2022 19:10:03 -0700 (PDT) X-Google-Smtp-Source: AA6agR5hIoY7/uCqK8herlTIIesl3whATDi0Gb9Ih3bNzlNi8lmBOfK74DB+x4Y9CElOPor7hw3H X-Received: by 2002:a17:907:6d1c:b0:77c:c016:19ef with SMTP id sa28-20020a1709076d1c00b0077cc01619efmr13052717ejc.689.1663207803202; Wed, 14 Sep 2022 19:10:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1663207803; cv=none; d=google.com; s=arc-20160816; b=zofciPgsXU+l2hkKoG2OpknSdmUc+0E7ZFeP9i1X8bP5IWQRN1+yTD0X2Foph+HbEe +taJ05cnE/6GGqJj8zr4YyN+qX2fbWoaKiE+DxSJMHvyhqcHQGf9cNFC/BZ95/0S9IzU e7YngcMubt5rsGWtlEhVAW8+ueZ61IDfazFmxbRa3yvechsyrZOCCWnkTydahGc4kigs BMuSkV6u9MOJffbhVuJnp7bPkkfOzgrBg+bp47ScvAPFB4eOGXRr0qLDkRwklsDZ+Cai zMasa88F0akelIKhz8uc7vgKUtix5EugOe4HwUnD3Zw2mw/5VHqYtLv/coZDXGo0A0J4 ANDQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=rvB35OKFa+7W+ijd2GLamLxj7U3NwzNLyP4en11yxrY=; b=Z9nZa6KEjO5iwNUk+12JDtzPbrYLt0wYgCrFaotXykbyd2e+fbXSwynT/xP7a9Y5jJ o6irFt6zwymCpKwqtg5hdfI7Z3B3Rwt7T4WFKlsBDvJ1UOOdTTRmmZLp0dVPFC4Y9rZE nGjj06ckp3JWDlVxiJa7gIkqL0CRu0XLgmvXAOdBIRFesd8nzTe3R85ZYbfhUq4AMn4p hhLsv1esLoWs1X1txf+olkhwnfSRDiexC8E8o0pUjcJZALTCKrjLRgPX8dMUfvjxWUVG qmFZhjqBa5nHnoueq3quL/BeAzglcCRZzH24b3YfPq/P8ZnCMVtFIyxa4GHy9me24cEL WU6w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id dn21-20020a17090794d500b00777a40d515dsi14537773ejc.456.2022.09.14.19.09.37; Wed, 14 Sep 2022 19:10:03 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229980AbiIOBgQ (ORCPT + 99 others); Wed, 14 Sep 2022 21:36:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51488 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229761AbiIOBgN (ORCPT ); Wed, 14 Sep 2022 21:36:13 -0400 Received: from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A30958C478 for ; Wed, 14 Sep 2022 18:36:12 -0700 (PDT) Received: from dggemv704-chm.china.huawei.com (unknown [172.30.72.54]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4MSfnm4Gfmz14QNR; Thu, 15 Sep 2022 09:32:12 +0800 (CST) Received: from kwepemm600005.china.huawei.com (7.193.23.191) by dggemv704-chm.china.huawei.com (10.3.19.47) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Thu, 15 Sep 2022 09:36:10 +0800 Received: from huawei.com (10.69.192.56) by kwepemm600005.china.huawei.com (7.193.23.191) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Thu, 15 Sep 2022 09:36:10 +0800 From: Longfang Liu To: , , CC: , , , Subject: [PATCH 3/5] hisi_acc_vfio_pci: Remove useless function parameter Date: Thu, 15 Sep 2022 09:31:55 +0800 Message-ID: <20220915013157.60771-4-liulongfang@huawei.com> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20220915013157.60771-1-liulongfang@huawei.com> References: <20220915013157.60771-1-liulongfang@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=US-ASCII X-Originating-IP: [10.69.192.56] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To kwepemm600005.china.huawei.com (7.193.23.191) X-CFilter-Loop: Reflected X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Remove unused function parameters for vf_qm_fun_reset() and ensure the device is enabled before the reset operation is performed. Signed-off-by: Longfang Liu --- drivers/vfio/pci/hisilicon/hisi_acc_vfio_pci.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/vfio/pci/hisilicon/hisi_acc_vfio_pci.c b/drivers/vfio/pci/hisilicon/hisi_acc_vfio_pci.c index 3790b76a578e..c172a52088b7 100644 --- a/drivers/vfio/pci/hisilicon/hisi_acc_vfio_pci.c +++ b/drivers/vfio/pci/hisilicon/hisi_acc_vfio_pci.c @@ -345,8 +345,7 @@ static struct hisi_acc_vf_core_device *hssi_acc_drvdata(struct pci_dev *pdev) core_device); } -static void vf_qm_fun_reset(struct hisi_acc_vf_core_device *hisi_acc_vdev, - struct hisi_qm *qm) +static void vf_qm_fun_reset(struct hisi_qm *qm) { int i; @@ -662,7 +661,10 @@ static void hisi_acc_vf_start_device(struct hisi_acc_vf_core_device *hisi_acc_vd if (hisi_acc_vdev->vf_qm_state != QM_READY) return; - vf_qm_fun_reset(hisi_acc_vdev, vf_qm); + /* Make sure the device is enabled */ + qm_dev_cmd_init(vf_qm); + + vf_qm_fun_reset(vf_qm); } static int hisi_acc_vf_load_state(struct hisi_acc_vf_core_device *hisi_acc_vdev) -- 2.33.0