Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <408fbc89-8711-0ea2-16e7-99b746e1f09e@linux.alibaba.com>
Date:   Thu, 15 Sep 2022 10:44:37 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.2.1
Subject: Re: [PATCH] mm/hugetlbfs: use macro SZ_1K to replace 1024
To:     Al Viro <viro@zeniv.linux.org.uk>
Cc:     akpm@linux-foundation.org, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org, mike.kravetz@oracle.com,
        songmuchun@bytedance.com, SeongJae Park <sj@kernel.org>
References: <20220914115723.38271-1-xhao@linux.alibaba.com>
 <YyIEsuOm0wEkmpAA@ZenIV>
From:   haoxin <xhao@linux.alibaba.com>
In-Reply-To: <YyIEsuOm0wEkmpAA@ZenIV>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk


在 2022/9/15 上午12:43, Al Viro 写道:
> On Wed, Sep 14, 2022 at 07:57:23PM +0800, Xin Hao wrote:
>> Using macro SZ_1K in hugetlbfs_show_options() has no any functional
>> changes, just makes code more readable.
> Why is it any more readable that way?
The main purpose of this code is to convert size to 'K', and 'M'. I 
think using SZ_1k does look more appropriate than 1024, that's all.
>> Signed-off-by: Xin Hao <xhao@linux.alibaba.com>
>> ---
>>   fs/hugetlbfs/inode.c | 6 +++---
>>   1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/fs/hugetlbfs/inode.c b/fs/hugetlbfs/inode.c
>> index f7a5b5124d8a..9b9784ffe8de 100644
>> --- a/fs/hugetlbfs/inode.c
>> +++ b/fs/hugetlbfs/inode.c
>> @@ -1023,10 +1023,10 @@ static int hugetlbfs_show_options(struct seq_file *m, struct dentry *root)
>>   	if (sbinfo->max_inodes != -1)
>>   		seq_printf(m, ",nr_inodes=%lu", sbinfo->max_inodes);
>>
>> -	hpage_size /= 1024;
>> +	hpage_size /= SZ_1K;
>>   	mod = 'K';
>> -	if (hpage_size >= 1024) {
>> -		hpage_size /= 1024;
>> +	if (hpage_size >= SZ_1K) {
>> +		hpage_size /= SZ_1K;
>>   		mod = 'M';
>>   	}
>>   	seq_printf(m, ",pagesize=%lu%c", hpage_size, mod);
>> --
>> 2.31.0