Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <d7241682-fdf3-4ef9-f262-de26dae12c9f@gmail.com>
Date:   Wed, 14 Sep 2022 22:22:43 -0500
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH v2 5/6] acpi/x86: s2idle: Add a quirk for ASUS ROG
 Zephyrus G14
Content-Language: en-US
To:     Philipp Zabel <philipp.zabel@gmail.com>,
        Mario Limonciello <mario.limonciello@amd.com>
Cc:     rafael@kernel.org, linux-kernel@vger.kernel.org,
        catalin@antebit.com, travisghansen@yahoo.com,
        Shyam-sundar.S-k@amd.com, Len Brown <lenb@kernel.org>,
        linux-acpi@vger.kernel.org
References: <20220912172401.22301-1-mario.limonciello@amd.com>
 <20220912172401.22301-6-mario.limonciello@amd.com> <YyC0u0nedouZemfq@rog>
From:   Matthew Anderson <ruinairas1992@gmail.com>
In-Reply-To: <YyC0u0nedouZemfq@rog>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

Tested and confirmed working on my Zephyus G14 laptop.

On 9/13/22 11:50 AM, Philipp Zabel wrote:
> Am Mon, Sep 12, 2022 at 12:23:59PM -0500 schrieb Mario Limonciello:
>> ASUS ROG Zephyrus G14 is affected by the same BIOS bug as ASUS TUF
>> Gaming A17 where important ASL is not called in the AMD code path.
>> Use the Microsoft codepath instead.
>>
>> Reported-and-suggested-by: Philipp Zabel <philipp.zabel@gmail.com>
>> Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
>> ---
>> v1->v2:
>>   * New patch
>> ---
>>   drivers/acpi/x86/s2idle.c | 8 ++++++++
>>   1 file changed, 8 insertions(+)
>>
>> diff --git a/drivers/acpi/x86/s2idle.c b/drivers/acpi/x86/s2idle.c
>> index 9ee734e0c3c5..4bdc7133d2ea 100644
>> --- a/drivers/acpi/x86/s2idle.c
>> +++ b/drivers/acpi/x86/s2idle.c
>> @@ -420,6 +420,14 @@ static const struct dmi_system_id s2idle_dmi_table[] __initconst = {
>>   			DMI_MATCH(DMI_PRODUCT_NAME, "ASUS TUF Gaming A17"),
>>   		},
>>   	},
>> +	{
>> +		/* ASUS ROG Zephyrus G14 (2022) */
>> +		.callback = lps0_prefer_microsoft,
>> +		.matches = {
>> +			DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
>> +			DMI_MATCH(DMI_PRODUCT_NAME, "ROG Zephyrus G14 GA402"),
>> +		},
>> +	},
> Tested-by: Philipp Zabel <philipp.zabel@gmail.com>
>
> regards
> Philipp
>
>