Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <76919d92-0a85-8c83-c434-ba8998d19a07@gmx.de>
Date:   Thu, 15 Sep 2022 07:34:48 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.1
Subject: Re: [PATCH] parisc: remove obsolete manual allocation aligning
Content-Language: en-US
To:     Rolf Eike Beer <eike-kernel@sf-tec.de>,
        linux-parisc@vger.kernel.org
Cc:     linux-kernel@vger.kernel.org
References: <2442384.MTfJ8ztCV8@eto.sf-tec.de>
From:   Helge Deller <deller@gmx.de>
In-Reply-To: <2442384.MTfJ8ztCV8@eto.sf-tec.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On 9/14/22 16:23, Rolf Eike Beer wrote:
> kmalloc() returns memory with __assume_kmalloc_alignment, which is
> __alignof__(unsigned long long) for parisc.
>
> Signed-off-by: Rolf Eike Beer <eike-kernel@sf-tec.de>

applied.

Thanks!
Helge


> ---
>   drivers/parisc/iosapic.c | 11 +----------
>   1 file changed, 1 insertion(+), 10 deletions(-)
>
> I must confirm it's entirely untested.
>
> diff --git a/drivers/parisc/iosapic.c b/drivers/parisc/iosapic.c
> index 3a8c98615634..bdef7a8d6ab8 100644
> --- a/drivers/parisc/iosapic.c
> +++ b/drivers/parisc/iosapic.c
> @@ -221,16 +221,7 @@ static size_t irt_num_entry;
>
>   static struct irt_entry *iosapic_alloc_irt(int num_entries)
>   {
> -	unsigned long a;
> -
> -	/* The IRT needs to be 8-byte aligned for the PDC call.
> -	 * Normally kmalloc would guarantee larger alignment, but
> -	 * if CONFIG_DEBUG_SLAB is enabled, then we can get only
> -	 * 4-byte alignment on 32-bit kernels
> -	 */
> -	a =3D (unsigned long)kmalloc(sizeof(struct irt_entry) * num_entries + =
8, GFP_KERNEL);
> -	a =3D (a + 7UL) & ~7UL;
> -	return (struct irt_entry *)a;
> +	return kcalloc(num_entries, sizeof(struct irt_entry), GFP_KERNEL);
>   }
>
>   /**