Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <86318454-d5cd-3787-a88f-41be40967c4d@gmx.de>
Date:   Thu, 15 Sep 2022 07:44:38 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.1
Subject: Re: [PATCH] parisc: Increase the usage check of kmalloc allocated
 object a
Content-Language: en-US
To:     Rolf Eike Beer <eike-kernel@sf-tec.de>,
        Li zeming <zeming@nfschina.com>,
        James.Bottomley@hansenpartnership.com
Cc:     linux-parisc@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20220914060428.4039-1-zeming@nfschina.com>
 <1668528.WaZXzWfjLs@eto.sf-tec.de>
 <3a72852c-2f28-2916-f02c-b52cb06efd7d@gmx.de>
 <7266457.TOmriZnqnj@eto.sf-tec.de>
From:   Helge Deller <deller@gmx.de>
In-Reply-To: <7266457.TOmriZnqnj@eto.sf-tec.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On 9/14/22 16:25, Rolf Eike Beer wrote:
> Am Mittwoch, 14. September 2022, 11:04:33 CEST schrieb Helge Deller:
>> On 9/14/22 08:43, Rolf Eike Beer wrote:
>>> Am Mittwoch, 14. September 2022, 08:18:19 CEST schrieb Helge Deller:
>>>> On 9/14/22 08:04, Li zeming wrote:
>
>> Yes, your proposal is good.
>> Anyone want to send a patch (with a small comment that kcalloc() will r=
eturn
>> at least the required 8-byte alignment)?
>
> Done.
>
>>> And these functions end up propagating an allocation error in this fil=
e
>>> and it will never reach kernel/setup.c, which seems bad.
>>
>> That part I don't understand.
>> The return value of iosapic_alloc_irt() is checked afterwards, but you
>> probably meant something else?
>>
>>> But I guess the only point where this really can go wrong if the PDC
>>> returns an absurdly large number of entries.
>
> What I meant was that if iosapic_alloc_irt() fails, then iosapic_load_ir=
t()
> will return 0, which can either be "nothing to do" or "error". iosapic_i=
nit()
> is void, so even if it could detect the failure, it can't report it upwa=
rds to
> parisc_init(). Which is the same for basically all other *_init() calls =
in
> there.

Ok, I see.
Not sure if that needs fixing. If the allocation fails we will be in troub=
le anyway :-)

Helge