Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Wu Bo <bo.wu@vivo.com>
To:     phdm@macq.eu
Cc:     bo.wu@vivo.com, wubo.oduw@gmail.com, jaegeuk@kernel.org,
        linux-f2fs-devel@lists.sourceforge.net,
        linux-kernel@vger.kernel.org
Subject: Re: [f2fs-dev] [PATCH 1/1] f2fs: fix to check space of current segment journal
Date:   Thu, 15 Sep 2022 15:10:04 +0800
Message-Id: <20220915071004.23550-1-bo.wu@vivo.com>
In-Reply-To: <20220914080839.GA19067@172.21.0.10>
References: <20220914080839.GA19067@172.21.0.10>
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?FXJy5wr5r7/WuET0ieFZoM+lkw7Vo3H2BRNa/6WdtHeV22it7+AFL+lMeC8P?=
 =?us-ascii?Q?+1jjT8dTERacMeuAbfHsp6DbkmFWCql/PBXpwFotmisHwrUg3aiHxfCWBGtL?=
 =?us-ascii?Q?OL9RFFDg4KmXlq0wuDfjX5hTPUryCLsCVhP7xhSTz+gEvxJn2fYhoZM9E3F0?=
 =?us-ascii?Q?CcWfaYXvixV9yZYz8YFtxl7Wa+2hnJxVAV7SaQqOpNir5K5c3cW1KcppLmhu?=
 =?us-ascii?Q?VI9rtHHOOGt/RcOd1UjialaLggn3Lqlt0c8hqcrFqj3udwBsTPQrAvXDZHgV?=
 =?us-ascii?Q?2jTEPyyydBGLC+9O60azPCJZ/IrkQ6BsuMb2iBiGPGZABqFuhCCfRk7CYzwy?=
 =?us-ascii?Q?t+1wPz5TnFjC6HHCbg7esZ0Pnip/RNsb2Dr391YZXUOLXZeITeFU0f+MoyoN?=
 =?us-ascii?Q?R+Y3vIEniZPZb16AL+Sm7Li9bZV32+8uSYaGRKlJOxPb12JDkGLa9v2LtUFM?=
 =?us-ascii?Q?lQOp6pxUquDROTLvDz2XLbi11aHTkC37F/Qiwm/sG7f2UVSYM1+CjgpdXA61?=
 =?us-ascii?Q?D7VmYw0+D6E20F1a0j3IsGb9H4rytf5yZZSHnRLpULdDt5w5oOzqy3YM3CvA?=
 =?us-ascii?Q?Z9AEqNie+yvAhdw13Yja/l+NnnLxlxNfQli+bI81jKZAKL2/nn6KQxNyKdSC?=
 =?us-ascii?Q?Z6+tJUyqtbTFIJ4wRqWU54ZPhSLvoyZecAPRQQZlvljdZFt1WRqunPJMSrpf?=
 =?us-ascii?Q?CCiiGmyJi8j4A0lnb0SRCCga+IsNTIjVJz0Cm/8k0NO5rNbocRTGH9gkhq7g?=
 =?us-ascii?Q?VnaJoDPDz5D6A14eEinHpdMupHvL7H6lII0971qeeHqY7pLvVQsGVssNWcMm?=
 =?us-ascii?Q?0X51a/1aTwhxOKXtT18q9xfIlCLlaDkErXeuX1mDkhF/Dp2EH7PwcdAUKqGM?=
 =?us-ascii?Q?Q2lMdc3VnrnVzqdlnSUq6t3PWJrxZErioRn+MVlqIUwNK7sSMNnwEjiRtxeK?=
 =?us-ascii?Q?2/BBBX+JFjOwpzBQMTAdP2baFTlXE10AObFIaucEPsMlo2nbZIU+3cfF6OL4?=
 =?us-ascii?Q?EJJxJ86xko7jCS3NHauui2WhZjnTfnj0Kav1otJifQH4PGqkabJVWyOZiAB6?=
 =?us-ascii?Q?rEAfwtZ3kiR9uux2xJ0u8rMSs317IPe1RkQjCOS9QKLq21nBqQmgfCOfihCW?=
 =?us-ascii?Q?d6oPu+ykr7y1liupP5CMYtQasgSxYozW5/gB0CMo9ydP7Yk+sj98dZLRGeFC?=
 =?us-ascii?Q?ggYkiVlFsWvrGmRHg9/fOWEEYqPXbml9xOpIaBaUYTEQzc1CMUlxHc0Cjmax?=
 =?us-ascii?Q?/vxDjiN+ksAWaE70kmVrW+H85ktJQUJJ6OHC7rcxnenLTwSESr4XZl9WmSX1?=
 =?us-ascii?Q?Io1KkSMWPti0kHwgcwQsJMAgZeu1uvpE239D/o27js1uT8P9a0FYNGwFhyLP?=
 =?us-ascii?Q?/JIGc12yoY7dvcXB7hG/+gEYomGiYh0lHip1XASWRamAxURiw1OMJjMVuOmN?=
 =?us-ascii?Q?8zTr7IiXUKzguLO9POVkV32WpikZgOft2WFtrb+0yw/R+SZDtxEgbnnJYZXV?=
 =?us-ascii?Q?BtxZJuWaK31DxRl3rvU/Le+Vdjt1Ih2sROauosHxtNWnmxmB0kVi3oMlUOXI?=
 =?us-ascii?Q?C6qeLbQlUWwykICOboN5SemMoqrOMATO7Aym+0Dc?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 69852c8e-31d2-47e9-5731-08da96e955a5
X-MS-Exchange-CrossTenant-AuthSource: SL2PR06MB3017.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Sep 2022 07:10:15.7134
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Sd1D4mM5BvJ2P0g9Inp+pD+6tYDNM82T1oaZvpTZW1HHuFHJTXCFfSKoWavG8sd0xaQJasEAva5j4ugneZgVOg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYZPR06MB4256
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 2022/9/14 16:08, Philippe De Muyter wrote:=0D
> Hello Wu Bo,=0D
>=0D
> On Wed, Sep 14, 2022 at 12:04:23PM +0800, Wu Bo wrote:=0D
>> As Philippe De Muyter reported:=0D
>> https://lore.kernel.org/linux-f2fs-devel/20220913224908.GA25100@172.21.0=
.10/T/#u=0D
>>=0D
>> The warning log showed that when finding a new space for nat the journal=
=0D
>> space turned out to be full. This because the journal_rwsem is not=0D
>> locked before the journal space checking. The journal space may become=0D
>> full just after we check it.=0D
>>=0D
>> Reported-by: Philippe De Muyter <phdm@macq.eu>=0D
>> Signed-off-by: Wu Bo <bo.wu@vivo.com>=0D
>> ---=0D
>>  fs/f2fs/node.c    |  6 +++---=0D
>>  fs/f2fs/segment.c | 10 +++++-----=0D
>>  2 files changed, 8 insertions(+), 8 deletions(-)=0D
>>=0D
>=0D
> Thank you for your patch.=0D
>=0D
> Unfortunately it does not apply to my 4.1.15 or newer 4.1.y sources,=0D
> and I do not have the knowledge of f2fs internals to modify your=0D
> patch myself.  E.g. 4.1.y lacks the '.journal' field in the=0D
> 'struct curseg_info'.=0D
>=0D
> Could you make a version suitable for 4.1.y ?=0D
=0D
My patch is just try to fix the 'offset < 0' warning you have meet. The=0D
probability of this is very low.=0D
=0D
To the fsck fixed report you found when doing fsck.f2fs, 'reset=0D
i_gc_failures' log seems normal. And 'Unreachable nat entries' maybe=0D
caused by the 'offset < 0' exception.=0D
=0D
If your filesystem doesn't report fsck failures after these 2 cases, I=0D
think you don't need to worry about it too much.=0D
=0D
Here is the patch for v4.1.y:=0D
=0D
diff --git a/fs/f2fs/node.c b/fs/f2fs/node.c=0D
index 8ab0cf1930bd..fc4d87a1ddf0 100644=0D
--- a/fs/f2fs/node.c=0D
+++ b/fs/f2fs/node.c=0D
@@ -1837,12 +1837,12 @@ static void __flush_nat_entry_set(struct f2fs_sb_in=
fo *sbi,=0D
 	 * #1, flush nat entries to journal in current hot data summary block.=0D
 	 * #2, flush nat entries to nat page.=0D
 	 */=0D
+	mutex_lock(&curseg->curseg_mutex);=0D
 	if (!__has_cursum_space(sum, set->entry_cnt, NAT_JOURNAL))=0D
 		to_journal =3D false;=0D
 =0D
-	if (to_journal) {=0D
-		mutex_lock(&curseg->curseg_mutex);=0D
-	} else {=0D
+	if (!to_journal) {=0D
+		mutex_unlock(&curseg->curseg_mutex);=0D
 		page =3D get_next_nat_page(sbi, start_nid);=0D
 		nat_blk =3D page_address(page);=0D
 		f2fs_bug_on(sbi, !nat_blk);=0D
>=0D
>=0D
> Best regards=0D
>=0D
> Philippe=0D
>=0D
>=0D