Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 15 Sep 2022 09:34:06 +0200
From:   Marcus Folkesson <marcus.folkesson@gmail.com>
To:     Benjamin Tissoires <benjamin.tissoires@redhat.com>
Cc:     Jonathan Corbet <corbet@lwn.net>, Jiri Kosina <jikos@kernel.org>,
        Linux Doc Mailing List <linux-doc@vger.kernel.org>,
        lkml <linux-kernel@vger.kernel.org>,
        "open list:HID CORE LAYER" <linux-input@vger.kernel.org>
Subject: Re: [RESEND PATCH 1/2] HID: Add driver for RC Simulator Controllers
Message-ID: <YyLVblZkIPCvNd/2@gmail.com>
References: <20220822060936.769855-1-marcus.folkesson@gmail.com>
 <CAO-hwJ+3Yrr--cr=r5+jvs4A=A-cmDtrKQETo=YOYDC3nXTMBg@mail.gmail.com>
 <YwTvrNuulKx0SB6H@gmail.com>
 <CAO-hwJKiq50fWwXNUGcXeWtWcUXb65ZmJMsADfrsUTac_Xj2dw@mail.gmail.com>
 <YwcbVJswrL1Doi4s@gmail.com>
 <CAO-hwJJ86oAuaFD+uX7Rwv7cASO=4mchRJ1UBTxz9gYs6M1rUg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="YVygXAnhv+jF8ybR"
Content-Disposition: inline
In-Reply-To: <CAO-hwJJ86oAuaFD+uX7Rwv7cASO=4mchRJ1UBTxz9gYs6M1rUg@mail.gmail.com>
Precedence: bulk


--YVygXAnhv+jF8ybR
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi Benjamin,

On Tue, Aug 30, 2022 at 02:45:11PM +0200, Benjamin Tissoires wrote:
> On Thu, Aug 25, 2022 at 8:44 AM Marcus Folkesson
> <marcus.folkesson@gmail.com> wrote:
> >


[...]
> >
> >
> > Is the fact that more than one button share the same
> > byte hard to describe in the report?
>=20
> No, this is actually easy to describe. You say that there is one usage
> of "something" which has a report size of 1 bit, and then you have
> another usage of "something else" with the same report size.
>=20
> But usually you have to add padding after to make up to 8 bits (so 6
> bits in that case).
>=20
> I was referring to the case  where you are parsing the same bit on the
> wire, and give a different usage based if you have received an odd or
> an even number of reports. In that case, we probably need to use move
> this bit to a const field in the original report descriptor and say
> that the data is now not const:
>=20
> - initial report (completely random example):
>   X (2 bytes) | Y (2 bytes) | button this_or_that (1 bit, depending of
> odd or even received reports) | 7 bits of padding
> - we can declare it as:
>   X (2 bytes) | Y (2 bytes) | button this (1 bit) | button that (1
> bit) | 6 bits of padding

How about if there is no unused bytes?

The XTRG2FMS has 8 10-bit channels and use every byte in the report.
Should I specify 8 8-bit channels instead and fix that in raw_event?
If so, should I only use 8bit values then?

(Are you at the ELCE conference btw?)

Best regards
Marcus Folkesson

--YVygXAnhv+jF8ybR
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEBVGi6LZstU1kwSxliIBOb1ldUjIFAmMi1WkACgkQiIBOb1ld
UjKsqw//Wa6YTjHrge5PlXpvnR0ytTXsv9mlzSouMVgMQkV1WsYPUxHHZ/CkhpQh
XImYzh0AE6gBMBVKOhoqD4qXt2LYIiAhdFHBjaYVx4ZVyv/s75D5E2kwTgrWPXdU
ImLA4N2SpMP7CmyadNWTcp4RrL79HxXzVABSP+rJz/+B+OfehoqKttlKX+02RDEP
O67fi0AiT7v4fmiI5In9n3Qu7tHNuE5TP9+Vt/S5uKRZGZ71Ms1xOWFFgs5Uk+6I
ekRelq/6Qe9FKIQSd/el6LxM5iSoeQJsUpLuUXBpXqhE9VYEa6WJW3qqO/k4syIb
cYCye1H7ktEmEeD5ld4MwDhNCNcjzIjScbx7eKK18TMVq2302sXvSV0QCVSINlCH
whaP8yotWIAWw3IQPQIOr2Xqb8No9SdUv/qhUqFIbnv6q5WSKuMICyXgwtZ01TFv
hKXdE/pqMQtD1zycoKbeqZyhKvbPvp+MCpD/6Z/gW14tvmV+/XO1K0fN/K11rHEy
glqGbV+Q4du7Q7VJjfTHy0WWIw+MA5Vkbnc1FAQNdbTZkUKKV6gFTBsIUdlFMmLU
hzNN1gmQq+xG5ZgUDC2cnhPa7RbtoMRUZiZWdgR1UvHyHPQwKp1+74dJ4RY9OEY5
hunre9lxYArInS5gAVkCoaFnHy5n/85389f6zotWnoKx8vdJxI4=
=rjYL
-----END PGP SIGNATURE-----

--YVygXAnhv+jF8ybR--