Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Subject: Re: [PATCH] m68k: fix the comments of via_rtc_send
To:     Deming Wang <wangdeming@inspur.com>, funaho@jurai.org,
        geert@linux-m68k.org
References: <20220915014737.1620-1-wangdeming@inspur.com>
Cc:     linux-m68k@lists.linux-m68k.org, linux-kernel@vger.kernel.org
From:   Michael Schmitz <schmitzmic@gmail.com>
Message-ID: <1e8ed681-9a73-d45a-97bd-9d75d2323f82@gmail.com>
Date:   Thu, 15 Sep 2022 19:42:17 +1200
User-Agent: Mozilla/5.0 (X11; Linux ppc; rv:45.0) Gecko/20100101
 Icedove/45.4.0
MIME-Version: 1.0
In-Reply-To: <20220915014737.1620-1-wangdeming@inspur.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

Here we go again ...

In the interest of avoiding further patches of this nature, can we 
please change the comment to read:

'The bits of the byte go into the RTC in MSB order'

That ought to make it abundantly clear the duplicate 'in' isn't. (As 
would have looking at comment in the the function just before 
via_rtc_send() ...)

Cheers,

	Michael

Am 15.09.2022 um 13:47 schrieb Deming Wang:
> remove the double word of 'in'.
>
> Signed-off-by: Deming Wang <wangdeming@inspur.com>
> ---
>  arch/m68k/mac/misc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/m68k/mac/misc.c b/arch/m68k/mac/misc.c
> index 4fab34791758..29a4cb46af01 100644
> --- a/arch/m68k/mac/misc.c
> +++ b/arch/m68k/mac/misc.c
> @@ -126,7 +126,7 @@ static void via_rtc_send(__u8 data)
>
>  	reg = via1[vBufB] & ~(VIA1B_vRTCClk | VIA1B_vRTCData);
>
> -	/* The bits of the byte go in in MSB order */
> +	/* The bits of the byte go in MSB order */
>
>  	for (i = 0 ; i < 8 ; i++) {
>  		bit = data & 0x80? 1 : 0;
>