Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932244AbXFSTEV (ORCPT ); Tue, 19 Jun 2007 15:04:21 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932169AbXFSTEN (ORCPT ); Tue, 19 Jun 2007 15:04:13 -0400 Received: from pentafluge.infradead.org ([213.146.154.40]:47056 "EHLO pentafluge.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1763872AbXFSTEM (ORCPT ); Tue, 19 Jun 2007 15:04:12 -0400 Date: Tue, 19 Jun 2007 20:04:07 +0100 From: Christoph Hellwig To: Andrew Morton Cc: Cedric Le Goater , Christoph Lameter , Linux Kernel Mailing List , Herbert Poetzl , Pavel Emelianov Subject: Re: [PATCH -mm] add a kmem_cache for nsproxy objects Message-ID: <20070619190406.GA3830@infradead.org> Mail-Followup-To: Christoph Hellwig , Andrew Morton , Cedric Le Goater , Christoph Lameter , Linux Kernel Mailing List , Herbert Poetzl , Pavel Emelianov References: <4676F0B9.3080408@fr.ibm.com> <20070619113501.a88bba50.akpm@linux-foundation.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20070619113501.a88bba50.akpm@linux-foundation.org> User-Agent: Mutt/1.4.2.3i X-SRS-Rewrite: SMTP reverse-path rewritten from by pentafluge.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 915 Lines: 24 On Tue, Jun 19, 2007 at 11:35:01AM -0700, Andrew Morton wrote: > On Mon, 18 Jun 2007 22:53:13 +0200 > Cedric Le Goater wrote: > > > +static int __init nsproxy_cache_init(void) > > +{ > > + nsproxy_cachep = kmem_cache_create("nsproxy", sizeof(struct nsproxy), > > + 0, SLAB_PANIC, NULL, NULL); > > + return 0; > > +} > > + > > Christoph added this cheesy KMEM_CACHE macro. But I don't immediately recall > the rationale so I'm a bit reluctant to ask people to use-the-cheesy-macro. > > Perhaps he can remind us why it is there? Hmm, I must have missed the macro going in. Frankly speaking I plain hate it. It's a rather useless obsfucation. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/