Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 15 Sep 2022 11:14:59 +0200
From:   Niklas =?iso-8859-1?Q?S=F6derlund?= 
        <niklas.soderlund@corigine.com>
To:     Joe Perches <joe@perches.com>
Cc:     Dwaipayan Ray <dwaipayanray1@gmail.com>,
        Lukas Bulwahn <lukas.bulwahn@gmail.com>,
        Jonathan Corbet <corbet@lwn.net>,
        Andy Whitcroft <apw@canonical.com>, linux-doc@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        Philippe Schenker <philippe.schenker@toradex.com>,
        Stephen Rothwell <sfr@canb.auug.org.au>,
        oss-drivers@corigine.com, Simon Horman <simon.horman@corigine.com>,
        Louis Peens <louis.peens@corigine.com>
Subject: Re: [PATCH v7] checkpatch: warn for non-standard fixes tag style
Message-ID: <YyLtEza0VhSbflvH@oden.dyn.berto.se>
References: <20220914100255.1048460-1-niklas.soderlund@corigine.com>
 <aa858ac592679fdf512debe17e0612c575450860.camel@perches.com>
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <aa858ac592679fdf512debe17e0612c575450860.camel@perches.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?iso-8859-1?Q?hHd4Fr2GdYGM8EeCOe79n9F3XV5BEl9VB6f4JAt7iNmY8/UHgKQYQQHGX0?=
 =?iso-8859-1?Q?sZ/Ue4tkcZg7RiqTD9AvvwHyPC5j9HMmcLDgnf1ij3wgoYY5uXULr6UYxl?=
 =?iso-8859-1?Q?0V8rCkqqWEVSPOAV2b17m6ZE/vgzVfI4ewiwvSoW7ohcFMNnq/wpz8ycX/?=
 =?iso-8859-1?Q?lc2DKiIfgGY52RO4BYumxmESbDdRMIUm/FIsPMxchSIQvkNiJhD4bWnr5O?=
 =?iso-8859-1?Q?cC7NIx/DFUXv/cMgmmT27jzWYCLklHchuMPbbAraV3uq17PphOmq4mAimv?=
 =?iso-8859-1?Q?2+Hw2VOJncn6w1DnKECmWEKrSfPayyDfJCp4et9K2To1SiVIhIl6Kr6InX?=
 =?iso-8859-1?Q?9pLEJ4JIPAzJuayC2tV3ueAFBkbW2k/v1weVI7iqAc+oEIUQt0CCRYJDTH?=
 =?iso-8859-1?Q?9pIxFB1+WGNh69VcO0FV5DqxIIR+OTbOlVHoXTjBbdeeWGoE5PYxWg6Tda?=
 =?iso-8859-1?Q?3O9SEqHwOIDYw7jVzyt20xqN3IVfX0yU4V0zci939nriqvo06QlryB8fTQ?=
 =?iso-8859-1?Q?5t1vQWkGxZzWds/ueVGT8/odCTxtIhKru5wtXneX17Ye/yB2zgUfPazqAa?=
 =?iso-8859-1?Q?K1pPZAYIFOgXV/uOAT6tdMZuzXyir9SNPhh11iGKzpsAD3MfOE2w2LiEJy?=
 =?iso-8859-1?Q?v8dRaq6W0491ohRi0rFC33ir3ZXtW16tcwB6Nm+QmAMcAulbsaqNxgzWPE?=
 =?iso-8859-1?Q?ydPLgLE0cBI23pIEh9CnVnTAgQZ3kq9QPWMDkbtuKm6ypZ2GPNdwZ8pWzi?=
 =?iso-8859-1?Q?SphM6qPIeWj2kHAhgKrr7Mg9R7lIZU0ThQcUlqtxzXbewKHz0WYOqaH1QU?=
 =?iso-8859-1?Q?QxgHhvOvVMp0ILiuR+KrKI69sYkvvlXbcN3609WsFicsjIdrD0DFh3oujW?=
 =?iso-8859-1?Q?+ifLJG/L2XXUj8yz5jJuZ3x8biDMi8ew0nwy148ngyCR/66bphXEHY7hx3?=
 =?iso-8859-1?Q?Eux47SNpMYYShTCAbm0GLZl2KVO7qv5th3yx9dL5Ok2IqETYQjvFjzPX1F?=
 =?iso-8859-1?Q?bjmy18oM8Bndr3+qxvJphQhe4yGtJ+ZOz/Ynyk7d9NOAM9TF2f1Cy+ArqZ?=
 =?iso-8859-1?Q?ndx+FV6tm+4aE+Yn6OWq0vKzeKl3my4Nm2BK8SjlFe7BPTb529oU7BbvaI?=
 =?iso-8859-1?Q?1DipNq6EWGG/2nUrNf1UU/ORKKIwPQYWlVDPWEyJ7CiQqmqDJeF+oVuwid?=
 =?iso-8859-1?Q?ZtmFqIbDJPrPbpya/jZkuhmRbxUMAqr6fU3AwrSnlnyNzqyDbSzrJAixTQ?=
 =?iso-8859-1?Q?Yf4+ewYs2F6FkeUlxfU4W7ynSAXkbkkRjkCeTN/qVAjvfTN/wshKukTNSO?=
 =?iso-8859-1?Q?s4OwQEs5TKIPVrNwzfs+BAGxad2wNGk1CDwXtXoClT8q1ly6M0mxDgEYh3?=
 =?iso-8859-1?Q?wr+jdKqkpx0eTGULJJGHraxVVCCY3IpG69vXI3DuXhER2+PPLtJSFihxX9?=
 =?iso-8859-1?Q?a4tutAVAMLNz+EevI5LnCnGfDTPkCalN5hXpD8IymVLYoLmZkvcz34wQmu?=
 =?iso-8859-1?Q?6/NrUXLwPwXaBPtLlGiZTfRe1jHGF2Z/lMacVImwHTSV8/6DUrz8RMPyHO?=
 =?iso-8859-1?Q?CC1QV79z8EOEmCqrcB8OoPapDDP3ieatkXT7XFOglHS8fK91RnJqqt3E3g?=
 =?iso-8859-1?Q?w5S3JWEmH4qoLr1TvTjG/YL4cZhS2DrxZ079/fV+SNvNWvGO39w/jBiQ?=
 =?iso-8859-1?Q?=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR13MB5681
X-Spam-Status: No, score=-1.7 required=5.0 tests=BAYES_00,DKIM_INVALID,
        DKIM_SIGNED,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,
        SPF_PASS autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Joe,

On 2022-09-14 09:09:25 -0700, Joe Perches wrote:
> On Wed, 2022-09-14 at 12:02 +0200, Niklas S?derlund wrote:
> > Add a warning for fixes tags that does not follow community conventions.
> []
> > * Changes since v6
> > - Update first check to make sure that there is a likely SHA1 of some
> >   minimum length after the fixes line.
> 
> https://lore.kernel.org/lkml/2febb7893346b6234983453de7c037536e479bfc.camel@perches.com/
> 
> The goal here should be to identify a line that looks like a commit
> reference.
> 
> So find lines that starts with 'fixes' and have a SHA1 commit id as
> broadly as reasonable.
> 
> Did you run the grep pattern and look at the results?
> 
> One grep pattern to verify the non canonical fixes format that
> are mistakenly used is:
> 
> $ git log --since=5-years-ago --no-merges --grep='^\s*fixes' -i --format=email -P | \
>   grep -P -i '^\s*fixes' | \
>   grep -P -v '^Fixes: [0-9a-f]{12,12}\s*\(".*")'
> 
> []
> 
> There are many different styles.
> Parenthesea are sometimes not used.

I understand this, and I did have a look at it.

> 
> > +			if ($line =~ /(\s*fixes:?)\s+([0-9a-f]{5,})\s+($balanced_parens)/i) {
> 
> How about some pattern like
> 
> 	/fixes\s*:?\s*(?:commit:?\s*)?[0-9a-f]{5,}/i
> 
> or maybe even more broadly:
> 
> 	/fixes\b.*\b[0-9a-f]{5,}\b/i

Maybe I misunderstand your comment, but this is what I do in this patch?

    if (!$in_header_lines &&
        $line =~ /^\s*fixes:?\s*(?:commit\s*)?[0-9a-f]{5,}\b/i) {

        ...

        if ($line =~ /(\s*fixes:?)\s+([0-9a-f]{5,})\s+($balanced_parens)/i) {
            ...
        }
    }

This will catch and warn about such tags but not attempt to break out 
it's components in order to suggest a potentially more correct fix. Is 
it this second filter you would like me to change?

-- 
Kind Regards,
Niklas S?derlund