Received: by 2002:a05:6358:489b:b0:bb:da1:e618 with SMTP id x27csp593408rwn; Thu, 15 Sep 2022 03:43:09 -0700 (PDT) X-Google-Smtp-Source: AA6agR5ex1qhRgz3CW9JUYTYwZCrr+OyEnvNvySWl8/hu4bNR80HiFMZuNhf+caVpaTWnk4XNqiX X-Received: by 2002:a65:6bd3:0:b0:42b:9117:b9d1 with SMTP id e19-20020a656bd3000000b0042b9117b9d1mr35658877pgw.238.1663238589695; Thu, 15 Sep 2022 03:43:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1663238589; cv=none; d=google.com; s=arc-20160816; b=vmYrU1M8mB5UgSPV7770L8Ha1dGkQehAOMmnUSlk+LgvdO6nmigSb6b1mqkrGKiJsW tVKG81Mbl53NEcbHkDFCmow2EUYnHPEIuSn9iIbLf7LcnBRqMdH+hJcVX0SGnS1A0FR5 ZX9p9kkqVWncV1NXuLoeQwAjqaEBqZ63vYf64cvcb4WBK0XdmlJkybwFqqn/heHnW9hs LX8s/AJgHj5OrkW6YFz9BQvIFP6WioXfpj8TjV+CUrrM8wDdPaZKe2FmV+U0wAe4H/Zd GQEeCnVfekw0nEfKIDK8+3m3jGNSTWrRp2hlOgkxW4QgQKvzK6Q5kK4sdlEjQgIU8SOK SVDQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=J5mscqBjskoIJTmbE49fccjEFLGV2r8MvVioIABdkxI=; b=eCf6DzRGBLAbS2IGdZJKETB0CoWNldBAfUrt/w/gwooGQoqm/I7gGJ/nUKs4v62RHH XqNmnNtUdYlE40PNrVvM2lS5u+BA+GEiK3MtlOMLaXYBBF+bLckQJgfmERH3KwTTUKyR pg8DPV7mIBgaLcnbG1pxWL+3ZcVtUXAg+ysyerN+nh4GGJWsd9Po6QKgSiMTrUvQa355 Kz82rVBUsBzA0K9k3lhXLj1+XrDQy3B6cGmwixmFwo1Hf/d4zyompoHVLg98dvyCEJaE 6DO4wWAjbSsTxuvzIuUaiA2zfHD454gwq0ob76z+IKTSNuZ1emc7qkz9gRkqy4GQIeFf xQuw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=dKPxgbQR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=collabora.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id b2-20020a636702000000b0042b325d85cdsi19095691pgc.215.2022.09.15.03.42.57; Thu, 15 Sep 2022 03:43:09 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=dKPxgbQR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=collabora.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229942AbiIOKeR (ORCPT + 99 others); Thu, 15 Sep 2022 06:34:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37846 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229952AbiIOKeO (ORCPT ); Thu, 15 Sep 2022 06:34:14 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D43D298A4C for ; Thu, 15 Sep 2022 03:34:10 -0700 (PDT) Received: from [192.168.1.100] (2-237-20-237.ip236.fastwebnet.it [2.237.20.237]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: kholk11) by madras.collabora.co.uk (Postfix) with ESMTPSA id C68D96601AAA; Thu, 15 Sep 2022 11:34:08 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1663238049; bh=J5mscqBjskoIJTmbE49fccjEFLGV2r8MvVioIABdkxI=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=dKPxgbQRShNmGL/b7jZx4PFKNG282zTyXxU+SfgKnAbV4J6/XFebgfvLrEn6pGQYt xgThBVrgkdLdLKlmjs+zn33eG57xjFbB2AOdRagNudkFEaGNghFNB80NPjvM5AqBGk I3FWJCRpuDyZUXbfoItND/0tPF/peiUJw3580L6T3aRZLuzP0Ust49x2AKczfZo2yP OVSJ5Jxa7tS4KXIpll+cEgFvlwh0FxosQUuV7q1gGC1E0PmMFp05tyTvIGGTjPztmb HdNUnD3thRUbkvjOwrWpG6TEJ5KEL4T2ZiDDunFB3MgKIZ709DdrmSXjJxibvI1jDr 6saRbAzdJcLOQ== Message-ID: <47c6f2a3-ad38-c9c6-544b-5b2d1a234593@collabora.com> Date: Thu, 15 Sep 2022 12:34:06 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.0 Subject: Re: [PATCH 1/3] drm/mediatek: dp: Refactor drivers in mtk_dp_bdg_detect() Content-Language: en-US To: Bo-Chen Chen , chunkuang.hu@kernel.org, p.zabel@pengutronix.de, airlied@linux.ie Cc: matthias.bgg@gmail.com, granquet@baylibre.com, daniel@ffwll.ch, jitao.shi@mediatek.com, ck.hu@mediatek.com, liangxu.xu@mediatek.com, dri-devel@lists.freedesktop.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Project_Global_Chrome_Upstream_Group@mediatek.com References: <20220915075028.644-1-rex-bc.chen@mediatek.com> <20220915075028.644-2-rex-bc.chen@mediatek.com> From: AngeloGioacchino Del Regno In-Reply-To: <20220915075028.644-2-rex-bc.chen@mediatek.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Il 15/09/22 09:50, Bo-Chen Chen ha scritto: > It is more clear to modify this in mtk_dp_bdg_detect(). I agree with this commit. Since you anyway have to send a v2 of this series, please clarify the commit description and title, something like: drm/mediatek: dp: Reduce indentation in mtk_dp_bdg_detect() In order to improve human readability, reduce the indentation by returning early if the dp/edp cable is not plugged in. Cheers, Angelo