Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220912113856.817188-1-robert.foss@linaro.org>
 <20220912113856.817188-3-robert.foss@linaro.org> <CAD=FV=WrH2AAFxV72FZqk-=xU8jzCn6KtcbZRYJAaCwhmvSWmg@mail.gmail.com>
 <Yx9FZDKjOcS9wmcI@pendragon.ideasonboard.com>
In-Reply-To: <Yx9FZDKjOcS9wmcI@pendragon.ideasonboard.com>
From:   Robert Foss <robert.foss@linaro.org>
Date:   Thu, 15 Sep 2022 12:32:54 +0200
Message-ID: <CAG3jFytreStdyLLhUB+gHb3dHnEfUNr66BPQHkU8VdfjYYQiUw@mail.gmail.com>
Subject: Re: [PATCH v1 2/2] Revert "drm/bridge: ti-sn65dsi86: Implement bridge
 connector operations for DP"
To:     Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc:     Doug Anderson <dianders@chromium.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@vger.kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Jonas Karlman <jonas@kwiboo.se>,
        David Airlie <airlied@linux.ie>,
        Thomas Zimmermann <tzimmermann@suse.de>,
        dri-devel <dri-devel@lists.freedesktop.org>,
        Neil Armstrong <narmstrong@baylibre.com>,
        Chris Morgan <macromorgan@hotmail.com>,
        LKML <linux-kernel@vger.kernel.org>,
        Jernej Skrabec <jernej.skrabec@gmail.com>,
        Javier Martinez Canillas <javierm@redhat.com>,
        Lubomir Rintel <lkundrak@v3.sk>,
        Rob Herring <robh+dt@kernel.org>,
        Andrzej Hajda <andrzej.hajda@intel.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Mon, 12 Sept 2022 at 16:43, Laurent Pinchart
<laurent.pinchart@ideasonboard.com> wrote:
>
> On Mon, Sep 12, 2022 at 03:29:52PM +0100, Doug Anderson wrote:
> > On Mon, Sep 12, 2022 at 12:43 PM Robert Foss <robert.foss@linaro.org> wrote:
> > >
> > > As reported by Laurent in response to this commit[1], this functionality should
> > > not be implemented using the devicetree, because of this let's revert this series
> > > for now.
> > >
> > > This reverts commit c312b0df3b13e4c533743bb2c37fd1bc237368e5.
> > >
> > > [1] https://lore.kernel.org/all/20220902153906.31000-2-macroalpha82@gmail.com/
> > >
> > > Signed-off-by: Robert Foss <robert.foss@linaro.org>
> > > ---
> > >  drivers/gpu/drm/bridge/ti-sn65dsi86.c | 28 ---------------------------
> > >  1 file changed, 28 deletions(-)
> >
> > Any chance you got confused and reverted the wrong patch? This
> > ti-sn65dsi86 patch doesn't seem relevant to the problems talked about
> > in the commit or the cover letter. Maybe I'm missing something?
>
> Aarghhh I missed that when checking the cover letter :-( This indeed
> seems wrong.

Yep. This is a mistake. I copy/pasted the wrong line and then assumed
that ti-sn65dsi86 & chrontel-ch7033 shared a driver. I'll look into my
workflows to try to prevent future mistakes of this nature.

A series fixing this has been posted.
https://lore.kernel.org/all/20220915102924.370090-1-robert.foss@linaro.org/

Thanks for catching this Doug!


Rob.