Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Vladimir Oltean <vladimir.oltean@nxp.com>
To:     netdev@vger.kernel.org
Cc:     Vinicius Costa Gomes <vinicius.gomes@intel.com>,
        Jamal Hadi Salim <jhs@mojatatu.com>,
        Cong Wang <xiyou.wangcong@gmail.com>,
        Jiri Pirko <jiri@resnulli.us>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Voon Weifeng <weifeng.voon@intel.com>,
        Vladimir Oltean <olteanv@gmail.com>,
        Kurt Kanzenbach <kurt@linutronix.de>,
        linux-kernel@vger.kernel.org
Subject: [PATCH v2 net-next 6/7] net/sched: taprio: add extack messages in taprio_init
Date:   Thu, 15 Sep 2022 13:50:45 +0300
Message-Id: <20220915105046.2404072-7-vladimir.oltean@nxp.com>
In-Reply-To: <20220915105046.2404072-1-vladimir.oltean@nxp.com>
References: <20220915105046.2404072-1-vladimir.oltean@nxp.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?EfcBw/7GzLlPActJcLR5dIcFarl6sWM85rJOyA7IijwjZFCGSC9xir3tSccp?=
 =?us-ascii?Q?3URTym0GPtyD5JUZYuTTq7WTObO6RePjLtN30ZxCoXR2luWH3XL3xIKM3pKH?=
 =?us-ascii?Q?3di8jaNaGUQez+46VIyTgi0gN5XRx5MocdgZaQ9lnm93gs6Dh7pbrP7g9KCx?=
 =?us-ascii?Q?3jjFO0M0xCgGMlik8b/mTCEV9TBPaHFgQjLo4cJCEVuUkQoQq2DbmXPwDSBR?=
 =?us-ascii?Q?ztNF2bTaQ8ttc+qhKfjMMzfHNcHTI+U/ejUOQQDW3L7nv2gCJZ2PxVunUEHS?=
 =?us-ascii?Q?wRTWQhuWvVMktVB2hMXwxksWmKeNgWpjUJsA8YHZUtc1ybJuBOuBKO2Z6Zud?=
 =?us-ascii?Q?sb1HA2osgZiDqHclioIgZGBzsDrcn4o16Y19DEKVns0K8l/QmBlz03CGq93j?=
 =?us-ascii?Q?39psbqHuvmvw0y9h44EnahZpEviOXPAIk4l9nLebLDYC5KN3alUIilhWWbtv?=
 =?us-ascii?Q?tdnAIhpoQREUYQbLyxZum+WjSeQpjl8nxlY226nEH0g/VWCH5PKd/JBz95y1?=
 =?us-ascii?Q?2dz2d5ugbyF5yhHeph0abNOYwfj/ihD9yw/M+yesEttzY+6HLrg/XQ6eI7Q0?=
 =?us-ascii?Q?lkHO1slBVqSt9Dnwz80kLYqLIRpYy/ukYOoLRFGCkZtgSdSSBzn36GlcnleT?=
 =?us-ascii?Q?AXWxI0o0/3muyj7D/RvE0Cy5GmHNr3W2KRyJsEZ2fY4Uva+oR1rDw0qE5V+4?=
 =?us-ascii?Q?FXlK1cJp4txzBKBnXig8FivC+yFhJIH9Q6WxaHPKhBLxe0YMzX6oK3cQ4IZM?=
 =?us-ascii?Q?1c3XgZ/j9cnahaqdv9Uiy2dRxjYXjVnpb2KXjafxEGUOKps5SAUAjh9uTSuF?=
 =?us-ascii?Q?FEsC7IT/FPQlrc6EXELbya47sprrhUnmXvqT6zibjAdf08i+dEjzzEKl9FN2?=
 =?us-ascii?Q?9cyXQGoQCTLQ+/9ZL96CkHS3W8gIYhYOeJSaGfCvPDbC9XSQhARF0N7M/l+0?=
 =?us-ascii?Q?0Ss2Z+Rb2Y730Eyig22TXXymmyCEdWnhKJyIWuKf7I80JDqEtmOoz+ek8/SO?=
 =?us-ascii?Q?u7W+4SsS56T7Q++ogesK51665sk/GetnbykPZDu0da8+c2ct9aiyb2Vgf/NP?=
 =?us-ascii?Q?fAI/RpGPLeRy0TeDSg868klV5Z0HKVGm5+xEQPFQ+oPLiCCvCDkZn5pC5ilM?=
 =?us-ascii?Q?MYdZowfL9XfYfuy5gv2SJXqXxDyehFFGKRhBHE6tgweYAvLqOiwcBlZFaTet?=
 =?us-ascii?Q?gJyB1LIM2NgqI8NtUY46OXZT5//CxFj1g6wpRLYg4QajrK6BzN/O1e6q5dQv?=
 =?us-ascii?Q?61lHXAwmnlbj4okCTfsHsSzGwNATRvFGQDiNe16a2LsUtZVDDvi9vhM+11tq?=
 =?us-ascii?Q?gqmC2ScM+ZQtZnuxfT2fKmh9I6nZcyDHUV4jPllolSQlCZLBO+Qul6/p+HIa?=
 =?us-ascii?Q?sch7Gp1UKwmFR5gUowDmEdA/FFLJEwhGRPBUpnBcBgy7WVAI1N7daAXu6yCh?=
 =?us-ascii?Q?gG46OPGd5WUeWvo3f2WSz1tohegbAymda+PUmpZUV1dl4qw3oRTNvuc0s94a?=
 =?us-ascii?Q?e7tQg28+iF0RH62kUwtifO1QN1lpdNUKKJKgEOfex+wZpFOxwylTXDEgeWKg?=
 =?us-ascii?Q?Ai3lY8aMyCckB85m9NG9WjSY6Z0AnK1GnB0qpmIdhc2iRRY1vlr2LSDymvB9?=
 =?us-ascii?Q?5Q=3D=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e4da418a-a40d-47a2-4f8a-08da97082e28
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5136.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Sep 2022 10:51:01.7835
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 4fQF5Ogg67B1VQUlycfimiw56+IwFuoK5/svh1vwJLUNomYVsx0DHvTY/2XFj6605yaKNlhrsD8r5OI3yLU67A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR04MB7163
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Stop contributing to the proverbial user unfriendliness of tc, and tell
the user what is wrong wherever possible.

Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
---
v1->v2: none

 net/sched/sch_taprio.c | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/net/sched/sch_taprio.c b/net/sched/sch_taprio.c
index f3eadea101e1..bc93f709d354 100644
--- a/net/sched/sch_taprio.c
+++ b/net/sched/sch_taprio.c
@@ -1663,11 +1663,15 @@ static int taprio_init(struct Qdisc *sch, struct nlattr *opt,
 	list_add(&q->taprio_list, &taprio_list);
 	spin_unlock(&taprio_list_lock);
 
-	if (sch->parent != TC_H_ROOT)
+	if (sch->parent != TC_H_ROOT) {
+		NL_SET_ERR_MSG_MOD(extack, "Can only be attached as root qdisc");
 		return -EOPNOTSUPP;
+	}
 
-	if (!netif_is_multiqueue(dev))
+	if (!netif_is_multiqueue(dev)) {
+		NL_SET_ERR_MSG_MOD(extack, "Multi-queue device is required");
 		return -EOPNOTSUPP;
+	}
 
 	/* pre-allocate qdisc, attachment can't fail */
 	q->qdiscs = kcalloc(dev->num_tx_queues,
-- 
2.34.1