Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <cbfbe832-db39-8681-239a-75d612111394@amd.com>
Date:   Thu, 15 Sep 2022 14:06:16 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH v4 4/6] dma-buf: dma_fence_wait must enable signaling
Content-Language: en-US
To:     Arvind Yadav <Arvind.Yadav@amd.com>, andrey.grodzovsky@amd.com,
        shashank.sharma@amd.com, amaranath.somalapuram@amd.com,
        Arunpravin.PaneerSelvam@amd.com, sumit.semwal@linaro.org,
        gustavo@padovan.org, airlied@linux.ie, daniel@ffwll.ch,
        linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org,
        linaro-mm-sig@lists.linaro.org, linux-kernel@vger.kernel.org
References: <20220914164321.2156-1-Arvind.Yadav@amd.com>
 <20220914164321.2156-5-Arvind.Yadav@amd.com>
From:   =?UTF-8?Q?Christian_K=c3=b6nig?= <christian.koenig@amd.com>
In-Reply-To: <20220914164321.2156-5-Arvind.Yadav@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NU9IRGsrNGtZZ2NVMXhic0N6STVlTTU2N0xMM2k2OEp5em1iREtoVk1KcnBz?=
 =?utf-8?B?YnZNZFJsWHZNSVBvZmJSd2daZTRmZFp2dTBtZ1Q1QzFNMWtxbmczRnNWZ0RE?=
 =?utf-8?B?ajUwQnYxUzhEaDAwWVNHSmRDekdzRWxBYnVScHVLRFV3L0lSczU3S1RpdUUz?=
 =?utf-8?B?Z3hBY1VKc1JWbGtBR3hlYlJVNlFMWEh4MVQxNjlWZzRxN3BxR1U2YmhLQ3Fm?=
 =?utf-8?B?R0k5ODFDMEh1R2kydEZBOFdIM3dMREkzQUlPVFRtb3JiODFKd2RxKzl2YVFr?=
 =?utf-8?B?UEJGNm5JakNhSXhEMW81cGJpc0ZrbHcwZWg3eUl0MDd3UzM3dUJBcE1GMndj?=
 =?utf-8?B?bFZtTVdFbTlFRWV0ZnFEUnRLcGVubys0TVE0NTROTkt2dGZKbnZ4YlRWK3R3?=
 =?utf-8?B?OUlWQmNpQ0pVMG9mRjRpM3I3c1YySGs4MUNHZGp4RCs1emNaRERVUTMzNElo?=
 =?utf-8?B?M0d0Uit0bitrdjdjcWJEMy9CNnQwaG11RXROZ2FMMkg3cWJwc1NtSFlnWE9x?=
 =?utf-8?B?bnJwS1d4UUFIdVpuU3BSK29mVUlIdmo4UmlkRFM1eVJzT0IwclpjTmVLdG9i?=
 =?utf-8?B?N0QwY21kQ1NQdzhvSmlHVkpRMDJEcHZuZnM2RTRrU2I3SFY2cDFycmV6YVpM?=
 =?utf-8?B?TjdhVzQ4WHVra2dUMXFWSWx6NEhwQ2ZhbFhZODFySmM2Z2szb1c4OG9QVEd2?=
 =?utf-8?B?bFk3Z3dYMXdNclVranI0My80enNmQ2JYbzZyUXZUWXZsUkJNMGtYdldZRmxq?=
 =?utf-8?B?cmZEbmVOUDMyY0I5WlhyMk1VSTljNDVTL0NNVW5WU2t4QWEyeXBkWDRDWUJJ?=
 =?utf-8?B?Q3BXNjBiMEVDd1JzSm5TNjNtMEw5M3o2RjBydk5TbUpzQ3NkM2V3YmM4TlQ4?=
 =?utf-8?B?eXAzN0phTkZ3ZkcvZ3d1T0p5L3NTTEdCbHhOeWpZbmlvbnBzTW9BMFZyS2E0?=
 =?utf-8?B?Q1VTZFZDZkN4bjNITDRQOUl3ajVHN0tud2lGUE4wb0NZNnJVTDhBMzJTYWxF?=
 =?utf-8?B?WFZWYkE3VTZuNVByRmJNc0RxaTBnM25KMFBSVUZDMTdER0JMeUhEQlB0ZVRW?=
 =?utf-8?B?YzZKRmdSM25HWm5iOEpXd1QvcVBtWnMrRXpDSUhtSTczVGR1LzRrZWVkRmFP?=
 =?utf-8?B?OGRtNmlyNStWSTV1dG1ZTmtBRU1DMjF6dWJhMjIyRmZYL08rbFRoeU84Z0dz?=
 =?utf-8?B?ODlQbmJOVmRDYUxaRlFQNU52eWo2SEF3OXc4NUNMaEI0MklzZStjVXhVbTdW?=
 =?utf-8?B?RWY2SVhSbmc4MmVRTVE5dkt0TktoUUZmY2dxZUwwTzFya3RZWklHYzRMVHZJ?=
 =?utf-8?B?M1ZDdEFHcSt3M3ZOTE9zdUtyV2ZhSnFsWUwrMWFrU0VwS2lLaXZTb0Rad1gx?=
 =?utf-8?B?bktoUWVGZ2FZQzlTc1lvZDBFZU1GMmtTMTlBR2Y4czY1cDFMOXpsVHZYZ2s3?=
 =?utf-8?B?ZHQ3Tkk3cklZSkpTbEg2UDNtczdtT0VuWUdwZUJLZEVYa3NSNHorUWs4TzdD?=
 =?utf-8?B?eVZkUmdTMkhUSVhkYTgwOFkvOVltTlc2K2lmM3kzWW5Uc0t4NE5DdXgxNDFE?=
 =?utf-8?B?MWdRdUpGalFaOCtSNGNRQkg1OFZJS1A1Mktkem1mVVBmY2xETmt0MCtBbHU2?=
 =?utf-8?B?Ni9YUmhCM2VNZXVYS1VWZDdYREh0QzZMNmZick5lcTJJdldLeXh5b3d1bTZB?=
 =?utf-8?B?RnhZbFNOc204ZWx0NE1PRmdMdTRuME44TjZ1WjRIV2JYdGNxKzFseW1hOUxq?=
 =?utf-8?B?TzdVak5TajI3WFRqaTNjanJhU093b1hyYkwvb3RmaFZoYnZSSGRyS3RDdnpF?=
 =?utf-8?B?Q2JSSEJFRm8yTm92Z2NOVDd5OUVsSGc3eUFvZ3llQWlCNXZ2eTBGUnVwSzJX?=
 =?utf-8?B?ZEFGZUdMN29zUms2TThQTWJnZVkwTjQ1b21WelRCdmVFeHgzblBzcEVudnhM?=
 =?utf-8?B?Szg3cDVzZlhaZ1l2QWNXbDVMWjlzMXdiWis5RU1TSEgzdmVsbWdtMzJXM3BZ?=
 =?utf-8?B?b2sxRW92ZmtDN2ZiQ2RDYlJKT1Y5RGZlOEZvZ0ZoeXNoWldScEw1YWxLa2dt?=
 =?utf-8?B?N2FWMkV1UTRTM01Oa01wUTlRKy9abGlOS0ZzSVdLMUtCMXlodDk1cTJWRTJI?=
 =?utf-8?Q?GQrLVJQ8QLcl6K+PsNurYZWwb?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 44e5e829-5ff3-4627-f759-08da9712b6e7
X-MS-Exchange-CrossTenant-AuthSource: BN8PR12MB3587.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Sep 2022 12:06:26.3644
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: cgaUx13/v/UAqcxfAbJV/Tg4wrPzP4nfYxyOj5K32K5brl9s0VsoImz+gSnIIPwi
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4287
X-Spam-Status: No, score=-3.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Am 14.09.22 um 18:43 schrieb Arvind Yadav:
> dma_fence_wait() should always enable signaling even
> when the fence is already signaled.
>
> Signed-off-by: Arvind Yadav <Arvind.Yadav@amd.com>

Reviewed-by: Christian König <christian.koenig@amd.com>

> ---
>
> Changes in v1..v3: This new patch was not part of previous series.
>
> ---
>
>   drivers/dma-buf/dma-fence.c | 5 ++---
>   1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/dma-buf/dma-fence.c b/drivers/dma-buf/dma-fence.c
> index 645c158b7e01..a5fbf1c1e0ea 100644
> --- a/drivers/dma-buf/dma-fence.c
> +++ b/drivers/dma-buf/dma-fence.c
> @@ -508,6 +508,8 @@ dma_fence_wait_timeout(struct dma_fence *fence, bool intr, signed long timeout)
>   
>   	__dma_fence_might_wait();
>   
> +	dma_fence_enable_sw_signaling(fence);
> +
>   	trace_dma_fence_wait_start(fence);
>   	if (fence->ops->wait)
>   		ret = fence->ops->wait(fence, intr, timeout);
> @@ -771,9 +773,6 @@ dma_fence_default_wait(struct dma_fence *fence, bool intr, signed long timeout)
>   		goto out;
>   	}
>   
> -	if (!__dma_fence_enable_signaling(fence))
> -		goto out;
> -
>   	if (!timeout) {
>   		ret = 0;
>   		goto out;