Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <893fc57d-7a49-4b39-ff74-867579141b22@amd.com>
Date:   Thu, 15 Sep 2022 14:06:49 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH v4 6/6] dma-buf: Check status of enable-signaling bit on
 debug
Content-Language: en-US
To:     Arvind Yadav <Arvind.Yadav@amd.com>, andrey.grodzovsky@amd.com,
        shashank.sharma@amd.com, amaranath.somalapuram@amd.com,
        Arunpravin.PaneerSelvam@amd.com, sumit.semwal@linaro.org,
        gustavo@padovan.org, airlied@linux.ie, daniel@ffwll.ch,
        linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org,
        linaro-mm-sig@lists.linaro.org, linux-kernel@vger.kernel.org
References: <20220914164321.2156-1-Arvind.Yadav@amd.com>
 <20220914164321.2156-7-Arvind.Yadav@amd.com>
From:   =?UTF-8?Q?Christian_K=c3=b6nig?= <christian.koenig@amd.com>
In-Reply-To: <20220914164321.2156-7-Arvind.Yadav@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dHdFc251VDdnOEdkWEZtR3RvWTJNRkpzL0dESTJsNnVjcmxJTUxKTTAzS1lr?=
 =?utf-8?B?YkdqTS8rMHBIVlhxbDdEbnZ0QnR6UVNHZHVtOGl1SmROMXU2cjVDLzB0Sk42?=
 =?utf-8?B?cmtRU3JrRHB4bFVYOGlQVGE1MVFncDR2cVlVTHpjTnpoSUZJTkJNalBtTGxk?=
 =?utf-8?B?cjFiQzNra0VKNjY4TlJXbzBhSUpQMkd6QTA5akc5ejg5UHN1WlRRZHNmc1BQ?=
 =?utf-8?B?c0xuOENhcDlxbkpSeTRhTlVZL2dlQ1dwcTdYM29lOFV3ODhOZmVnSWcxQ1Nu?=
 =?utf-8?B?NVhoY2tsaGZxVUJTbWFRUURzd0FLL2V0ZU1ya3ZGelNwaE9WeFJHeGsycTA2?=
 =?utf-8?B?VXBUeGMvOXE0aGt6QzFhQ2l3QzdGbVdwUXVNU1hRb3BTQ0VPcVc1M2dvdTN5?=
 =?utf-8?B?c2VTbWJBY1MzcDNOTlhyY0dmUlpwb2d2cndCV2d3aGtzTTZyRnlnSmMxQXZT?=
 =?utf-8?B?Y0tXWW1YMUNYQ0ZxTmxMSjBBL0E1aVZMbVkxanh0REdCYmZScUkwR3JnRWZY?=
 =?utf-8?B?dFJOc2E5cUszYSs0N0VuSTMxL3RIcGVtSlRXRm9kVnp5aWVpakFJNXlBVjdI?=
 =?utf-8?B?ME44a2dLenMvMnlpbmYvOUJlcE95RHlTMzUvTlZWbWJJZXJaTDV6M3NEWnZE?=
 =?utf-8?B?SWQvQzRQRWI1MDllRDJNSStKbCtGZTdhOVc5MURvNi9WUTY1R3JacjZOZlBy?=
 =?utf-8?B?N3V4RkJTajNWMyt1c0syUmNzRzAvVHJTeFpmWWRFRHY4YjlyZDJMK2FqV2dM?=
 =?utf-8?B?bk5ud2JjbFhIdnNiajhZVXFQNjc1cWlnMVZha04vY09TYzBqZ1QrSTBMbE9w?=
 =?utf-8?B?c0JyeE5rMzlrRnkxRHVkL25yZkV5bG44bG12cjhoOTkzTHR1OHRycEpLVitk?=
 =?utf-8?B?bElIWU5BN1dDSHFMdkhNY1NSL3F0aTlITzBCbU9qa0FUOUlqWW92Tll6dnNK?=
 =?utf-8?B?eTJBdkt4dStFUXBGV3JBSHNiaDFCck1RbUVIeEpodW5NbGkrVGRPZFcvZ2xM?=
 =?utf-8?B?c3MvRS9uMXdXZWxXRmpFalB2WkxyYm5SOHl5RlR3U1A2dXplaE5tUVhZcnN6?=
 =?utf-8?B?QUdoLzd4UHk0WHBDVnBOZDZ6WEsySXl0VkJVdzNDc0NDb3MzM0J0ZUxEWG1m?=
 =?utf-8?B?TUlERDdsN2dRNGYzUjltMUdodFRSQ0V2YThZZHhQWnVMU0w3OFNhYTVsQkNq?=
 =?utf-8?B?ck5kQk53S1BxSHpuRjdRMTY3VnIzcG5GNTUvOFlTR2UvWmUwRlJpUXdqa3RV?=
 =?utf-8?B?MjNoZnN4WVlFc1RHcEVCRThPLzROaGMwZWR6b0ZMaHpJdnBOQ0RScjBFaEFD?=
 =?utf-8?B?bXpOYzE4TGNVY1hiUFpsaFJKZXBRV25iWHBIemhwenprK2w4TElndi9ITkc3?=
 =?utf-8?B?T0JNb3UyeDhkRGlTcXlaL0FUcWEvWlVzRXZ1WGlCYmxxOE9kdjB1b3pNQlZx?=
 =?utf-8?B?NVgxanYzY0ZYaWFycE4yOU1KVFZxd1dacUl6V3lhTXEwOEhQOGZBTmJYUTFz?=
 =?utf-8?B?WW05Mnk1Z084OVViNHpoQ1c4c3g4a3F2d2djdHFlZ05VdTBOc201NDZFazkx?=
 =?utf-8?B?RW92TFBPNml0a093N2tOREdkcmRtZEhSRnFRbWp1S1ZzVmRaS2lXbUxFZUx4?=
 =?utf-8?B?SjlNZFhjY1I2cVVhbmJRRnd0N1BPeW8rcXlWYXRCOUU4TGgvVEsyRFM2aEcy?=
 =?utf-8?B?SjZ5bDNyanRpYWNLN1JjeU1XcHNQc2V1VjZiQjFCTVoydTVsWFFnQTZpdHh5?=
 =?utf-8?B?NzV6a09aUDZSQ2F0OCthUzNCcytHRFFGaGFKN3U1Z1A3emRYODk5NitGMlhT?=
 =?utf-8?B?OHl3Z0ljZTExdDlnYXF6ZjZPQ2lDdnJMR2c4U2plOVlJb1N5Yi9aTzVKWlc2?=
 =?utf-8?B?a3lEV1I3RGs4NGM5bGFNWnRwcldseHNHWXUralVEYUZmNm1SblZqZFNnMXdu?=
 =?utf-8?B?ME50d1gxTmpXR2tMYXN0R0o5ZDZTSVhicmxUZFFEdkNUTndtVEMrOUJ5TGJq?=
 =?utf-8?B?bmI3azlzbngybUNJYXFpZElFUFEzMm81QTUyREtYSC8yVzdGYnRqNHNnSno1?=
 =?utf-8?B?UFdPZU1VY040dEpqcEhVOEQ2cnVidldtbkY3Zm93V1E1TGV0T3lmVzdDaFhM?=
 =?utf-8?Q?rfooHUr03ORYZiEQ+PfC4ML6z?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 53afd2f5-2815-42c2-fd1e-08da9712c8d9
X-MS-Exchange-CrossTenant-AuthSource: BN8PR12MB3587.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Sep 2022 12:06:56.3937
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: UaZEn9Cv+DL0KZd+eoJ6UYWR2Dq8EDWEOHYo9/jQGVbq7/LvxSlMEgY/jzBpoyt0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4287
X-Spam-Status: No, score=-3.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Am 14.09.22 um 18:43 schrieb Arvind Yadav:
> Fence signaling must be enabled to make sure that
> the dma_fence_is_signaled() function ever returns true.
> Since drivers and implementations sometimes mess this up,
> this ensures correct behaviour when DMABUF_DEBUG_ENABLE_SIGNALING
> is used during debugging.
> This should make any implementation bugs resulting in not
> signaled fences much more obvious.
>
> Signed-off-by: Arvind Yadav <Arvind.Yadav@amd.com>

Reviewed-by: Christian König <christian.koenig@amd.com>

> ---
>
> Changes in v1,v2 :
> 1- Addressing Christian's comment to replace
> CONFIG_DEBUG_WW_MUTEX_SLOWPATH instead of CONFIG_DEBUG_FS.
> 2- As per Christian's comment moving this patch at last so
> The version of this patch is also changed and previously
> it was [PATCH 1/4]
>
> Changes in v3:
> 1 - Adding new config DMABUF_DEBUG_ENABLE_SIGNALING.
> 2 - Replace CONFIG_DEBUG_WW_MUTEX_SLOWPATH to new
> CONFIG_DMABUF_DEBUG_ENABLE_SIGNALING.
>
> ---
>   drivers/dma-buf/Kconfig   | 7 +++++++
>   include/linux/dma-fence.h | 5 +++++
>   2 files changed, 12 insertions(+)
>
> diff --git a/drivers/dma-buf/Kconfig b/drivers/dma-buf/Kconfig
> index e4dc53a36428..c991e6a51510 100644
> --- a/drivers/dma-buf/Kconfig
> +++ b/drivers/dma-buf/Kconfig
> @@ -65,6 +65,13 @@ config DMABUF_SELFTESTS
>   	default n
>   	depends on DMA_SHARED_BUFFER
>   
> +config DMABUF_DEBUG_ENABLE_SIGNALING
> +	bool "DMA Fence enable signaling debug checks"
> +	default n
> +	depends on DMA_SHARED_BUFFER
> +	help
> +	  This option enables additional checks for software signaling of fence.
> +
>   menuconfig DMABUF_HEAPS
>   	bool "DMA-BUF Userland Memory Heaps"
>   	select DMA_SHARED_BUFFER
> diff --git a/include/linux/dma-fence.h b/include/linux/dma-fence.h
> index 775cdc0b4f24..01e1fa4d3cec 100644
> --- a/include/linux/dma-fence.h
> +++ b/include/linux/dma-fence.h
> @@ -428,6 +428,11 @@ dma_fence_is_signaled_locked(struct dma_fence *fence)
>   static inline bool
>   dma_fence_is_signaled(struct dma_fence *fence)
>   {
> +#ifdef CONFIG_DMABUF_DEBUG_ENABLE_SIGNALING
> +	if (!test_bit(DMA_FENCE_FLAG_ENABLE_SIGNAL_BIT, &fence->flags))
> +		return false;
> +#endif
> +
>   	if (test_bit(DMA_FENCE_FLAG_SIGNALED_BIT, &fence->flags))
>   		return true;
>