Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <d2d81ffd-2269-bdc6-0daa-8f3a99306e46@amd.com>
Date:   Thu, 15 Sep 2022 14:07:49 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH v4 0/6] dma-buf: Check status of enable-signaling bit on
 debug
Content-Language: en-US
To:     Arvind Yadav <Arvind.Yadav@amd.com>, andrey.grodzovsky@amd.com,
        shashank.sharma@amd.com, amaranath.somalapuram@amd.com,
        Arunpravin.PaneerSelvam@amd.com, sumit.semwal@linaro.org,
        gustavo@padovan.org, airlied@linux.ie, daniel@ffwll.ch,
        linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org,
        linaro-mm-sig@lists.linaro.org, linux-kernel@vger.kernel.org
References: <20220914164321.2156-1-Arvind.Yadav@amd.com>
From:   =?UTF-8?Q?Christian_K=c3=b6nig?= <christian.koenig@amd.com>
In-Reply-To: <20220914164321.2156-1-Arvind.Yadav@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UDNzV1JML0dLd0YvSEpobmFhSzBiL1VyZmdTREFoSFF5bjlUbGVCWS8yMUdJ?=
 =?utf-8?B?N2R1T25xUFlSNjR1UDVMZVZCZElYS0IyeWdqbGl6SVFVTGNUalNiVnBPcGxn?=
 =?utf-8?B?b29ydXVObmhORi9jSkZqK2IvRER3S2dhbUJTaFhMM0J4V3hZNloreDBhT04x?=
 =?utf-8?B?djNZY1Z4TFJROS9ubDFDYmJKQ3RqZnB0NEw4SjV6aSszYnlSYXdQRWUyalJT?=
 =?utf-8?B?NEtvT3k2WG1sdmFVNStrd2M1VkFkYStOUGlzOTRaaEl3MWNreElab0NxT0tl?=
 =?utf-8?B?WjRWU3A0bDVWRVdHdHk3Y1R5UlFGRGRTRUhidHdsbU9MZmdTT2ZiM1dnUE05?=
 =?utf-8?B?VEV4eFZ1cEk0T1VlekxFdUs3WTZBRVczUTN4VXZ0WitQWnRkano5NU1BL2sv?=
 =?utf-8?B?K2NSblZuKzkyY2xTRERvUkxKYjFJc1daeklFb1NFYml0MkhxdDkvRFRlZm5L?=
 =?utf-8?B?Ry9qY3ZFZlFDeGg3K3hkWXZOYmloR0RzSlByQnZKdUdmc3Y4aUlsY0lNcTY4?=
 =?utf-8?B?T2Nqc2tzUThOdE1xOFRMekFmSlltZFAvOGpnRDltR3EzK1BuZTkyeGErVVBn?=
 =?utf-8?B?UjBKVFdOTnFZZDVTdzNqZkMyTE1mM2hRZG54ZVc3WWxRbjcyQ0x5UlZzZ0xH?=
 =?utf-8?B?U00rV29EMHNpYVNITllrc0hXdlJzdExGZ0k5ZjFNSU5DdFo3VGZtTVlpTmtM?=
 =?utf-8?B?MU1wenJ6bFlGcWRuUE9kdnREZXlya3lqbkRBdVc2a0pTamV3UVQ3N3d0M3F5?=
 =?utf-8?B?bkQ1bzdDNGsxTnhKVjZjQlRVTVB6T2pJbmlsMWdQRmtlWEtTMFJuQ2x5b1ht?=
 =?utf-8?B?dnk3UURzQzJTUHlNOUVRME0rZHRzWitLV0J5aFAwVjNoVWZQTHZqN0Y0T1dw?=
 =?utf-8?B?elBjU2RpTm5Zejh1OXg0QTZrbFltODlnbmRXR1pyb2xuRG1nTE1Hc1ZQT2Qr?=
 =?utf-8?B?OUFzL256WUl5aFM3dW5kTnNKMEhad1VKTTZpZ0JQMHpua29TcXNEaDAvNG5o?=
 =?utf-8?B?d0FBc3BoR1JLRXZmMWxUSTlMdEpJQktTb0x0cHlmN1VwNmxFSzJwWlJiaCt6?=
 =?utf-8?B?am5kVzRFb1F0citnUnMwSERaK29VQ20yNkt2SWVKblBKcnlCaVVXSnptRExk?=
 =?utf-8?B?eW16cnBhengreFlhV2YxRWIyMFNqZDl6cXZYUnJUZGRLMHgrbk94azBKNWhF?=
 =?utf-8?B?Z3ZuZWZPdXowd21ESzJlUFZZUlJ4NVBVaWFCcVN4SkZxalZCTy9JYWFkU2di?=
 =?utf-8?B?VzdiRGNmOEJYMlZjOVNTL1A1cy82WU1odmJjKzc5dFQ5c01PQTdHUk5tSEtE?=
 =?utf-8?B?REhFS3I0NjVNUUZWR2J6UVJsWThKZUNKelVDbDBpNFd3VTVYVndCVkdEVEI1?=
 =?utf-8?B?S3BlZkdKaHkvSjlsOWk4SXlqSE1DNEM2KzlnMUQ4b1B1ZWpzQzdjTGdmcnpN?=
 =?utf-8?B?M0x6blJ2bDRYOVpiVWZkN1JVK0ovdDJGVysxQU9YUy9PVXNnMGhOOVZ1a3h4?=
 =?utf-8?B?dVFWSHJ0VFljU2xmbUtXamhrRFJsSWJPdGlaMEMzTUc3ejRyVVlDNE1UamhS?=
 =?utf-8?B?SzQwTVRkZGJPTU50Qk13dDJEazJxSG9vMWt1eUJnWnVWLzBWQmtTYVJ4dUJC?=
 =?utf-8?B?SDdUYTZxb2hzZzdsUDRlOG5xakVvWjZYUHkrU2pNN1BBOHpRTlY3S0FwcHF2?=
 =?utf-8?B?L2M5MzlJeXR5eEc4RFVFSWxTbW4wTFhKVUVLdnphcHdBK0Q4VEgzdUhKYzhC?=
 =?utf-8?B?M2xaUjJNalJ3MFVvZnMveFVTMUF2WWtLVncwbVNMZnJnRC9sSG9EbFQxQ1Ax?=
 =?utf-8?B?eFdNNjZ0QTk2ZU1HL05SL01TS2ZTbmxJNC9VMWh6YSs1S2l0cUpkeGRYSGtl?=
 =?utf-8?B?dE0rbjJDeEhidHZEdkJha0RlVS9waTZYQ3FTUWlrR3hHNXN2bXpvZUtpNjhi?=
 =?utf-8?B?bzJMM1RBVjVkOERGaFlDV3dkMG9mQm1xemFXZVlMQVNDNWNmWHB0dFJGVGxv?=
 =?utf-8?B?SGd0TXNBc2tHWjZHWi9MNG4xSWNOOTZQOTZjVWo4K3JSOXZFTUJ3V3FkNFJy?=
 =?utf-8?B?Ny9YWEZOSGhIcVZaU2NRVG5GWldXZ01sNHViNVNrbzJtRG1xcGFoWUErcWlY?=
 =?utf-8?Q?jZxZTgGmCsRQwVVL2QcN3pp/z?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9affd3a7-5bb2-497d-aac5-08da9712ec5e
X-MS-Exchange-CrossTenant-AuthSource: BN8PR12MB3587.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Sep 2022 12:07:55.9835
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: pxFw5PZGRmFjhXHOmymmQ09FSSQri3+LhR5t/RygvO5NnntqHiTuWNVR+qrFQkVO
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW5PR12MB5599
X-Spam-Status: No, score=-3.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Is that sufficient to allow running a desktop on amdgpu with the extra 
check enabled? If yes that would be quite a milestone.

What's left is checking the userspace IGT tests. Especially the 
sync_file and drm_syncobj tests I would expect to have problems with 
this extra check.

Thanks,
Christian.

Am 14.09.22 um 18:43 schrieb Arvind Yadav:
> Fence signaling must be enabled to make sure that
> the dma_fence_is_signaled() function ever returns true.
> Since drivers and implementations sometimes mess this up,
> this ensures correct behaviour when DEBUG_WW_MUTEX_SLOWPATH
> is used during debugging.
> This should make any implementation bugs resulting in not
> signaled fences much more obvious.
>
> Arvind Yadav (6):
>    [PATCH v4 1/6] dma-buf: Remove the signaled bit status check
>    [PATCH v4 2/6] dma-buf: set signaling bit for the stub fence
>    [PATCH v4 3/6] dma-buf: Enable signaling on fence for selftests
>    [PATCH v4 4/6] dma-buf: dma_fence_wait must enable signaling
>    [PATCH v4 5/6] drm/sched: Use parent fence instead of finished
>    [PATCH v4 6/6] dma-buf: Check status of enable-signaling bit on debug
>
>   drivers/dma-buf/Kconfig                |  7 +++++++
>   drivers/dma-buf/dma-fence.c            | 16 ++++++++++------
>   drivers/dma-buf/st-dma-fence-chain.c   |  4 ++++
>   drivers/dma-buf/st-dma-fence-unwrap.c  | 22 ++++++++++++++++++++++
>   drivers/dma-buf/st-dma-fence.c         | 16 ++++++++++++++++
>   drivers/dma-buf/st-dma-resv.c          | 10 ++++++++++
>   drivers/gpu/drm/scheduler/sched_main.c |  4 ++--
>   include/linux/dma-fence.h              |  5 +++++
>   8 files changed, 76 insertions(+), 8 deletions(-)
>